From patchwork Tue Oct 4 15:05:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Hadjinlian X-Patchwork-Id: 678131 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3spMg15y75z9t15 for ; Wed, 5 Oct 2016 02:05:49 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=mvRLC1pE; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 4E1AA336F0; Tue, 4 Oct 2016 15:05:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Mt-HVy1teFYs; Tue, 4 Oct 2016 15:05:42 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 0331333553; Tue, 4 Oct 2016 15:05:42 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 3A8711CEB77 for ; Tue, 4 Oct 2016 15:05:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 370C787F5A for ; Tue, 4 Oct 2016 15:05:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ETUmlleUmp4Z for ; Tue, 4 Oct 2016 15:05:39 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 6203F87F52 for ; Tue, 4 Oct 2016 15:05:39 +0000 (UTC) Received: by mail-wm0-f67.google.com with SMTP id f193so15518793wmg.2 for ; Tue, 04 Oct 2016 08:05:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=Hbu1J4Yaqo3EtRzm2iCBDCEHuifU+MsmOWvupkNKt0I=; b=mvRLC1pE6mdYE5OrF9PnTTQZcvvNjK6XRuv4YTDNO1OV97DociGhDPFT+udlu7HxjH wigDKOUNIPLK0d0Q1oNvQ2SQdKCGfJhTA8ZKVMayEGmOx0hNn9ORDPV3wz5be9nM7lTj q083SoJJpTsDFXC0bTK7vW5XokNhHBxQWLCF+JrjFau27OLWTp8furK5sc6uy72bZygo J19JXxKnH/8ZMEBme7VgvrNgV5UQUdiEc3z2kL20CVvzlVIFfXOBcFJcZKhlGrEoSl0/ pQUdccxaP1Af6EI/OOfWyf7caqAL41ZVbjlQ1WgvkxLd1UgxmRlSsvEB5twckPKmtc9t n3Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Hbu1J4Yaqo3EtRzm2iCBDCEHuifU+MsmOWvupkNKt0I=; b=WY3V//E0dNZF2iCceS5j0D3tFwY6QFcjiU1TzYx8vefPcDphGXrBawJB/XEfh4rfDt Z+xEF0PE9nQaopsN0KJ5OKmhGQApzlfcq033ZjykZ0dFcrdUZMFl8z2OIyRmgGk0bCeH xtaebSOBecUl9nmXsxG7N96sTH07IU4HyEejONbUxCosbzGiB1H1G3T86tV2Q4fsLk5G nUllpk0++7pTWR76bc5kl/xWK98uqwjsfCKKr1L3D/vq2GR08xMqVTqgyzu9r/5P+53C vupq0JOdOQxOnPuymWd+pQDs4RIO0goaw9rEXhZ20OCrZgEgGDqVjfEKfk4JN9yY/1pl CeeA== X-Gm-Message-State: AA6/9RlAM8iN2jSI3QLkT8Jnk4poItXWCt8PFrv4agmhR6UmReIB+rmB0orucXzU/HLJ+w== X-Received: by 10.28.193.67 with SMTP id r64mr4665705wmf.41.1475593537739; Tue, 04 Oct 2016 08:05:37 -0700 (PDT) Received: from cerise.devialet.com ([88.191.165.76]) by smtp.gmail.com with ESMTPSA id u72sm24645775wmu.10.2016.10.04.08.05.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Oct 2016 08:05:37 -0700 (PDT) From: Maxime Hadjinlian To: buildroot@buildroot.org Date: Tue, 4 Oct 2016 17:05:30 +0200 Message-Id: <20161004150530.12197-1-maxime.hadjinlian@gmail.com> X-Mailer: git-send-email 2.9.3 Subject: [Buildroot] [PATCH] fakeroot: fix spurious message "undefined symbol" X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Since the glibc 2.24-3, and this commit: https://sourceware.org/git/?p=glibc.git;a=commit;h=80f87443eed17838fe453f1f5406ccf5d3698c25 fakeroot will print spurious message about symbols not being found. [...] dlsym(acl_get_fd): /usr/lib/libfakeroot/libfakeroot.so: undefined symbol: acl_get_fd dlsym(acl_get_file): /usr/lib/libfakeroot/libfakeroot.so: undefined symbol: acl_get_file dlsym(acl_set_fd): /usr/lib/libfakeroot/libfakeroot.so: undefined symbol: acl_set_fd dlsym(acl_set_file): /usr/lib/libfakeroot/libfakeroot.so: undefined symbol: acl_set_file dlsym(acl_get_fd): /usr/lib/libfakeroot/libfakeroot.so: undefined symbol: acl_get_fd dlsym(acl_get_file): /usr/lib/libfakeroot/libfakeroot.so: undefined symbol: acl_get_file [...] It doesn't seem to impair the behavior of fakeroot, it's simply annoying for the user. Debian (which is the creator of fakeroot) has a patch which is a workaround: simply don't display the message. Note if you wish to bump fakeroot: A new version is available but the release tarball doesn't include the 'configure' and 'Makefile' pre-generated. This means that if we were to bump, the package would need to run its own 'bootstrap' script which will add dependencies to host-{automake,autoconf,...} which would be annoying (since almost every build runs fakeroot). Signed-off-by: Maxime Hadjinlian --- package/fakeroot/hide-dlsym-error.patch | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 package/fakeroot/hide-dlsym-error.patch diff --git a/package/fakeroot/hide-dlsym-error.patch b/package/fakeroot/hide-dlsym-error.patch new file mode 100644 index 0000000..3fd34c8 --- /dev/null +++ b/package/fakeroot/hide-dlsym-error.patch @@ -0,0 +1,32 @@ +Description: Hide error from dlsym() + dlsym(), starting in glibc 2.24 actually reports errors. In our case, + we try to get ACL functions which are not in the glibc. This causes + failures in test suites, so hide those messages for non-debugging + purposes for now. It also makes the build logs annoying to read. +Author: Julian Andres Klode +Origin: vendor +Bug-Debian: https://bugs.debian.org/830912 +Forwarded: no +Last-Update: 2016-08-12 + +--- a/libfakeroot.c ++++ b/libfakeroot.c +@@ -256,10 +256,16 @@ void load_library_symbols(void){ + /* clear dlerror() just in case dlsym() legitimately returns NULL */ + msg = dlerror(); + *(next_wrap[i].doit)=dlsym(get_libc(), next_wrap[i].name); ++ + if ( (msg = dlerror()) != NULL){ +- fprintf (stderr, "dlsym(%s): %s\n", next_wrap[i].name, msg); +-/* abort ();*/ ++#ifdef LIBFAKEROOT_DEBUGGING ++ if (fakeroot_debug) { ++ fprintf (stderr, "dlsym(%s): %s\n", next_wrap[i].name, msg); ++/* abort ();*/ ++ } ++#endif + } ++ + } + } +