From patchwork Sun Sep 18 10:11:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 671373 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3scPvQ5czhz9snm for ; Sun, 18 Sep 2016 20:12:01 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=wUdX2+nC; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id E346B8AA92; Sun, 18 Sep 2016 10:11:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xKe8dT5hKosG; Sun, 18 Sep 2016 10:11:55 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id C84D18AA2E; Sun, 18 Sep 2016 10:11:55 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 528221C16C7 for ; Sun, 18 Sep 2016 10:11:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 4F77387B8C for ; Sun, 18 Sep 2016 10:11:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JIfN6Sbl3vl1 for ; Sun, 18 Sep 2016 10:11:53 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 68A5D877B3 for ; Sun, 18 Sep 2016 10:11:53 +0000 (UTC) Received: by mail-pf0-f193.google.com with SMTP id 21so4338584pfy.1 for ; Sun, 18 Sep 2016 03:11:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=lBJHh6O2dc+lp47XDKbU5tbJ1rnDU4g64In0paUdbHs=; b=wUdX2+nC7M/1yI1qi8TMIghD7uPvM224pY6B/viIorWKETcczPlvMjsWA79YH2sOIu 25wDAHgMGNElf4e6+imqZdYEv1jTlBYyDmeDtS9qaq6yvO5R8jHs3FQJTRVW2S131p7y VTEh2B/jlXt71X+DXFXzkZIOQg9L+0aV/IxOcEr98lQs90OLQ/hjV8WG376qtRwaOxuc DvGr7on8JpC7vgxxHWoA647iSzxLC19H9H/9yQ+rLLx43v6yQ+vBr7gvmQqTOw+u6Cuk +fQrYnc3Z0JqzWhtDLJovEc0zocIflMpC1wMnVC3OlbXBdTX9MWA65xRpUNZdFvFfXKx QmKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=lBJHh6O2dc+lp47XDKbU5tbJ1rnDU4g64In0paUdbHs=; b=FsudbwUMp+me6Qm/RWsF0d2x/yf1mC7O9aWGG2WPE8IkVhc3PEclfeM5LBDZNWUqHO KZhJZ/4yDOJ1RB9dqyamPJbcVojB6Rw1BRCsJAGMErb9SBdr2jmo8Kt9/JjZvMsj7zpP forniydsvUk9tJCXvCtOFhLJeWvM+C3+fspK1i6nH/LcT1BxF6DQCLRAnHTTzvD6Cgv1 KB+3OOKr/05VNPe6u8wX8xMv4469PsL540seebzKO3pdKVWJ1JTVxLu7zNpooNdfg+H8 HIDIbNYcTj6Szw1uKkXmbMOckEmok0oQ76SUs/TQi9BXmepo0dOHcq9jOZUCn0jP8qyj rmzA== X-Gm-Message-State: AE9vXwOP/fw837LNPC+d9uEF93iojZzowFOC6Ct96oaZc2GL/rn0nenvEhxNW0vNZcU+rA== X-Received: by 10.98.34.66 with SMTP id i63mr37715050pfi.130.1474193513062; Sun, 18 Sep 2016 03:11:53 -0700 (PDT) Received: from chrisp-dl.ws.atlnz.lc (2-163-36-202-static.alliedtelesis.co.nz. [202.36.163.2]) by smtp.gmail.com with ESMTPSA id uj8sm23685374pab.5.2016.09.18.03.11.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 18 Sep 2016 03:11:51 -0700 (PDT) From: Chris Packham To: buildroot@buildroot.org Date: Sun, 18 Sep 2016 22:11:41 +1200 Message-Id: <20160918101141.20574-1-judge.packham@gmail.com> X-Mailer: git-send-email 2.9.2.518.ged577c6.dirty Subject: [Buildroot] [PATCH] util-linux: add -lcurses to LDFLAGS when static linking X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" When linking statically with -lreadline we also need to specify -lcurses. Fixes: http://autobuild.buildroot.net/results/70e0a273e699c73c6b2ab2a19c8f7ebb1ddee6cde http://autobuild.buildroot.net/results/6a7faf8adbffd9437c0117b9f0e89684c24dad23 Signed-off-by: Chris Packham Tested-by: Carlos Santos --- I think this should address the following build failures although I've only confirmed the two quoted above. http://autobuild.buildroot.net/results/0c79588166e1900c18161e1d67a38e6ee2461112 http://autobuild.buildroot.net/results/66fcd3dc6909bd00d6cb97e7b713e1e2e91c2697 http://autobuild.buildroot.net/results/d31ea8d374fa4b14b8d8d55e537801c7fc1e5992 http://autobuild.buildroot.net/results/9d4d9b74fb021fcbbc2a63ccc8cbe170ded7ae24 http://autobuild.buildroot.net/results/e4f9e0549ddfca65d746cd7ac681cd463e86f6b7 http://autobuild.buildroot.net/results/5f6b19e5fbb138b81092004ab8da057b84817025 I'm not sure that this is the "right" fix but it seems to do the trick. I also tried using LIBS instead of LDFLAGS which got the configure step to pass but didn't propagate to the final link. package/util-linux/util-linux.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk index 82230bc..d32e30d 100644 --- a/package/util-linux/util-linux.mk +++ b/package/util-linux/util-linux.mk @@ -148,6 +148,8 @@ endif ifeq ($(BR2_PACKAGE_READLINE),y) UTIL_LINUX_CONF_OPTS += --with-readline +UTIL_LINUX_CONF_ENV += $(if $(BR2_STATIC_LIBS),ac_cv_lib_readline_readline=yes) +UTIL_LINUX_CONF_ENV += $(if $(BR2_STATIC_LIBS),LDFLAGS="-lcurses") UTIL_LINUX_DEPENDENCIES += readline else UTIL_LINUX_CONF_OPTS += --without-readline