| Message ID | 1559651686-3399-1-git-send-email-pjtexier@koncepto.io |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/libubootenv: fix build with 'nothread' toolchain | expand |
On 04/06/2019 14:34, Pierre-Jean Texier wrote: > <pthread.h> include doesn't seem to be necessary inside the library. > So, drop the header completely. > > Fixes: > - http://autobuild.buildroot.org/results/813e8951530c093f46b38bf8c3b467ab6535c95b > > Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io> Applied to master, thanks. And so did upstream, even better! Regards, Arnout > --- > ...05-uboot_env-remove-pthread.h-header-file.patch | 29 ++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 package/libubootenv/0005-uboot_env-remove-pthread.h-header-file.patch > > diff --git a/package/libubootenv/0005-uboot_env-remove-pthread.h-header-file.patch b/package/libubootenv/0005-uboot_env-remove-pthread.h-header-file.patch > new file mode 100644 > index 0000000..7a7e2a0 > --- /dev/null > +++ b/package/libubootenv/0005-uboot_env-remove-pthread.h-header-file.patch > @@ -0,0 +1,29 @@ > +From ac4f795f2c0a81d5b55ce825f3d4c933fbc9e44c Mon Sep 17 00:00:00 2001 > +From: Pierre-Jean Texier <pjtexier@koncepto.io> > +Date: Tue, 4 Jun 2019 11:43:47 +0200 > +Subject: [libubootenv][PATCH] uboot_env: remove <pthread.h> header file > + > +<pthread.h> include doesn't seem to be necessary inside the library. > +So, drop the header completely. > + > +Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io> > +[Upstream status: http://patchwork.ozlabs.org/patch/1109822/] > +--- > + src/uboot_env.c | 1 - > + 1 file changed, 1 deletion(-) > + > +diff --git a/src/uboot_env.c b/src/uboot_env.c > +index e8483bf..3f1bb3b 100644 > +--- a/src/uboot_env.c > ++++ b/src/uboot_env.c > +@@ -24,7 +24,6 @@ > + #include <fcntl.h> > + #include <errno.h> > + #include <ctype.h> > +-#include <pthread.h> > + #include <signal.h> > + #include <sys/file.h> > + #include <sys/types.h> > +-- > +2.7.4 > + >
diff --git a/package/libubootenv/0005-uboot_env-remove-pthread.h-header-file.patch b/package/libubootenv/0005-uboot_env-remove-pthread.h-header-file.patch new file mode 100644 index 0000000..7a7e2a0 --- /dev/null +++ b/package/libubootenv/0005-uboot_env-remove-pthread.h-header-file.patch @@ -0,0 +1,29 @@ +From ac4f795f2c0a81d5b55ce825f3d4c933fbc9e44c Mon Sep 17 00:00:00 2001 +From: Pierre-Jean Texier <pjtexier@koncepto.io> +Date: Tue, 4 Jun 2019 11:43:47 +0200 +Subject: [libubootenv][PATCH] uboot_env: remove <pthread.h> header file + +<pthread.h> include doesn't seem to be necessary inside the library. +So, drop the header completely. + +Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io> +[Upstream status: http://patchwork.ozlabs.org/patch/1109822/] +--- + src/uboot_env.c | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/src/uboot_env.c b/src/uboot_env.c +index e8483bf..3f1bb3b 100644 +--- a/src/uboot_env.c ++++ b/src/uboot_env.c +@@ -24,7 +24,6 @@ + #include <fcntl.h> + #include <errno.h> + #include <ctype.h> +-#include <pthread.h> + #include <signal.h> + #include <sys/file.h> + #include <sys/types.h> +-- +2.7.4 +
<pthread.h> include doesn't seem to be necessary inside the library. So, drop the header completely. Fixes: - http://autobuild.buildroot.org/results/813e8951530c093f46b38bf8c3b467ab6535c95b Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io> --- ...05-uboot_env-remove-pthread.h-header-file.patch | 29 ++++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 package/libubootenv/0005-uboot_env-remove-pthread.h-header-file.patch