| Message ID | 1542596449-55950-1-git-send-email-matthew.weber@rockwellcollins.com |
|---|---|
| State | Accepted |
| Commit | 67de8b9d6d34c242f70820f7336d11144bacb7fe |
| Headers | show |
| Series | package/xproto_inputproto: disable documentation | expand |
>>>>> "Matt" == Matt Weber <matthew.weber@rockwellcollins.com> writes: > Resolves: > http://autobuild.buildroot.net/results/e6b/e6badde04047e10023b97946bbff434abc07344d/ > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com> Please clearly state when patches are for the LTS branch instead of master. Committed to 2018.02.x, thanks.
Peter, On Mon, Nov 19, 2018 at 1:51 AM Peter Korsgaard <peter@korsgaard.com> wrote: > > >>>>> "Matt" == Matt Weber <matthew.weber@rockwellcollins.com> writes: > > > Resolves: > > http://autobuild.buildroot.net/results/e6b/e6badde04047e10023b97946bbff434abc07344d/ > > > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com> > > Please clearly state when patches are for the LTS branch instead of > master. > Sorry about that, didn't notice the test results were just pointing at LTS. It should also be applied to master as there isn't a reason we'd want docs enabled. Matt
>>>>> "Matthew" == Matthew Weber <matthew.weber@rockwellcollins.com> writes: > Peter, > On Mon, Nov 19, 2018 at 1:51 AM Peter Korsgaard <peter@korsgaard.com> wrote: >> >> >>>>> "Matt" == Matt Weber <matthew.weber@rockwellcollins.com> writes: >> >> > Resolves: >> > http://autobuild.buildroot.net/results/e6b/e6badde04047e10023b97946bbff434abc07344d/ >> >> > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com> >> >> Please clearly state when patches are for the LTS branch instead of >> master. >> > Sorry about that, didn't notice the test results were just pointing at > LTS. It should also be applied to master as there isn't a reason we'd > want docs enabled. But on master (and 2018.08.x) we have replaced all of the xproto_* packages with the single xorgproto package?
Peter, On Mon, Nov 19, 2018 at 8:08 AM Peter Korsgaard <peter@korsgaard.com> wrote: > > >>>>> "Matthew" == Matthew Weber <matthew.weber@rockwellcollins.com> writes: > > > Peter, > > On Mon, Nov 19, 2018 at 1:51 AM Peter Korsgaard <peter@korsgaard.com> wrote: > >> > >> >>>>> "Matt" == Matt Weber <matthew.weber@rockwellcollins.com> writes: > >> > >> > Resolves: > >> > http://autobuild.buildroot.net/results/e6b/e6badde04047e10023b97946bbff434abc07344d/ > >> > >> > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com> > >> > >> Please clearly state when patches are for the LTS branch instead of > >> master. > >> > > > Sorry about that, didn't notice the test results were just pointing at > > LTS. It should also be applied to master as there isn't a reason we'd > > want docs enabled. > > But on master (and 2018.08.x) we have replaced all of the xproto_* > packages with the single xorgproto package? > Oops, yes. I went through that new package and it doesn't look like there is any build target (yet) for docs. So no change. Matt
>>>>> "Matt" == Matt Weber <matthew.weber@rockwellcollins.com> writes: > Resolves: > http://autobuild.buildroot.net/results/e6b/e6badde04047e10023b97946bbff434abc07344d/ This is in fact an error when building the host- variant of the package, so I have added the same ac_cv_path_ASCIIDOC for the host variant. > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com> > --- > package/x11r7/xproto_inputproto/xproto_inputproto.mk | 1 + > 1 file changed, 1 insertion(+) > diff --git a/package/x11r7/xproto_inputproto/xproto_inputproto.mk b/package/x11r7/xproto_inputproto/xproto_inputproto.mk > index 20169b5..5b3c63a 100644 > --- a/package/x11r7/xproto_inputproto/xproto_inputproto.mk > +++ b/package/x11r7/xproto_inputproto/xproto_inputproto.mk > @@ -11,6 +11,7 @@ XPROTO_INPUTPROTO_LICENSE = MIT > XPROTO_INPUTPROTO_LICENSE_FILES = COPYING > XPROTO_INPUTPROTO_INSTALL_STAGING = YES > XPROTO_INPUTPROTO_INSTALL_TARGET = NO > +XPROTO_INPUTPROTO_CONF_ENV = ac_cv_path_ASCIIDOC="" > $(eval $(autotools-package)) > $(eval $(host-autotools-package)) > -- > 1.9.1 > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hi Matt, On 19/11/2018 04:00, Matt Weber wrote: > Resolves: Please use "Fixes:", then it shows up in the "F" column in patchwork. Regards, Arnout > http://autobuild.buildroot.net/results/e6b/e6badde04047e10023b97946bbff434abc07344d/ > > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com> > --- > package/x11r7/xproto_inputproto/xproto_inputproto.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/x11r7/xproto_inputproto/xproto_inputproto.mk b/package/x11r7/xproto_inputproto/xproto_inputproto.mk > index 20169b5..5b3c63a 100644 > --- a/package/x11r7/xproto_inputproto/xproto_inputproto.mk > +++ b/package/x11r7/xproto_inputproto/xproto_inputproto.mk > @@ -11,6 +11,7 @@ XPROTO_INPUTPROTO_LICENSE = MIT > XPROTO_INPUTPROTO_LICENSE_FILES = COPYING > XPROTO_INPUTPROTO_INSTALL_STAGING = YES > XPROTO_INPUTPROTO_INSTALL_TARGET = NO > +XPROTO_INPUTPROTO_CONF_ENV = ac_cv_path_ASCIIDOC="" > > $(eval $(autotools-package)) > $(eval $(host-autotools-package)) >
diff --git a/package/x11r7/xproto_inputproto/xproto_inputproto.mk b/package/x11r7/xproto_inputproto/xproto_inputproto.mk index 20169b5..5b3c63a 100644 --- a/package/x11r7/xproto_inputproto/xproto_inputproto.mk +++ b/package/x11r7/xproto_inputproto/xproto_inputproto.mk @@ -11,6 +11,7 @@ XPROTO_INPUTPROTO_LICENSE = MIT XPROTO_INPUTPROTO_LICENSE_FILES = COPYING XPROTO_INPUTPROTO_INSTALL_STAGING = YES XPROTO_INPUTPROTO_INSTALL_TARGET = NO +XPROTO_INPUTPROTO_CONF_ENV = ac_cv_path_ASCIIDOC="" $(eval $(autotools-package)) $(eval $(host-autotools-package))
Resolves: http://autobuild.buildroot.net/results/e6b/e6badde04047e10023b97946bbff434abc07344d/ Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com> --- package/x11r7/xproto_inputproto/xproto_inputproto.mk | 1 + 1 file changed, 1 insertion(+)