From patchwork Wed Sep 5 22:00:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Angelo Compagnucci X-Patchwork-Id: 966702 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="RVRAFLLU"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 425Hh14lp7z9sCq for ; Thu, 6 Sep 2018 08:00:33 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id D83A887870; Wed, 5 Sep 2018 22:00:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xqysSN0Kb2Od; Wed, 5 Sep 2018 22:00:31 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3BEF687869; Wed, 5 Sep 2018 22:00:31 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id E40F11C2D27 for ; Wed, 5 Sep 2018 22:00:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id E15C387845 for ; Wed, 5 Sep 2018 22:00:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EknbxlswousY for ; Wed, 5 Sep 2018 22:00:29 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 0315E87746 for ; Wed, 5 Sep 2018 22:00:29 +0000 (UTC) Received: by mail-wm0-f48.google.com with SMTP id y139-v6so9378808wmc.2 for ; Wed, 05 Sep 2018 15:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DTaWeiy2jL4jCe7g/LvwWs2CIrO4uIAlyScoz5TUoak=; b=RVRAFLLUjtMOPXV8uTqQo+qLngao961Pre/CgMO1BHrrugaORWs+LMlrdsEb9cm6kO E6GH5PUtXeFi2TebRP5u8MB8snwx8J0L+PjcsIYHlTRXJ+GLIFWk695W71KA5WACxGjl ehbhkhpQEi5b2lNQkPaqeq3C+hXMXxuVNqyVDstW32TN0cBnBWYz6p1vFtimHcnFQZh8 CyeUmVh44wgUPUVWFi2L4AqLYk1deBZY1YfjZrYxE64Kp/h0u20UA53eVNIO44KYV+TT P4BH62fU0vKU/J00aCI4SNkedVniKqthpucmkSNz01Ld/gGaGh3XjdEkD9RKSsYtF+LE LWHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DTaWeiy2jL4jCe7g/LvwWs2CIrO4uIAlyScoz5TUoak=; b=Lm/w2bgmTXchCsnPTQlIPelvFmtvGtIRVRH28ozzOKr+9KzlsLMcRoHJ2tIO6Da6sN bovzh/c1aHrAOe0UyoAF1mu3B/T8JefaSWRINnk/sYs4/u+77GqfZJgpeEYdYc1swhii oj9/wuGs+bOQXeHWtkd9atoY3FXvw3sstldzZccUoNQNQD4O5Qk45NmN/hyrdIuS2leP FKsf52sAsiRPKadShQKhZ/tzz0Q+pXwnWtf5Ef9+1tTMwjRpPLsl3qs/MR/U+/bjXxpy bFmrUJAj6fpu0FOaBLwtcpdrVXCTH47+3jV6SBeRrDc212Df+yLP1VmChQRPKG6+9rYU KlKA== X-Gm-Message-State: APzg51BgOlZaQnGcBmmtCRFtso3D59FBp0BRbKK+smAxmyGkO5mJmmiK 8v9GLv2ZoouSFAw/Je2CKL1daHV3 X-Google-Smtp-Source: ANB0VdYKYhKvcJ9q6+SigkOMcWNEGjhBFVQJ0sHXR7hglymeAY8mKrDA/G+B4dR4i//gwb3Kyx9dZQ== X-Received: by 2002:a1c:4904:: with SMTP id w4-v6mr256524wma.0.1536184827300; Wed, 05 Sep 2018 15:00:27 -0700 (PDT) Received: from localhost.localdomain ([37.162.44.87]) by smtp.gmail.com with ESMTPSA id h82-v6sm3029168wme.11.2018.09.05.15.00.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 05 Sep 2018 15:00:26 -0700 (PDT) From: Angelo Compagnucci To: buildroot@buildroot.org Date: Thu, 6 Sep 2018 00:00:06 +0200 Message-Id: <1536184808-9085-2-git-send-email-angelo.compagnucci@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536184808-9085-1-git-send-email-angelo.compagnucci@gmail.com> References: <1536184808-9085-1-git-send-email-angelo.compagnucci@gmail.com> Subject: [Buildroot] [PATCH v4 1/3] Makefile: add tainting support X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Angelo Compagnucci MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Packages who harms the build reproducibility or licensing can declare FOO_TAINTS variable. If a package taints the build it will be added to a list of tainting packages. The build ends with a warning if the tainting packages list is not empty. Moreover, legal info will show a warning in presence of a tainting package. Angelo Compagnucci Signed-off-by: Angelo Compagnucci Signed-off-by: Angelo Compagnucci --- Makefile | 10 ++++++++++ package/pkg-generic.mk | 12 ++++++++++++ 2 files changed, 22 insertions(+) diff --git a/Makefile b/Makefile index 9d66bba..ad61130 100644 --- a/Makefile +++ b/Makefile @@ -758,12 +758,21 @@ endif touch $(TARGET_DIR)/usr +.PHONY: check-tainted +check-tainted: +ifneq ($(BR2_TAINTED_BY),) + $(error Your buildroot configuration is tainted by: $(BR2_TAINTED_BY)) +else + @echo "Your buildroot configuration is not tainted" +endif + .PHONY: target-post-image target-post-image: $(TARGETS_ROOTFS) target-finalize @rm -f $(ROOTFS_COMMON_TAR) @$(foreach s, $(call qstrip,$(BR2_ROOTFS_POST_IMAGE_SCRIPT)), \ $(call MESSAGE,"Executing post-image script $(s)"); \ $(EXTRA_ENV) $(s) $(BINARIES_DIR) $(call qstrip,$(BR2_ROOTFS_POST_SCRIPT_ARGS))$(sep)) + $(if $(BR2_TAINTED_BY),@echo "WARNING: Your buildroot configuration is tainted by: $(BR2_TAINTED_BY).") .PHONY: source source: $(foreach p,$(PACKAGES),$(p)-all-source) @@ -1070,6 +1079,7 @@ help: @echo ' source - download all sources needed for offline-build' @echo ' external-deps - list external packages used' @echo ' legal-info - generate info about license compliance' + @echo ' check-tainted - check if any selected package harms build reproducibility or licensing' @echo ' printvars - dump all the internal variables' @echo @echo ' make V=0|1 - 0 => quiet build (default), 1 => verbose build' diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index 91b61c6..5bb0b25 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -870,6 +870,12 @@ else $(2)_KCONFIG_VAR = BR2_PACKAGE_$(2) endif +ifdef $(2)_TAINTS +ifeq ($$($$($(2)_KCONFIG_VAR)),y) +BR2_TAINTED_BY+=$$($(2)_RAWNAME) +endif +endif + # legal-info: declare dependencies and set values used later for the manifest ifneq ($$($(2)_LICENSE_FILES),) $(2)_MANIFEST_LICENSE_FILES = $$($(2)_LICENSE_FILES) @@ -909,6 +915,12 @@ else $(Q)$$(foreach F,$$($(2)_LICENSE_FILES),$$(call legal-license-file,$$($(2)_RAWNAME),$$($(2)_BASENAME_RAW),$$($(2)_PKGDIR),$$(F),$$($(2)_DIR)/$$(F),$$(call UPPERCASE,$(4)))$$(sep)) endif # license files +ifeq ($$(call qstrip,$$($(2)_TAINTS)),YES) +ifeq ($$($$($(2)_KCONFIG_VAR)),y) + $(Q)$$(call legal-warning-pkg,$$($(2)_RAWNAME),unknown license for additional modules or dependencies) +endif +endif + ifeq ($$($(2)_SITE_METHOD),local) # Packages without a tarball: don't save and warn @$$(call legal-warning-nosource,$$($(2)_RAWNAME),local)