| Message ID | 1524060503-16067-1-git-send-email-guillaume.bressaix@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/1] pixiewps: added missing dependency | expand |
Hello Guillaume,
On Wed, 18 Apr 2018 16:08:23 +0200, Guillaume W. Bres wrote:
> + depends on BR2_TOOLCHAIN_HAS_THREADS=y
Should be just depends on BR2_TOOLCHAIN_HAS_THREADS. You can look at
all the other packages to have examples on how to do things like that.
Also, please add in the commit log something like this:
"""
Fixes:
http://autobuild.buildroot.org/results/...
"""
with an actual error to a build failure reported by the autobuilders.
The mention "22/46 toolchains have been successfully tested here." is
not useful because we don't know what "here" means, nor which
toolchains have been tested.
Thanks,
Thomas
Hello, On Wed, 18 Apr 2018 16:08:23 +0200, Guillaume W. Bres wrote: > Fix problem encountered by autobuild. 22/46 toolchains have been successfully tested here. > > Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com> > --- > package/pixiewps/Config.in | 4 ++++ > 1 file changed, 4 insertions(+) Applied to master, thanks. Thomas
diff --git a/package/pixiewps/Config.in b/package/pixiewps/Config.in index 97240f5..5354dd9 100644 --- a/package/pixiewps/Config.in +++ b/package/pixiewps/Config.in @@ -1,7 +1,11 @@ config BR2_PACKAGE_PIXIEWPS bool "pixiewps" + depends on BR2_TOOLCHAIN_HAS_THREADS=y help Pixie WPS is a C based tool to audit networks against the so called "Pixie Dust" attack. https://github.com/wiire-a/pixiewps/wiki + +comment "pixiewps needs a toolchain w/ threads" + depends on !BR2_TOOLCHAIN_HAS_THREADS
Fix problem encountered by autobuild. 22/46 toolchains have been successfully tested here. Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com> --- package/pixiewps/Config.in | 4 ++++ 1 file changed, 4 insertions(+)