| Message ID | 1520590842-3879-1-git-send-email-nerv@dawncrow.de |
|---|---|
| State | Accepted |
| Commit | 5bc71f825dae8b2605a3617b929f827946c81ded |
| Headers | show |
| Series | wine: Drop glibc requirement | expand |
>>>>> "André" == André Hentschel <nerv@dawncrow.de> writes: > I noticed it's not needed anymore, musl went upstream at some point and uClibc is now build with bessel functions: > https://git.buildroot.net/buildroot/commit/package/uclibc?id=de56d58e5d26d78161ca3b7a1a2a4decfe4e89db > Signed-off-by: André Hentschel <nerv@dawncrow.de> Committed, thanks. Have you verified that E.G. a static only uClibc configuration works? test-pkg is handy for such checks.
Am 11.03.2018 um 22:25 schrieb Peter Korsgaard: >>>>>> "André" == André Hentschel <nerv@dawncrow.de> writes: > > > I noticed it's not needed anymore, musl went upstream at some point and uClibc is now build with bessel functions: > > https://git.buildroot.net/buildroot/commit/package/uclibc?id=de56d58e5d26d78161ca3b7a1a2a4decfe4e89db > > > Signed-off-by: André Hentschel <nerv@dawncrow.de> > > Committed, thanks. > > Have you verified that E.G. a static only uClibc configuration works? > test-pkg is handy for such checks. > Hi, Thanks! In fact Wine has multiple issues with static only, I'll send a patch
diff --git a/package/wine/Config.in b/package/wine/Config.in index c674288..627a9a7 100644 --- a/package/wine/Config.in +++ b/package/wine/Config.in @@ -1,6 +1,5 @@ config BR2_PACKAGE_WINE bool "wine" - depends on BR2_TOOLCHAIN_USES_GLIBC # Wine only builds on certain architectures depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" || \ BR2_HOSTARCH = "powerpc" || BR2_HOSTARCH = "arm" || \ @@ -16,8 +15,3 @@ config BR2_PACKAGE_WINE methods. http://www.winehq.org - -comment "wine needs a glibc toolchain" - depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" - depends on BR2_i386 - depends on !BR2_TOOLCHAIN_USES_GLIBC
I noticed it's not needed anymore, musl went upstream at some point and uClibc is now build with bessel functions: https://git.buildroot.net/buildroot/commit/package/uclibc?id=de56d58e5d26d78161ca3b7a1a2a4decfe4e89db Signed-off-by: André Hentschel <nerv@dawncrow.de> --- package/wine/Config.in | 6 ------ 1 file changed, 6 deletions(-)