diff mbox series

[RFC,3/3] stacks: add a bunch of stacks

Message ID 1507668210-5427-4-git-send-email-angelo.compagnucci@gmail.com
State Changes Requested
Headers show
Series Adding software stacks | expand

Commit Message

Angelo Compagnucci Oct. 10, 2017, 8:43 p.m. UTC 
This patch adds a bunch of stacks to thinkering with.

Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
---
 stacks/lamp_stack           | 10 ++++++++++
 stacks/mesa3d-etnaviv_stack |  7 +++++++
 stacks/qt5-demos_stack      |  7 +++++++
 stacks/qt5-fb_stack         | 11 +++++++++++
 4 files changed, 35 insertions(+)
 create mode 100644 stacks/lamp_stack
 create mode 100644 stacks/mesa3d-etnaviv_stack
 create mode 100644 stacks/qt5-demos_stack
 create mode 100644 stacks/qt5-fb_stack

Comments

Arnout Vandecappelle Oct. 11, 2017, 10:09 p.m. UTC | #1 
On 10-10-17 22:43, Angelo Compagnucci wrote:
> This patch adds a bunch of stacks to thinkering with.

 tinkering

> 
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
> ---
>  stacks/lamp_stack           | 10 ++++++++++
>  stacks/mesa3d-etnaviv_stack |  7 +++++++
>  stacks/qt5-demos_stack      |  7 +++++++
>  stacks/qt5-fb_stack         | 11 +++++++++++
>  4 files changed, 35 insertions(+)
>  create mode 100644 stacks/lamp_stack
>  create mode 100644 stacks/mesa3d-etnaviv_stack
>  create mode 100644 stacks/qt5-demos_stack
>  create mode 100644 stacks/qt5-fb_stack
> 
> diff --git a/stacks/lamp_stack b/stacks/lamp_stack
> new file mode 100644
> index 0000000..bc9b0f1
> --- /dev/null
> +++ b/stacks/lamp_stack
> @@ -0,0 +1,10 @@
> +# Linux Apache Mysql Php (LAMP stack)
> +
> +BR2_TOOLCHAIN_BUILDROOT_CXX=y

 Ah, yes, these things... When you start combining defconfigs and stacks, it is
possible that there are conflicting options. So it would be nice to be able to
check that all the options we merge in are really retained. In fact, we already
do that, in test-pkg. So perhaps the best approach is to factor that into a new
script, e.g. utils/stack-config, and tell the user to run that script to combine
the stacks. Then call that script from test-pkg instead of repeating the same code.

 There's another limitation of this thing: if we want to combine it with an
external toolchain, this will no longer make sure that the external toolchain
has C++ enabled. We would basically want to include
BR2_INSTALL_LIBSTDCPP=y
in the stack config, so that the stack-config script will error out if the
external toolchain doesn't have C++. But then, I'm not sure how to keep the
BR2_TOOLCHAIN_BUILDROOT_CXX=y in the stack config because it will always be
thrown away for an external toolchain. Any ideas?


> +BR2_PACKAGE_PHP=y
> +BR2_PACKAGE_PHP_EXT_DBA=y
> +BR2_PACKAGE_PHP_EXT_PDO=y
> +BR2_PACKAGE_PHP_EXT_PDO_MYSQL=y

BR2_PACKAGE_PHP_SAPI_APACHE seems obvious... CGI is the default put probably not
really want you want if you have apache.

 And without BR2_PACKAGE_PHP_EXT_SESSION and BR2_PACKAGE_PHP_EXT_JSON you also
probably won't get very far.

> +BR2_PACKAGE_MYSQL=y
> +BR2_PACKAGE_ORACLE_MYSQL_SERVER=y
> +BR2_PACKAGE_APACHE=y
> diff --git a/stacks/mesa3d-etnaviv_stack b/stacks/mesa3d-etnaviv_stack
> new file mode 100644
> index 0000000..959967c
> --- /dev/null
> +++ b/stacks/mesa3d-etnaviv_stack
> @@ -0,0 +1,7 @@
> +# Mesa3D for boards based on Etnaviv driver

 It's better readable if you leave an empty line, like you did for the LAMP stack.

> +BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
> +BR2_TOOLCHAIN_BUILDROOT_CXX=y
> +BR2_PACKAGE_MESA3D=y
> +BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y
> +BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST=y
> +BR2_PACKAGE_MESA3D_OPENGL_ES=y
> diff --git a/stacks/qt5-demos_stack b/stacks/qt5-demos_stack
> new file mode 100644
> index 0000000..b00ef34
> --- /dev/null
> +++ b/stacks/qt5-demos_stack
> @@ -0,0 +1,7 @@
> +# QT5 demo packages
> +BR2_PACKAGE_GLMARK2=y
> +BR2_PACKAGE_MESA3D_DEMOS=y
> +BR2_PACKAGE_KMSCUBE=y
> +BR2_PACKAGE_QT5CINEX=y
> +BR2_PACKAGE_QT5CINEX_HD=y

 Ha, that's another thing. This one needs qt5-fb_stack, so it would be nice if
it could #include it somehow.

 Regards,
 Arnout

> +BR2_PACKAGE_LIBV4L=y
> diff --git a/stacks/qt5-fb_stack b/stacks/qt5-fb_stack
> new file mode 100644
> index 0000000..fcadde8
> --- /dev/null
> +++ b/stacks/qt5-fb_stack
> @@ -0,0 +1,11 @@
> +# QT5 stack based on the Linux famebuffer
> +BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
> +BR2_TOOLCHAIN_BUILDROOT_CXX=y
> +BR2_PACKAGE_QT5=y
> +BR2_PACKAGE_QT5BASE_GUI=y
> +BR2_PACKAGE_QT5BASE_OPENGL=y
> +BR2_PACKAGE_QT5BASE_OPENGL_LIB=y
> +BR2_PACKAGE_QT5BASE_LINUXFB=y
> +BR2_PACKAGE_QT5BASE_FONTCONFIG=y
> +BR2_PACKAGE_QT5BASE_GIF=y
> +BR2_PACKAGE_QT5BASE_JPEG=y
>
Angelo Compagnucci Oct. 16, 2017, 8:02 a.m. UTC | #2 
Dear Arnout Vandecappelle,

2017-10-12 0:09 GMT+02:00 Arnout Vandecappelle <arnout@mind.be>:
>
>
> On 10-10-17 22:43, Angelo Compagnucci wrote:
>> This patch adds a bunch of stacks to thinkering with.
>
>  tinkering
>
>>
>> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>> ---
>>  stacks/lamp_stack           | 10 ++++++++++
>>  stacks/mesa3d-etnaviv_stack |  7 +++++++
>>  stacks/qt5-demos_stack      |  7 +++++++
>>  stacks/qt5-fb_stack         | 11 +++++++++++
>>  4 files changed, 35 insertions(+)
>>  create mode 100644 stacks/lamp_stack
>>  create mode 100644 stacks/mesa3d-etnaviv_stack
>>  create mode 100644 stacks/qt5-demos_stack
>>  create mode 100644 stacks/qt5-fb_stack
>>
>> diff --git a/stacks/lamp_stack b/stacks/lamp_stack
>> new file mode 100644
>> index 0000000..bc9b0f1
>> --- /dev/null
>> +++ b/stacks/lamp_stack
>> @@ -0,0 +1,10 @@
>> +# Linux Apache Mysql Php (LAMP stack)
>> +
>> +BR2_TOOLCHAIN_BUILDROOT_CXX=y
>
>  Ah, yes, these things... When you start combining defconfigs and stacks, it is
> possible that there are conflicting options. So it would be nice to be able to
> check that all the options we merge in are really retained. In fact, we already
> do that, in test-pkg. So perhaps the best approach is to factor that into a new
> script, e.g. utils/stack-config, and tell the user to run that script to combine
> the stacks. Then call that script from test-pkg instead of repeating the same code.

I don't think that combining stacks that have conflicting options
should be a problem if there an easy way for the user to understand if
a symbol is present or not into the final .config and the patch I did
to merge_config.sh goes this way.
I think the main driver here should be to give the user something
prepared and reusable, but not to give a bullet proof solution.
I'm using stacks for some weeks now and I'm now acquainted to check
the output of merge_config to see if some symbol I requested is
missing in the final .config.
Probably we could enforce this but if we enforce, we should also check
that all the permutation of defconfigs and stack are working. I think
that adding a proper disclaimer is fair enough.

>  There's another limitation of this thing: if we want to combine it with an
> external toolchain, this will no longer make sure that the external toolchain
> has C++ enabled. We would basically want to include
> BR2_INSTALL_LIBSTDCPP=y
> in the stack config, so that the stack-config script will error out if the
> external toolchain doesn't have C++. But then, I'm not sure how to keep the
> BR2_TOOLCHAIN_BUILDROOT_CXX=y in the stack config because it will always be
> thrown away for an external toolchain. Any ideas?

I don't think also this should be a main problem. We can add both and
the build system remove the unused one. At least I tried with a
modified qt5-fb_stack and everything works. Of course, this behavior
should be documented.


>> +BR2_PACKAGE_PHP=y
>> +BR2_PACKAGE_PHP_EXT_DBA=y
>> +BR2_PACKAGE_PHP_EXT_PDO=y
>> +BR2_PACKAGE_PHP_EXT_PDO_MYSQL=y
>
> BR2_PACKAGE_PHP_SAPI_APACHE seems obvious... CGI is the default put probably not
> really want you want if you have apache.
>
>  And without BR2_PACKAGE_PHP_EXT_SESSION and BR2_PACKAGE_PHP_EXT_JSON you also
> probably won't get very far.

Yes right, this stack was only an example thrown there to show how a
LAMP stack could be.


>> +BR2_PACKAGE_MYSQL=y
>> +BR2_PACKAGE_ORACLE_MYSQL_SERVER=y
>> +BR2_PACKAGE_APACHE=y
>> diff --git a/stacks/mesa3d-etnaviv_stack b/stacks/mesa3d-etnaviv_stack
>> new file mode 100644
>> index 0000000..959967c
>> --- /dev/null
>> +++ b/stacks/mesa3d-etnaviv_stack
>> @@ -0,0 +1,7 @@
>> +# Mesa3D for boards based on Etnaviv driver
>
>  It's better readable if you leave an empty line, like you did for the LAMP stack.
>
>> +BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
>> +BR2_TOOLCHAIN_BUILDROOT_CXX=y
>> +BR2_PACKAGE_MESA3D=y
>> +BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y
>> +BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST=y
>> +BR2_PACKAGE_MESA3D_OPENGL_ES=y
>> diff --git a/stacks/qt5-demos_stack b/stacks/qt5-demos_stack
>> new file mode 100644
>> index 0000000..b00ef34
>> --- /dev/null
>> +++ b/stacks/qt5-demos_stack
>> @@ -0,0 +1,7 @@
>> +# QT5 demo packages
>> +BR2_PACKAGE_GLMARK2=y
>> +BR2_PACKAGE_MESA3D_DEMOS=y
>> +BR2_PACKAGE_KMSCUBE=y
>> +BR2_PACKAGE_QT5CINEX=y
>> +BR2_PACKAGE_QT5CINEX_HD=y
>
>  Ha, that's another thing. This one needs qt5-fb_stack, so it would be nice if
> it could #include it somehow.

Ah, the inclusion mechanism. I don't think we should enforce such an
inclusion mechanism. Users could mix and match as they want. Probably
for this stack is obvious you should have merged also a Qt5 stack but
for other less obvious dependencies we should probably include some
sort of instructions somewhere.
I think we can add something to the firs lines of comments to
explicate the stack requirementes, something like this:

# QT5 demo packages
#
# Needs: a stack with qt5 and opengl enabled (like qt5-fb_stack)
#

>
>  Regards,
>  Arnout
>
>> +BR2_PACKAGE_LIBV4L=y
>> diff --git a/stacks/qt5-fb_stack b/stacks/qt5-fb_stack
>> new file mode 100644
>> index 0000000..fcadde8
>> --- /dev/null
>> +++ b/stacks/qt5-fb_stack
>> @@ -0,0 +1,11 @@
>> +# QT5 stack based on the Linux famebuffer
>> +BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
>> +BR2_TOOLCHAIN_BUILDROOT_CXX=y
>> +BR2_PACKAGE_QT5=y
>> +BR2_PACKAGE_QT5BASE_GUI=y
>> +BR2_PACKAGE_QT5BASE_OPENGL=y
>> +BR2_PACKAGE_QT5BASE_OPENGL_LIB=y
>> +BR2_PACKAGE_QT5BASE_LINUXFB=y
>> +BR2_PACKAGE_QT5BASE_FONTCONFIG=y
>> +BR2_PACKAGE_QT5BASE_GIF=y
>> +BR2_PACKAGE_QT5BASE_JPEG=y
>>
>
> --
> Arnout Vandecappelle                          arnout at mind be
> Senior Embedded Software Architect            +32-16-286500
> Essensium/Mind                                http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
diff mbox series

Patch

diff --git a/stacks/lamp_stack b/stacks/lamp_stack
new file mode 100644
index 0000000..bc9b0f1
--- /dev/null
+++ b/stacks/lamp_stack
@@ -0,0 +1,10 @@ 
+# Linux Apache Mysql Php (LAMP stack)
+
+BR2_TOOLCHAIN_BUILDROOT_CXX=y
+BR2_PACKAGE_PHP=y
+BR2_PACKAGE_PHP_EXT_DBA=y
+BR2_PACKAGE_PHP_EXT_PDO=y
+BR2_PACKAGE_PHP_EXT_PDO_MYSQL=y
+BR2_PACKAGE_MYSQL=y
+BR2_PACKAGE_ORACLE_MYSQL_SERVER=y
+BR2_PACKAGE_APACHE=y
diff --git a/stacks/mesa3d-etnaviv_stack b/stacks/mesa3d-etnaviv_stack
new file mode 100644
index 0000000..959967c
--- /dev/null
+++ b/stacks/mesa3d-etnaviv_stack
@@ -0,0 +1,7 @@ 
+# Mesa3D for boards based on Etnaviv driver
+BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
+BR2_TOOLCHAIN_BUILDROOT_CXX=y
+BR2_PACKAGE_MESA3D=y
+BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y
+BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST=y
+BR2_PACKAGE_MESA3D_OPENGL_ES=y
diff --git a/stacks/qt5-demos_stack b/stacks/qt5-demos_stack
new file mode 100644
index 0000000..b00ef34
--- /dev/null
+++ b/stacks/qt5-demos_stack
@@ -0,0 +1,7 @@ 
+# QT5 demo packages
+BR2_PACKAGE_GLMARK2=y
+BR2_PACKAGE_MESA3D_DEMOS=y
+BR2_PACKAGE_KMSCUBE=y
+BR2_PACKAGE_QT5CINEX=y
+BR2_PACKAGE_QT5CINEX_HD=y
+BR2_PACKAGE_LIBV4L=y
diff --git a/stacks/qt5-fb_stack b/stacks/qt5-fb_stack
new file mode 100644
index 0000000..fcadde8
--- /dev/null
+++ b/stacks/qt5-fb_stack
@@ -0,0 +1,11 @@ 
+# QT5 stack based on the Linux famebuffer
+BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
+BR2_TOOLCHAIN_BUILDROOT_CXX=y
+BR2_PACKAGE_QT5=y
+BR2_PACKAGE_QT5BASE_GUI=y
+BR2_PACKAGE_QT5BASE_OPENGL=y
+BR2_PACKAGE_QT5BASE_OPENGL_LIB=y
+BR2_PACKAGE_QT5BASE_LINUXFB=y
+BR2_PACKAGE_QT5BASE_FONTCONFIG=y
+BR2_PACKAGE_QT5BASE_GIF=y
+BR2_PACKAGE_QT5BASE_JPEG=y