From patchwork Thu Aug 18 18:24:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rahul Bedarkar X-Patchwork-Id: 660506 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3sFZL11b5kz9sf9 for ; Fri, 19 Aug 2016 04:26:17 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 825038BFF3; Thu, 18 Aug 2016 18:26:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FbWuhha5s2iG; Thu, 18 Aug 2016 18:26:14 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 8159B8BFFA; Thu, 18 Aug 2016 18:26:14 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id E216E1C1E75 for ; Thu, 18 Aug 2016 18:26:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id DE3C98BFFA for ; Thu, 18 Aug 2016 18:26:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5kQ98Smvo+2m for ; Thu, 18 Aug 2016 18:26:13 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196]) by whitealder.osuosl.org (Postfix) with ESMTP id 584828BFF3 for ; Thu, 18 Aug 2016 18:26:13 +0000 (UTC) Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19]) by Forcepoint Email with ESMTPS id BC0F3568C73B5 for ; Thu, 18 Aug 2016 19:25:57 +0100 (IST) Received: from PUMAIL01.pu.imgtec.org (192.168.91.250) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (TLS) id 14.3.294.0; Thu, 18 Aug 2016 19:26:01 +0100 Received: from pudesk287-linux.pu.imgtec.org (192.168.91.23) by PUMAIL01.pu.imgtec.org (192.168.91.250) with Microsoft SMTP Server (TLS) id 14.3.266.1; Thu, 18 Aug 2016 23:55:59 +0530 From: Rahul Bedarkar To: Date: Thu, 18 Aug 2016 23:54:38 +0530 Message-ID: <1471544678-12514-2-git-send-email-rahul.bedarkar@imgtec.com> X-Mailer: git-send-email 2.6.2 In-Reply-To: <1471544678-12514-1-git-send-email-rahul.bedarkar@imgtec.com> References: <1471544678-12514-1-git-send-email-rahul.bedarkar@imgtec.com> MIME-Version: 1.0 X-Originating-IP: [192.168.91.23] Cc: Rahul Bedarkar Subject: [Buildroot] [PATCH 2/2] fwup: fix static linking issues X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" In case of static linking, we need to link against dependencies of dependencies. When static libs are enabled, pkg-config seems to be outputting private libs implicitly without need of --static option. Instead of manually adding libs for dependencies of libconfuse and libarchive, use pkg-config. Fixes: http://autobuild.buildroot.net/results/69d/69d410e13a49b0ed34c501ba27d32df3269adb16/ Signed-off-by: Rahul Bedarkar --- package/fwup/fwup.mk | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/package/fwup/fwup.mk b/package/fwup/fwup.mk index ae85716..db13fcc 100644 --- a/package/fwup/fwup.mk +++ b/package/fwup/fwup.mk @@ -13,5 +13,9 @@ HOST_FWUP_DEPENDENCIES = host-libconfuse host-libarchive host-libsodium FWUP_AUTORECONF = YES FWUP_CONF_ENV = ac_cv_path_HELP2MAN="" +ifeq ($(BR2_STATIC_LIBS),y) +FWUP_CONF_ENV += LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs libconfuse libarchive`" +endif + $(eval $(autotools-package)) $(eval $(host-autotools-package))