From patchwork Wed Aug 10 22:35:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Hunleth X-Patchwork-Id: 657962 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3s8mH15Zrwz9sXy for ; Thu, 11 Aug 2016 08:37:01 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=troodon-software-com.20150623.gappssmtp.com header.i=@troodon-software-com.20150623.gappssmtp.com header.b=KkBdV/qg; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 364F78B02B; Wed, 10 Aug 2016 22:37:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qjOXz4am0ruR; Wed, 10 Aug 2016 22:36:58 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 3B52E8B006; Wed, 10 Aug 2016 22:36:58 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 2419E1C0D74 for ; Wed, 10 Aug 2016 22:36:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 1F9F387FB8 for ; Wed, 10 Aug 2016 22:36:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bpGpfAs4qAWj for ; Wed, 10 Aug 2016 22:36:56 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 5FE9B87D2C for ; Wed, 10 Aug 2016 22:36:56 +0000 (UTC) Received: by mail-qt0-f195.google.com with SMTP id c52so2201739qte.1 for ; Wed, 10 Aug 2016 15:36:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=troodon-software-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CDTFcnMHfVQyAIxb2d4nTmdl8szvMUqEaYIUq18xP6Y=; b=KkBdV/qgdGcYZOxUbwTuO/lIXyiiJDx7xZxleN3a4/xUrw0gCR3eRIelqQ/uC3Wt2D 7z/z+JWeLfHrqwfsaPTtbKCMMa8JHu93cn9uUdmZbDuuOn5WSg9T7g9FoqVjO4wYum/5 gGhvQ4oOsPw9f4yHSgsPxPVIvErWqsF3IEEBGjwzG2mlawcynuj93YC7hlYsSD9jTh3K 6warkMFuuYA9qLUJE0ny9h94rLFdrna3eCYtVLJNfmyyKvfnvd/SAr5ubEmnSH85QuHw H/uIiBeqMr0dtjBA6zBhAN9PIaAkX7XHsLq5wHUh75j+8aji3EI6X7rd3i+aFoH/5Nbs G0kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CDTFcnMHfVQyAIxb2d4nTmdl8szvMUqEaYIUq18xP6Y=; b=crEt7Xrv7qcpKugo+uZLkk+CjkMBGYiiSseSg0K22WAi4ExZOKrMnlNqgERI8c/eQp 8O219sEPGl5rQsVltAP/my5rtIyWg8ROB9nrw9rsvzWGWbVfDjHyCmePl+LT5QRx4jn9 bi5O2v0OBaE4XtssEl8mNvT84HJpEy4xXijdnt7WuBWczF9G3UyaOpxu0O/9Z9Rq1gZ2 wQHwDpNZ+LXdgdyv1VxnMjMY/2JRRZnH81n4ZKm0H2UnZO4P06QWT/juxpd2nvsMf6Fe xc/u6MeS62YbsMEY5TM++9zEpjRwbl1oFgDe9xoKnS3meAXK78EUsdY5Y1Fn+499HfVo Anug== X-Gm-Message-State: AEkoouvN7GAkAwAUDuVMRmwukH60pMOO5nZmS3LLPM9zt/Q927gyqXTylx1NpJ49mQqMlA== X-Received: by 10.200.48.146 with SMTP id v18mr7409376qta.107.1470868615423; Wed, 10 Aug 2016 15:36:55 -0700 (PDT) Received: from halfmarathon.home.hunleth.com (pool-100-36-100-112.washdc.fios.verizon.net. [100.36.100.112]) by smtp.gmail.com with ESMTPSA id v11sm20285639qkb.4.2016.08.10.15.36.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 10 Aug 2016 15:36:54 -0700 (PDT) From: Frank Hunleth To: buildroot@buildroot.org Date: Wed, 10 Aug 2016 18:35:46 -0400 Message-Id: <1470868546-8237-2-git-send-email-fhunleth@troodon-software.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1470868546-8237-1-git-send-email-fhunleth@troodon-software.com> References: <1470868546-8237-1-git-send-email-fhunleth@troodon-software.com> Subject: [Buildroot] [PATCH 2/2] fwup: link in pthreads for static builds X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Both libconfuse (via libintl) and libarchive have references to pthreads but do not specify pthreads in their pkg-config descriptions. This change adds pthreads to the fwup linker options so that the link step succeeds. Fixes autobuilder failures: http://autobuild.buildroot.net/results/ce3793c79d5dc4e296d645c75f22e121f35030d3/ http://autobuild.buildroot.net/results/0c5ffec5438f766dade951a64ebfa1b734a3c0aa/ http://autobuild.buildroot.net/results/802/802b6d77e1b77b7c8fcb8f3b394cdabfd406de7a/ Signed-off-by: Frank Hunleth --- package/fwup/fwup.mk | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/package/fwup/fwup.mk b/package/fwup/fwup.mk index 3d3e3be..c5accc6 100644 --- a/package/fwup/fwup.mk +++ b/package/fwup/fwup.mk @@ -13,5 +13,13 @@ HOST_FWUP_DEPENDENCIES = host-libconfuse host-libarchive host-libsodium FWUP_AUTORECONF = YES FWUP_CONF_ENV = ac_cv_path_HELP2MAN="" +# The following is needed to fix link errors in static configurations +# due to libconfuse requiring pthreads via libintl and libarchive +# using pthread_mutex_*. Neither list pthreads in their pkg-config +# description. +ifeq ($(BR2_STATIC_LIBS)$(BR2_TOOLCHAIN_HAS_THREADS),yy) +FWUP_CONF_ENV += LDFLAGS="$(TARGET_LDFLAGS) -pthread" +endif + $(eval $(autotools-package)) $(eval $(host-autotools-package))