diff mbox

[2/2] mtd: integck needs MMU support

Message ID 1470847117-14956-2-git-send-email-rahul.bedarkar@imgtec.com
State Accepted
Headers show

Commit Message

Rahul Bedarkar Aug. 10, 2016, 4:38 p.m. UTC
After fixing build issue related to MS_DIRSYNC and MS_RELATIME, we get
following build error with blackfin external toolchain.

fstest_monitor.c: In function 'main':
fstest_monitor.c:237: warning: implicit declaration of function 'fork'
/tmp/ccCzZIuW.o: In function 'main':
/home/rahul.bedarkar/buildroot/output/build/mtd-1.5.2/tests/fs-tests/utils/fstest_monitor.c:237: undefined reference to '_fork'
collect2: ld returned 1 exit status
make[2]: *** [fstest_monitor] Error 1

Since it uses fork(), add dependency on MMU support for integck.

Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
---
 package/mtd/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni Aug. 10, 2016, 8:37 p.m. UTC | #1
Hello,

On Wed, 10 Aug 2016 22:08:37 +0530, Rahul Bedarkar wrote:
> After fixing build issue related to MS_DIRSYNC and MS_RELATIME, we get
> following build error with blackfin external toolchain.

So it is really worth the effort merging PATCH 1/2 ?

Thanks,

Thomas
Rahul Bedarkar Aug. 11, 2016, 5:36 a.m. UTC | #2
Hi Thomas,

On Thursday 11 August 2016 02:07 AM, Thomas Petazzoni wrote:
> Hello,
>
> On Wed, 10 Aug 2016 22:08:37 +0530, Rahul Bedarkar wrote:
>> After fixing build issue related to MS_DIRSYNC and MS_RELATIME, we get
>> following build error with blackfin external toolchain.
>
> So it is really worth the effort merging PATCH 1/2 ?

I'm not completely sure, but I think we should merge PATCH 1/2 because 
it fixes different issue and this patch just hides that issue for 
blackfin external toolchain.

Thanks,

Rahul
Thomas Petazzoni Aug. 11, 2016, 1:01 p.m. UTC | #3
Hello,

On Wed, 10 Aug 2016 22:08:37 +0530, Rahul Bedarkar wrote:
> After fixing build issue related to MS_DIRSYNC and MS_RELATIME, we get
> following build error with blackfin external toolchain.
> 
> fstest_monitor.c: In function 'main':
> fstest_monitor.c:237: warning: implicit declaration of function 'fork'
> /tmp/ccCzZIuW.o: In function 'main':
> /home/rahul.bedarkar/buildroot/output/build/mtd-1.5.2/tests/fs-tests/utils/fstest_monitor.c:237: undefined reference to '_fork'
> collect2: ld returned 1 exit status
> make[2]: *** [fstest_monitor] Error 1
> 
> Since it uses fork(), add dependency on MMU support for integck.
> 
> Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
> ---
>  package/mtd/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
diff mbox

Patch

diff --git a/package/mtd/Config.in b/package/mtd/Config.in
index eef8129..8be5eff 100644
--- a/package/mtd/Config.in
+++ b/package/mtd/Config.in
@@ -161,6 +161,7 @@  config BR2_PACKAGE_MTD_UBIBLOCK
 
 config BR2_PACKAGE_MTD_INTEGCK
 	bool "integck"
+	depends on BR2_USE_MMU # fork()
 	help
 	  Install the integck test program.