| Message ID | 1459906154-27721-1-git-send-email-stevecalfee@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
On 04/06/16 03:29, Steve Calfee wrote: > add python to mysql connection software, pure python > > Signed-off-by: Steve Calfee <stevecalfee@gmail.com> > > fix from review comments This doesn't belong in the commit message. It should be separated with ---, so Signed-off-by: ... --- v2: fix from review comments by Arnout > > Signed-off-by: Steve Calfee <stevecalfee@gmail.com> And the second one isn't needed of course, I guess that was added by git send-mail -s. > --- > package/Config.in | 1 + > package/python-pymysql/Config.in | 6 ++++++ > package/python-pymysql/python-pymysql.hash | 4 ++++ > package/python-pymysql/python-pymysql.mk | 14 ++++++++++++++ > 4 files changed, 25 insertions(+) > create mode 100644 package/python-pymysql/Config.in > create mode 100644 package/python-pymysql/python-pymysql.hash > create mode 100644 package/python-pymysql/python-pymysql.mk > > diff --git a/package/Config.in b/package/Config.in > index 529ad33..2543195 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -683,6 +683,7 @@ menu "External python modules" > source "package/python-pyftpdlib/Config.in" > source "package/python-pygame/Config.in" > source "package/python-pyinotify/Config.in" > + source "package/python-pymysql/Config.in" > source "package/python-pyparsing/Config.in" > source "package/python-pyparted/Config.in" > source "package/python-pypcap/Config.in" > diff --git a/package/python-pymysql/Config.in b/package/python-pymysql/Config.in > new file mode 100644 > index 0000000..7b74533 > --- /dev/null > +++ b/package/python-pymysql/Config.in > @@ -0,0 +1,6 @@ > +config BR2_PACKAGE_PYTHON_PYMYSQL > + bool "python-pymysql" > + help > + python-pymysql is a pure Python binding for mySQL. MySQL. But all of that can be fixed up while committing, so: Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> (of course, feel free to send a v3 which fixes these last bits as well). Regards, Arnout > + > + https://pypi.python.org/pypi/PyMySQL/ > diff --git a/package/python-pymysql/python-pymysql.hash b/package/python-pymysql/python-pymysql.hash > new file mode 100644 > index 0000000..fc7e5e3 > --- /dev/null > +++ b/package/python-pymysql/python-pymysql.hash > @@ -0,0 +1,4 @@ > +#md5 from https://pypi.python.org/pypi?:action=show_md5&digest=6d757cda8bfbd312714207f7c0bef5c7 > +md5 6d757cda8bfbd312714207f7c0bef5c7 PyMySQL-0.7.2.tar.gz > +# Locally calculated: > +sha256 bd7acb4990dbf097fae3417641f93e25c690e01ed25c3ed32ea638d6c3ac04ba PyMySQL-0.7.2.tar.gz > diff --git a/package/python-pymysql/python-pymysql.mk b/package/python-pymysql/python-pymysql.mk > new file mode 100644 > index 0000000..e58ff7e > --- /dev/null > +++ b/package/python-pymysql/python-pymysql.mk > @@ -0,0 +1,14 @@ > +################################################################################ > +# > +# python-pymysql > +# > +################################################################################ > + > +PYTHON_PYMYSQL_VERSION = 0.7.2 > +PYTHON_PYMYSQL_SOURCE = PyMySQL-$(PYTHON_PYMYSQL_VERSION).tar.gz > +PYTHON_PYMYSQL_SITE = https://pypi.python.org/packages/source/P/PyMySQL > +PYTHON_PYMYSQL_LICENSE = MIT > +PYTHON_PYMYSQL_LICENSE_FILES = LICENSE > +PYTHON_PYMYSQL_SETUP_TYPE = setuptools > + > +$(eval $(python-package)) >
Again, thanks for your patient review. I did do a V3, even before you reviewed this. On Wed, Apr 6, 2016 at 2:43 PM, Arnout Vandecappelle <arnout@mind.be> wrote: > On 04/06/16 03:29, Steve Calfee wrote: >> >> add python to mysql connection software, pure python >> >> Signed-off-by: Steve Calfee <stevecalfee@gmail.com> >> >> fix from review comments > > > This doesn't belong in the commit message. It should be separated with ---, > so > > Signed-off-by: ... > --- > v2: fix from review comments by Arnout > >> >> Signed-off-by: Steve Calfee <stevecalfee@gmail.com> > > > And the second one isn't needed of course, I guess that was added by git > send-mail -s. > > >> --- >> package/Config.in | 1 + >> package/python-pymysql/Config.in | 6 ++++++ >> package/python-pymysql/python-pymysql.hash | 4 ++++ >> package/python-pymysql/python-pymysql.mk | 14 ++++++++++++++ >> 4 files changed, 25 insertions(+) >> create mode 100644 package/python-pymysql/Config.in >> create mode 100644 package/python-pymysql/python-pymysql.hash >> create mode 100644 package/python-pymysql/python-pymysql.mk >> >> diff --git a/package/Config.in b/package/Config.in >> index 529ad33..2543195 100644 >> --- a/package/Config.in >> +++ b/package/Config.in >> @@ -683,6 +683,7 @@ menu "External python modules" >> source "package/python-pyftpdlib/Config.in" >> source "package/python-pygame/Config.in" >> source "package/python-pyinotify/Config.in" >> + source "package/python-pymysql/Config.in" >> source "package/python-pyparsing/Config.in" >> source "package/python-pyparted/Config.in" >> source "package/python-pypcap/Config.in" >> diff --git a/package/python-pymysql/Config.in >> b/package/python-pymysql/Config.in >> new file mode 100644 >> index 0000000..7b74533 >> --- /dev/null >> +++ b/package/python-pymysql/Config.in >> @@ -0,0 +1,6 @@ >> +config BR2_PACKAGE_PYTHON_PYMYSQL >> + bool "python-pymysql" >> + help >> + python-pymysql is a pure Python binding for mySQL. > > MySQL. > > But all of that can be fixed up while committing, so: > > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > > (of course, feel free to send a v3 which fixes these last bits as well). > > > Regards, > Arnout > > >> + >> + https://pypi.python.org/pypi/PyMySQL/ >> diff --git a/package/python-pymysql/python-pymysql.hash >> b/package/python-pymysql/python-pymysql.hash >> new file mode 100644 >> index 0000000..fc7e5e3 >> --- /dev/null >> +++ b/package/python-pymysql/python-pymysql.hash >> @@ -0,0 +1,4 @@ >> +#md5 from >> https://pypi.python.org/pypi?:action=show_md5&digest=6d757cda8bfbd312714207f7c0bef5c7 >> +md5 6d757cda8bfbd312714207f7c0bef5c7 PyMySQL-0.7.2.tar.gz >> +# Locally calculated: >> +sha256 bd7acb4990dbf097fae3417641f93e25c690e01ed25c3ed32ea638d6c3ac04ba >> PyMySQL-0.7.2.tar.gz >> diff --git a/package/python-pymysql/python-pymysql.mk >> b/package/python-pymysql/python-pymysql.mk >> new file mode 100644 >> index 0000000..e58ff7e >> --- /dev/null >> +++ b/package/python-pymysql/python-pymysql.mk >> @@ -0,0 +1,14 @@ >> >> +################################################################################ >> +# >> +# python-pymysql >> +# >> >> +################################################################################ >> + >> +PYTHON_PYMYSQL_VERSION = 0.7.2 >> +PYTHON_PYMYSQL_SOURCE = PyMySQL-$(PYTHON_PYMYSQL_VERSION).tar.gz >> +PYTHON_PYMYSQL_SITE = https://pypi.python.org/packages/source/P/PyMySQL >> +PYTHON_PYMYSQL_LICENSE = MIT >> +PYTHON_PYMYSQL_LICENSE_FILES = LICENSE >> +PYTHON_PYMYSQL_SETUP_TYPE = setuptools >> + >> +$(eval $(python-package)) >> > > > -- > Arnout Vandecappelle arnout at mind be > Senior Embedded Software Architect +32-16-286500 > Essensium/Mind http://www.mind.be > G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven > LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle > GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
diff --git a/package/Config.in b/package/Config.in index 529ad33..2543195 100644 --- a/package/Config.in +++ b/package/Config.in @@ -683,6 +683,7 @@ menu "External python modules" source "package/python-pyftpdlib/Config.in" source "package/python-pygame/Config.in" source "package/python-pyinotify/Config.in" + source "package/python-pymysql/Config.in" source "package/python-pyparsing/Config.in" source "package/python-pyparted/Config.in" source "package/python-pypcap/Config.in" diff --git a/package/python-pymysql/Config.in b/package/python-pymysql/Config.in new file mode 100644 index 0000000..7b74533 --- /dev/null +++ b/package/python-pymysql/Config.in @@ -0,0 +1,6 @@ +config BR2_PACKAGE_PYTHON_PYMYSQL + bool "python-pymysql" + help + python-pymysql is a pure Python binding for mySQL. + + https://pypi.python.org/pypi/PyMySQL/ diff --git a/package/python-pymysql/python-pymysql.hash b/package/python-pymysql/python-pymysql.hash new file mode 100644 index 0000000..fc7e5e3 --- /dev/null +++ b/package/python-pymysql/python-pymysql.hash @@ -0,0 +1,4 @@ +#md5 from https://pypi.python.org/pypi?:action=show_md5&digest=6d757cda8bfbd312714207f7c0bef5c7 +md5 6d757cda8bfbd312714207f7c0bef5c7 PyMySQL-0.7.2.tar.gz +# Locally calculated: +sha256 bd7acb4990dbf097fae3417641f93e25c690e01ed25c3ed32ea638d6c3ac04ba PyMySQL-0.7.2.tar.gz diff --git a/package/python-pymysql/python-pymysql.mk b/package/python-pymysql/python-pymysql.mk new file mode 100644 index 0000000..e58ff7e --- /dev/null +++ b/package/python-pymysql/python-pymysql.mk @@ -0,0 +1,14 @@ +################################################################################ +# +# python-pymysql +# +################################################################################ + +PYTHON_PYMYSQL_VERSION = 0.7.2 +PYTHON_PYMYSQL_SOURCE = PyMySQL-$(PYTHON_PYMYSQL_VERSION).tar.gz +PYTHON_PYMYSQL_SITE = https://pypi.python.org/packages/source/P/PyMySQL +PYTHON_PYMYSQL_LICENSE = MIT +PYTHON_PYMYSQL_LICENSE_FILES = LICENSE +PYTHON_PYMYSQL_SETUP_TYPE = setuptools + +$(eval $(python-package))