| Message ID | 1458140214-22303-12-git-send-email-gary.bisson@boundarydevices.com |
|---|---|
| State | Changes Requested |
| Headers | show |
>>>>> "Gary" == Gary Bisson <gary.bisson@boundarydevices.com> writes: > This package provides the Universal Adapter user-space utility that is > used to receive commands from the Manufacturing Tool by the Freescale > UTP Protocol. > It only works on Freescale/NXP kernels whose configuration contains > the CONFIG_FSL_UTP option. > In order to use it, the best is to make a ramdisk image whose init > points to /linuxrc. Otherwise you can simply invoke the tool once > booted: > $ uuc > Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> > --- > package/freescale-imx/Config.in | 1 + > package/freescale-imx/imx-uuc/Config.in | 11 +++++++++++ > package/freescale-imx/imx-uuc/imx-uuc.hash | 1 + > package/freescale-imx/imx-uuc/imx-uuc.mk | 20 ++++++++++++++++++++ > 4 files changed, 33 insertions(+) > create mode 100644 package/freescale-imx/imx-uuc/Config.in > create mode 100644 package/freescale-imx/imx-uuc/imx-uuc.hash > create mode 100644 package/freescale-imx/imx-uuc/imx-uuc.mk > diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in > index dfb6cc4..bc3ddd6 100644 > --- a/package/freescale-imx/Config.in > +++ b/package/freescale-imx/Config.in > @@ -44,6 +44,7 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM > source "package/freescale-imx/imx-kobs/Config.in" > source "package/freescale-imx/imx-lib/Config.in" > +source "package/freescale-imx/imx-uuc/Config.in" > source "package/freescale-imx/imx-vpu/Config.in" > source "package/freescale-imx/firmware-imx/Config.in" > if (BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX51 || BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX53) > diff --git a/package/freescale-imx/imx-uuc/Config.in b/package/freescale-imx/imx-uuc/Config.in > new file mode 100644 > index 0000000..2cd8299 > --- /dev/null > +++ b/package/freescale-imx/imx-uuc/Config.in > @@ -0,0 +1,11 @@ > +config BR2_PACKAGE_IMX_UUC > + bool "imx-uuc" > + depends on BR2_arm # Only relevant for i.MX > + help > + This package provides the Universal Adapter user-space utility > + that is used to receive commands from the Manufacturing Tool > + by the Freescale UTP Protocol. > + > + This package is provided by Freescale/NXP as-is and doesn't have > + an upstream. I think we should add some of the more detailed description from your commit text here. Looking at the upstream Makefile I see that it links with -lpthread, so you need to make the package depend on BR2_TOOLCHAIN_HAS_THREADS (and show a comment if not). I see it also creates a 1MB fat filesystem image using mkfs.vfat. It is not clear to me what that is for, but if it is needed then the package should select BR2_PACKAGE_HOST_DOSFSTOOLS. I'm not really sure installing linuxrc makes any sense. Perhaps we should just install an init script to run it at startup?
Hi Peter, On Sat, Mar 19, 2016 at 9:54 AM, Peter Korsgaard <peter@korsgaard.com> wrote: > > >>>>> "Gary" == Gary Bisson <gary.bisson@boundarydevices.com> writes: > > > This package provides the Universal Adapter user-space utility that is > > used to receive commands from the Manufacturing Tool by the Freescale > > UTP Protocol. > > > It only works on Freescale/NXP kernels whose configuration contains > > the CONFIG_FSL_UTP option. > > > In order to use it, the best is to make a ramdisk image whose init > > points to /linuxrc. Otherwise you can simply invoke the tool once > > booted: > > $ uuc > > > Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> > > --- > > package/freescale-imx/Config.in | 1 + > > package/freescale-imx/imx-uuc/Config.in | 11 +++++++++++ > > package/freescale-imx/imx-uuc/imx-uuc.hash | 1 + > > package/freescale-imx/imx-uuc/imx-uuc.mk | 20 ++++++++++++++++++++ > > 4 files changed, 33 insertions(+) > > create mode 100644 package/freescale-imx/imx-uuc/Config.in > > create mode 100644 package/freescale-imx/imx-uuc/imx-uuc.hash > > create mode 100644 package/freescale-imx/imx-uuc/imx-uuc.mk > > > diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in > > index dfb6cc4..bc3ddd6 100644 > > --- a/package/freescale-imx/Config.in > > +++ b/package/freescale-imx/Config.in > > @@ -44,6 +44,7 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM > > > source "package/freescale-imx/imx-kobs/Config.in" > > source "package/freescale-imx/imx-lib/Config.in" > > +source "package/freescale-imx/imx-uuc/Config.in" > > source "package/freescale-imx/imx-vpu/Config.in" > > source "package/freescale-imx/firmware-imx/Config.in" > > if (BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX51 || BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX53) > > diff --git a/package/freescale-imx/imx-uuc/Config.in b/package/freescale-imx/imx-uuc/Config.in > > new file mode 100644 > > index 0000000..2cd8299 > > --- /dev/null > > +++ b/package/freescale-imx/imx-uuc/Config.in > > @@ -0,0 +1,11 @@ > > +config BR2_PACKAGE_IMX_UUC > > + bool "imx-uuc" > > + depends on BR2_arm # Only relevant for i.MX > > + help > > + This package provides the Universal Adapter user-space utility > > + that is used to receive commands from the Manufacturing Tool > > + by the Freescale UTP Protocol. > > + > > + This package is provided by Freescale/NXP as-is and doesn't have > > + an upstream. > > I think we should add some of the more detailed description from your > commit text here. Ok. > Looking at the upstream Makefile I see that it links with -lpthread, so > you need to make the package depend on BR2_TOOLCHAIN_HAS_THREADS (and > show a comment if not). Yes you're right, this is an omission. > I see it also creates a 1MB fat filesystem image using mkfs.vfat. It is > not clear to me what that is for, but if it is needed then the package > should select BR2_PACKAGE_HOST_DOSFSTOOLS. It says in their commit log the reason is to avoid Windows popup format dialog when the board is enumerated. https://github.com/Freescale/meta-fsl-arm/commit/24be3bf0 > I'm not really sure installing linuxrc makes any sense. Perhaps we > should just install an init script to run it at startup? I hesitated and decided to leave as linuxrc since the file includes sys/proc/devtempfs mounting and should really be used as init process. The standard Freescale U-Boot actually specifies rdinit=/linuxrc in manufacturing mode although it has been removed by Vincent: https://git.buildroot.net/buildroot/tree/board/freescale/imx6sabre/patches/uboot/uboot-0001-mx6qsabre_common-boot-Linux-to-init-in-mfgtools-mode.patch Don't have any strong opinion here, not sure which option is the best. I'll work on the package again next week, the rest of the series is not dependent on it anyway. Regards, Gary
>>>>> "Gary" == Gary Bisson <gary.bisson@boundarydevices.com> writes: Hi, >> I see it also creates a 1MB fat filesystem image using mkfs.vfat. It is >> not clear to me what that is for, but if it is needed then the package >> should select BR2_PACKAGE_HOST_DOSFSTOOLS. > It says in their commit log the reason is to avoid Windows popup > format dialog when the board is enumerated. > https://github.com/Freescale/meta-fsl-arm/commit/24be3bf0 Ok. If that is important enough then host-dosfstools should be added to the dependencies. >> I'm not really sure installing linuxrc makes any sense. Perhaps we >> should just install an init script to run it at startup? > I hesitated and decided to leave as linuxrc since the file includes > sys/proc/devtempfs mounting and should really be used as init process. Yes, but what I meant was that it would be nicer to use the normal Buildroot init (which takes care of sys/proc/devtmpfs/..) and then just add an init script to run uuc. > I'll work on the package again next week, the rest of the series is > not dependent on it anyway. Great, thanks.
diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in index dfb6cc4..bc3ddd6 100644 --- a/package/freescale-imx/Config.in +++ b/package/freescale-imx/Config.in @@ -44,6 +44,7 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM source "package/freescale-imx/imx-kobs/Config.in" source "package/freescale-imx/imx-lib/Config.in" +source "package/freescale-imx/imx-uuc/Config.in" source "package/freescale-imx/imx-vpu/Config.in" source "package/freescale-imx/firmware-imx/Config.in" if (BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX51 || BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX53) diff --git a/package/freescale-imx/imx-uuc/Config.in b/package/freescale-imx/imx-uuc/Config.in new file mode 100644 index 0000000..2cd8299 --- /dev/null +++ b/package/freescale-imx/imx-uuc/Config.in @@ -0,0 +1,11 @@ +config BR2_PACKAGE_IMX_UUC + bool "imx-uuc" + depends on BR2_arm # Only relevant for i.MX + help + This package provides the Universal Adapter user-space utility + that is used to receive commands from the Manufacturing Tool + by the Freescale UTP Protocol. + + This package is provided by Freescale/NXP as-is and doesn't have + an upstream. + diff --git a/package/freescale-imx/imx-uuc/imx-uuc.hash b/package/freescale-imx/imx-uuc/imx-uuc.hash new file mode 100644 index 0000000..aab9ea8 --- /dev/null +++ b/package/freescale-imx/imx-uuc/imx-uuc.hash @@ -0,0 +1 @@ +sha256 95d7f7b075f58fedc07602fbc0e5bf5212d28deea3d09cdbcbd80992dcd18482 imx-uuc-0.5.1.tar.gz diff --git a/package/freescale-imx/imx-uuc/imx-uuc.mk b/package/freescale-imx/imx-uuc/imx-uuc.mk new file mode 100644 index 0000000..1bd419e --- /dev/null +++ b/package/freescale-imx/imx-uuc/imx-uuc.mk @@ -0,0 +1,20 @@ +################################################################################ +# +# imx-uuc +# +################################################################################ + +IMX_UUC_VERSION = 0.5.1 +IMX_UUC_SITE = $(FREESCALE_IMX_SITE) +IMX_UUC_LICENSE = GPLv2+ +IMX_UUC_LICENSE_FILES = COPYING + +define IMX_UUC_BUILD_CMDS + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) CC=$(TARGET_CC) +endef + +define IMX_UUC_INSTALL_TARGET_CMDS + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install +endef + +$(eval $(generic-package))
This package provides the Universal Adapter user-space utility that is used to receive commands from the Manufacturing Tool by the Freescale UTP Protocol. It only works on Freescale/NXP kernels whose configuration contains the CONFIG_FSL_UTP option. In order to use it, the best is to make a ramdisk image whose init points to /linuxrc. Otherwise you can simply invoke the tool once booted: $ uuc Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> --- package/freescale-imx/Config.in | 1 + package/freescale-imx/imx-uuc/Config.in | 11 +++++++++++ package/freescale-imx/imx-uuc/imx-uuc.hash | 1 + package/freescale-imx/imx-uuc/imx-uuc.mk | 20 ++++++++++++++++++++ 4 files changed, 33 insertions(+) create mode 100644 package/freescale-imx/imx-uuc/Config.in create mode 100644 package/freescale-imx/imx-uuc/imx-uuc.hash create mode 100644 package/freescale-imx/imx-uuc/imx-uuc.mk