Message ID | 1453594504-8725-1-git-send-email-mr.zoltan.gyarmati@gmail.com |
---|---|
State | Changes Requested |
Headers | show |
Dear Zoltan Gyarmati, Thanks for this contribution. See some comments below. On Sun, 24 Jan 2016 01:15:03 +0100, Zoltan Gyarmati wrote: > diff --git a/package/python-iniparse/Config.in b/package/python-iniparse/Config.in > new file mode 100644 > index 0000000..93d7ead > --- /dev/null > +++ b/package/python-iniparse/Config.in > @@ -0,0 +1,11 @@ > +config BR2_PACKAGE_PYTHON_INIPARSE > + bool "python-iniparse" > + depends on BR2_PACKAGE_PYTHON > + help > + iniparse is an INI parser for Python which is API compatible > + with the standard library's ConfigParser, preserves structure of INI > + files (order of sections & options, indentation, comments, and blank > + lines are preserved when data is updated), and is more convenient to > + use. Lines are too long, you should wrap at 72 characters. > diff --git a/package/python-iniparse/python-iniparse.hash b/package/python-iniparse/python-iniparse.hash > new file mode 100644 > index 0000000..0caa146 > --- /dev/null > +++ b/package/python-iniparse/python-iniparse.hash > @@ -0,0 +1,2 @@ > +#md5 from https://pypi.python.org/pypi?:action=show_md5&digest=5e573e9e9733d97623881ce9bbe5eca6 Space after # > +md5 5e573e9e9733d97623881ce9bbe5eca6 iniparse-0.4.tar.gz Please add a locally calculated sha256 hash. See package/python-netifaces/python-netifaces.hash for example. > diff --git a/package/python-iniparse/python-iniparse.mk b/package/python-iniparse/python-iniparse.mk > new file mode 100644 > index 0000000..b00e0c4 > --- /dev/null > +++ b/package/python-iniparse/python-iniparse.mk > @@ -0,0 +1,14 @@ > +################################################################################ > +# > +# python-iniparse > +# > +################################################################################ > + > +PYTHON_INIPARSE_VERSION = 0.4 > +PYTHON_INIPARSE_SOURCE = iniparse-$(PYTHON_INIPARSE_VERSION).tar.gz > +PYTHON_INIPARSE_SITE = https://pypi.python.org/packages/source/i/iniparse > +PYTHON_INIPARSE_LICENSE = Python software foundation license v2, MIT > +PYTHON_INIPARSE_LICENSE_FILES = LICENSE-PSF LICENSE > +PYTHON_INIPARSE_SETUP_TYPE = distutils > + > +$(eval $(python-package)) Otherwise, looks good. Can you fix the minor comments above and resubmit an updated version? Thanks! Thomas
diff --git a/package/Config.in b/package/Config.in index 09c2b40..a339161 100644 --- a/package/Config.in +++ b/package/Config.in @@ -645,6 +645,7 @@ menu "External python modules" source "package/python-httplib2/Config.in" source "package/python-id3/Config.in" source "package/python-idna/Config.in" + source "package/python-iniparse/Config.in" source "package/python-ipaddr/Config.in" source "package/python-ipaddress/Config.in" source "package/python-ipy/Config.in" diff --git a/package/python-iniparse/Config.in b/package/python-iniparse/Config.in new file mode 100644 index 0000000..93d7ead --- /dev/null +++ b/package/python-iniparse/Config.in @@ -0,0 +1,11 @@ +config BR2_PACKAGE_PYTHON_INIPARSE + bool "python-iniparse" + depends on BR2_PACKAGE_PYTHON + help + iniparse is an INI parser for Python which is API compatible + with the standard library's ConfigParser, preserves structure of INI + files (order of sections & options, indentation, comments, and blank + lines are preserved when data is updated), and is more convenient to + use. + + https://pypi.python.org/pypi/iniparse diff --git a/package/python-iniparse/python-iniparse.hash b/package/python-iniparse/python-iniparse.hash new file mode 100644 index 0000000..0caa146 --- /dev/null +++ b/package/python-iniparse/python-iniparse.hash @@ -0,0 +1,2 @@ +#md5 from https://pypi.python.org/pypi?:action=show_md5&digest=5e573e9e9733d97623881ce9bbe5eca6 +md5 5e573e9e9733d97623881ce9bbe5eca6 iniparse-0.4.tar.gz diff --git a/package/python-iniparse/python-iniparse.mk b/package/python-iniparse/python-iniparse.mk new file mode 100644 index 0000000..b00e0c4 --- /dev/null +++ b/package/python-iniparse/python-iniparse.mk @@ -0,0 +1,14 @@ +################################################################################ +# +# python-iniparse +# +################################################################################ + +PYTHON_INIPARSE_VERSION = 0.4 +PYTHON_INIPARSE_SOURCE = iniparse-$(PYTHON_INIPARSE_VERSION).tar.gz +PYTHON_INIPARSE_SITE = https://pypi.python.org/packages/source/i/iniparse +PYTHON_INIPARSE_LICENSE = Python software foundation license v2, MIT +PYTHON_INIPARSE_LICENSE_FILES = LICENSE-PSF LICENSE +PYTHON_INIPARSE_SETUP_TYPE = distutils + +$(eval $(python-package))
Signed-off-by: Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com> --- package/Config.in | 1 + package/python-iniparse/Config.in | 11 +++++++++++ package/python-iniparse/python-iniparse.hash | 2 ++ package/python-iniparse/python-iniparse.mk | 14 ++++++++++++++ 4 files changed, 28 insertions(+) create mode 100644 package/python-iniparse/Config.in create mode 100644 package/python-iniparse/python-iniparse.hash create mode 100644 package/python-iniparse/python-iniparse.mk