diff mbox

[v5,2/2] toolchain/toolchain-common.in: install nscd

Message ID 1448287096-18606-3-git-send-email-rdkehn@yahoo.com
State Superseded
Headers show

Commit Message

Doug Kehn Nov. 23, 2015, 1:58 p.m. UTC
Add BR2_GLIBC_NSCD for installing nscd. BR2_GLIBC_NSCD can be used by
other packages (e.g. unscd) to prevent the selection of multiple nscd
packages.

Signed-off-by: Doug Kehn <rdkehn@yahoo.com>
Cc: Yann E. MORIN <yann.morin.1998@free.fr>
--
Changes v4 -> v5
  - No changes.
Changes v3 -> v4
  - Incorporate feedback/suggestions by Yann and Maxime.
Changes v2 -> v3
  - Remove trailing '/' from UNSCD_SITE.
  - Whitespace cleanup.
Changes v1 -> v2
  - Incorporate feedback/suggestions by Yann (from nss-pam-ldapd patch).

---
 toolchain/toolchain-common.in | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Thomas Petazzoni Nov. 30, 2015, 10:08 p.m. UTC | #1
Dear Doug Kehn,

On Mon, 23 Nov 2015 07:58:16 -0600, Doug Kehn wrote:

> diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in
> index 6871d8b..a119c9c 100644
> --- a/toolchain/toolchain-common.in
> +++ b/toolchain/toolchain-common.in
> @@ -136,6 +136,10 @@ config BR2_ECLIPSE_REGISTER
>  	  configuration files to make your toolchain appear within
>  	  Eclipse, through the Eclipse Buildroot plugin.
>  
> +config BR2_GLIBC_NSCD
> +	bool "Install nscd"
> +	depends on BR2_TOOLCHAIN_USES_GLIBC

If this option were to be used by PATCH 1/2, then it should be
introduced before.

However, it is very useless to add an option that doesn't do anything
at all: if you add this option, it should actually install nscd.

If you want an example on how to do that, look at how the gconv library
installation is implemented. It works fine for both internal and
external toolchains.

Thanks!

Thomas
diff mbox

Patch

diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in
index 6871d8b..a119c9c 100644
--- a/toolchain/toolchain-common.in
+++ b/toolchain/toolchain-common.in
@@ -136,6 +136,10 @@  config BR2_ECLIPSE_REGISTER
 	  configuration files to make your toolchain appear within
 	  Eclipse, through the Eclipse Buildroot plugin.
 
+config BR2_GLIBC_NSCD
+	bool "Install nscd"
+	depends on BR2_TOOLCHAIN_USES_GLIBC
+
 # Options for packages to depend on, if they require at least a
 # specific version of the kernel headers.
 # Toolchains should choose the adequate option (ie. the highest