From patchwork Sun Nov 22 12:24:00 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergio Prado X-Patchwork-Id: 547320 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ozlabs.org (Postfix) with ESMTP id 151261402B4 for ; Sun, 22 Nov 2015 23:31:09 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=e-labworks-com.20150623.gappssmtp.com header.i=@e-labworks-com.20150623.gappssmtp.com header.b=X8neymbg; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 44CCD92599; Sun, 22 Nov 2015 12:31:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bkhA6dGiYcOL; Sun, 22 Nov 2015 12:31:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id B05378C35C; Sun, 22 Nov 2015 12:31:06 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id DBF6F1BFA5B for ; Sun, 22 Nov 2015 12:31:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id D438495B68 for ; Sun, 22 Nov 2015 12:31:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id taY6-TdlaNfi for ; Sun, 22 Nov 2015 12:31:03 +0000 (UTC) X-Greylist: delayed 00:06:46 by SQLgrey-1.7.6 Received: from mail-qk0-f176.google.com (mail-qk0-f176.google.com [209.85.220.176]) by hemlock.osuosl.org (Postfix) with ESMTPS id 5C7B595B65 for ; Sun, 22 Nov 2015 12:31:03 +0000 (UTC) Received: by qkfo3 with SMTP id o3so50143209qkf.1 for ; Sun, 22 Nov 2015 04:31:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=e-labworks-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=iHg/K+FmglytUzD8NQv0oEmEusIIbiWACiCaJR76xFs=; b=X8neymbgSEwf+28HnsPMTX42tQoxecsumtLGKfOKUgD6IoCOTYccAylvP1jnBzGWkT Y8Y+unVGzDuAsiNT2UyuhKIRwtVtopGgLde3pKmmrtug/h/62Uqp9V0TXVDv9bCe/NGL FSsavKhDGoX4UZSgrGG4Acp34OSwCixbm3wwZe0nttAn7thg00PzI2+PfoSlJ0hDt3b/ 14F4YBdv8AoNP/P3/fdOPjq9vLPqgLjao8ntlX3XFc2pnjVoCoNzlW+bNA3pi41moYTt nkpw2v9ruph9V7qOvu41Mn69SST2eIwNPydojckcQrrkPM6i/D6Vp4R5yCqGxU1C770y QMGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=iHg/K+FmglytUzD8NQv0oEmEusIIbiWACiCaJR76xFs=; b=HySF78ncEwpBNh/M8no40NNUOhx/fGz8cwwlXQMGmfDTIhuYHV0AJFOyvpoNOdUuJb xpy2omIUaL2ADa7qBUjhNllSoWa92LAw/B96/6YMAowduq7b5sIbSnz4REdrDIEVCnSW FGkCgRKqRZxmavn5Z/tjKnBBd3786zmcrluX7ZOzXikYYisShvLRKKS3vBbhxnx0Z6JE 8oHidVfkxONTcAe8HzvVbFs+gM6zmyYaEM0vHKyxNoNDa9qCbZwsQGojUv3le8LcJ4E5 UvBoP2BhhtdhnvfnbLM7ziAhc5BO/1luykVPjBc6SPpdzrcWuyE3yAKf0sR1QoFGgpQr 6gzA== X-Gm-Message-State: ALoCoQluKWWnMlDp3MWGsICuGZ+fBlod8ibmHhebCueD18jOjq/XQyHySrJLOblaG+EhrcoLYkpY X-Received: by 10.55.203.20 with SMTP id d20mr22419329qkj.57.1448195056980; Sun, 22 Nov 2015 04:24:16 -0800 (PST) Received: from localhost.localdomain ([177.141.170.120]) by smtp.gmail.com with ESMTPSA id e204sm1854613qhc.19.2015.11.22.04.24.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 22 Nov 2015 04:24:16 -0800 (PST) From: Sergio Prado To: buildroot@buildroot.org Date: Sun, 22 Nov 2015 10:24:00 -0200 Message-Id: <1448195040-8082-1-git-send-email-sergio.prado@e-labworks.com> X-Mailer: git-send-email 1.9.1 Subject: [Buildroot] [PATCH v2] gpsd: add work-around and re-enable for microblaze X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Fix (works around) bug #6872 https://bugs.busybox.net/show_bug.cgi?id=6872 The gpsd package was disabled due to an internal compiler error for the microblaze architecture in the following commit: http://git.buildroot.net/buildroot/commit/?id=d517415bcda380336f4a27bf248cef4d81791c9e The problem is due to an specific GCC optimization flag (-fexpensive-optimizations), so disabling it we can work around this problem and compile gpsd for the microblaze architecture. Signed-off-by: Sergio Prado Reviewed-by: Arnout Vandecappelle (Essensium/Mind) --- Changes v1 -> v2: - added a comment explaining why we are disabling the optimization flag. --- package/gpsd/Config.in | 3 --- package/gpsd/gpsd.mk | 8 +++++++- package/sconeserver/Config.in | 2 -- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/package/gpsd/Config.in b/package/gpsd/Config.in index fa8b8f6b2ad5..b4008ebd8353 100644 --- a/package/gpsd/Config.in +++ b/package/gpsd/Config.in @@ -1,7 +1,6 @@ comment "gpsd needs a toolchain w/ threads, dynamic library" depends on BR2_USE_MMU depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS - depends on !BR2_microblaze config BR2_PACKAGE_GPSD bool "gpsd" @@ -10,8 +9,6 @@ config BR2_PACKAGE_GPSD depends on BR2_TOOLCHAIN_HAS_THREADS # Always tries to build a shared library depends on !BR2_STATIC_LIBS - # triggers gcc ice - depends on !BR2_microblaze help gpsd is a service daemon that monitors one or more GPSes or AIS receivers attached to a host computer through serial or USB ports, diff --git a/package/gpsd/gpsd.mk b/package/gpsd/gpsd.mk index 87911c3905fe..aa35053baf09 100644 --- a/package/gpsd/gpsd.mk +++ b/package/gpsd/gpsd.mk @@ -13,6 +13,7 @@ GPSD_INSTALL_STAGING = YES GPSD_DEPENDENCIES = host-scons host-pkgconf GPSD_LDFLAGS = $(TARGET_LDFLAGS) +GPSD_CFLAGS = $(TARGET_CFLAGS) GPSD_SCONS_ENV = $(TARGET_CONFIGURE_OPTS) @@ -37,6 +38,11 @@ else GPSD_SCONS_OPTS += libgpsmm=no endif +# prevents from triggering GCC ICE +ifeq ($(BR2_microblaze),y) +GPSD_CFLAGS += -fno-expensive-optimizations +endif + # Enable or disable Qt binding ifeq ($(BR2_PACKAGE_QT_NETWORK),y) GPSD_SCONS_ENV += QMAKE="$(QT_QMAKE)" @@ -185,7 +191,7 @@ ifeq ($(BR2_PACKAGE_GPSD_MAX_DEV),y) GPSD_SCONS_OPTS += limited_max_devices=$(BR2_PACKAGE_GPSD_MAX_DEV_VALUE) endif -GPSD_SCONS_ENV += LDFLAGS="$(GPSD_LDFLAGS)" +GPSD_SCONS_ENV += LDFLAGS="$(GPSD_LDFLAGS)" CFLAGS="$(GPSD_CFLAGS)" define GPSD_BUILD_CMDS (cd $(@D); \ diff --git a/package/sconeserver/Config.in b/package/sconeserver/Config.in index f16e683bf563..4083aa7dce36 100644 --- a/package/sconeserver/Config.in +++ b/package/sconeserver/Config.in @@ -63,7 +63,6 @@ config BR2_PACKAGE_SCONESERVER_LOCATION bool "location" depends on BR2_USE_MMU # gpsd depends on BR2_TOOLCHAIN_HAS_THREADS # gpsd - depends on !BR2_microblaze # gpsd depends on !BR2_STATIC_LIBS # gpsd select BR2_PACKAGE_GPSD help @@ -72,7 +71,6 @@ config BR2_PACKAGE_SCONESERVER_LOCATION comment "location support needs a toolchain w/ theads, dynamic library" depends on BR2_USE_MMU depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBRARY - depends on !BR2_microblaze config BR2_PACKAGE_SCONESERVER_LETTUCE bool "lettuce"