From patchwork Sat Nov 21 19:28:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergio Prado X-Patchwork-Id: 547227 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 573F0140297 for ; Sun, 22 Nov 2015 06:28:55 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=e-labworks-com.20150623.gappssmtp.com header.i=@e-labworks-com.20150623.gappssmtp.com header.b=RpnFbFeo; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 9C4A5A5923; Sat, 21 Nov 2015 19:28:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yjC1EQpfnFme; Sat, 21 Nov 2015 19:28:51 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 7DA29A5922; Sat, 21 Nov 2015 19:28:51 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 81F9E1C146C for ; Sat, 21 Nov 2015 19:28:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 7B6EC2DD1B for ; Sat, 21 Nov 2015 19:28:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EJKtovArD11m for ; Sat, 21 Nov 2015 19:28:49 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-qg0-f43.google.com (mail-qg0-f43.google.com [209.85.192.43]) by silver.osuosl.org (Postfix) with ESMTPS id 3F09D25EBE for ; Sat, 21 Nov 2015 19:28:49 +0000 (UTC) Received: by qgec40 with SMTP id c40so93208511qge.2 for ; Sat, 21 Nov 2015 11:28:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=e-labworks-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=GG75yMQdHB8NnnfXrKCPvQXjjq5Xd3qaNGecbGUp4Pc=; b=RpnFbFeoVxiUlX8hrlE8qnmppN/qUZliIFXt+d+cdA1jlDwTMey6RuvgFFqjExcDy6 7rPhzVWQW7KmJDQMmHDudVzXuhP/TOkfCYzhZMTT7oPk6pTG2ELiUiRk3Yn1uKH4dpwg UIDrbp4Ds+HGAPaEt+UjxcH3v0/qWiHq7tydqofBBEYvfSdhHuaCcfgtzCoEr9b5rhaP aEpRQgY0sPuBmbyQtxoxZIktQxmhEre3y6x96ZmxemvZlUbKJ/Mv9cqTcFSE/m2BRduI lE2cNATzxh359YyBFUFMKECEmP4GdLAvmltC1kDZw50LyM6/y0ik3MPQlAwJuOpoVvmG Ah8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=GG75yMQdHB8NnnfXrKCPvQXjjq5Xd3qaNGecbGUp4Pc=; b=XcASf3LFgqQ1w5TTRfD9weQqpgzfkctQyV5HEdZTj/7ZkSI3AZFbsBSWEkbk+JhR69 wkHzWLZwANcLbGGEMn1CEPuaeZoR61/Lti2iXfJIA22/rVZl8kOVrKduhBq6URfJbjEs erp1ESdnQNbNYVL1bj8h7vtcKgwKLW+rHyuGiAnz9HpksYIb/iJ4Sr1tPl/AHi/R68VD uWjjRS+erGIxEU2kCQzLNQSJn+UReIJFC6Jc7DR2Z9WT/74n49++brLIK9U3JpFAEb14 lRKOD0ZUoXIW1mYP/GiFN0Yd7QKPeRTs7LMo4vbTzPc4QPsjxwfXVgNxq3/OTnxh0WXN BOUA== X-Gm-Message-State: ALoCoQnXthCnOXfrtRjX2xLvdzAbOw4vPZrlmkwCVoLIBYstSoo81MS1/EVYe7QdyW4wxxrMOhic X-Received: by 10.140.196.69 with SMTP id r66mr20778253qha.40.1448134128291; Sat, 21 Nov 2015 11:28:48 -0800 (PST) Received: from localhost.localdomain ([177.141.170.120]) by smtp.gmail.com with ESMTPSA id j89sm1219152qgj.35.2015.11.21.11.28.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 21 Nov 2015 11:28:47 -0800 (PST) From: Sergio Prado To: buildroot@buildroot.org Date: Sat, 21 Nov 2015 17:28:28 -0200 Message-Id: <1448134108-10089-1-git-send-email-sergio.prado@e-labworks.com> X-Mailer: git-send-email 1.9.1 Subject: [Buildroot] [PATCH 1/1] ustr: fix build issue with GCC5 X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" This patch fixes the following error messages: ustr-cmp-code-so-dbg.o: In function `ustr_pool_make_subpool': ustr-cmp-dbg-code.c:(.text+0x0): multiple definition of `ustr_pool_make_subpool' ustr-b-code-so-dbg.o:ustr-b-dbg-code.c:(.text+0x0): first defined here ustr-cmp-code-so-dbg.o: In function `ustr_pool_clear': ustr-cmp-dbg-code.c:(.text+0x44): multiple definition of `ustr_pool_clear' ustr-b-code-so-dbg.o:ustr-b-dbg-code.c:(.text+0x44): first defined here ustr-cmp-code-so-dbg.o: In function `ustr_pool_free': ... That's because the application assumes gnu89 behaviour of "inline" and "extern inline", but gcc5 defaults to gnu11. So we need to force gnu89 in the compilation flags. Fixes: http://autobuild.buildroot.org/results/fde/fde02ae2883a058b98e57ba087466d820ab1a5eb// http://autobuild.buildroot.org/results/e04/e04849c31e2a2528282ce6cdcf69aa10076d721d// http://autobuild.buildroot.org/results/7b3/7b3295e711fc51907c311adb63f0b7d06a90a7b9// ...and many others. Signed-off-by: Sergio Prado Reviewed-by: Arnout Vandecappelle (Essensium/Mind) --- package/ustr/ustr.mk | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/package/ustr/ustr.mk b/package/ustr/ustr.mk index 3144c0b47c70..817f0b0c5e9c 100644 --- a/package/ustr/ustr.mk +++ b/package/ustr/ustr.mk @@ -12,6 +12,8 @@ USTR_LICENSE_FILES = LICENSE LICENSE_BSD LICENSE_LGPL LICENSE_MIT USTR_INSTALL_STAGING = YES +USTR_CFLAGS = $(TARGET_CFLAGS) -std=gnu89 + ifeq ($(BR2_STATIC_LIBS),y) USTR_BUILD_TARGETS = all USTR_INSTALL_TARGETS = install @@ -24,7 +26,8 @@ USTR_INSTALL_TARGETS = all install-shared endif define USTR_BUILD_CMDS - $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) $(USTR_BUILD_TARGETS) + $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) CFLAGS="$(USTR_CFLAGS)" \ + $(USTR_BUILD_TARGETS) endef define USTR_INSTALL_STAGING_CMDS