From patchwork Sun Oct 25 00:59:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Beno=C3=AEt_Th=C3=A9baudeau?= X-Patchwork-Id: 535523 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id F13AC14131D for ; Sun, 25 Oct 2015 12:00:54 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=APv6fXMJ; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 0BF27311AA; Sun, 25 Oct 2015 01:00:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SDMK+Kc6CQou; Sun, 25 Oct 2015 01:00:49 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 2A6E4319A5; Sun, 25 Oct 2015 01:00:19 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 5AFDD1C0BE0 for ; Sun, 25 Oct 2015 00:59:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 2FF77316FB for ; Sun, 25 Oct 2015 00:59:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kbAP-hO-QBDz for ; Sun, 25 Oct 2015 00:59:54 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by silver.osuosl.org (Postfix) with ESMTPS id E8B9030A43 for ; Sun, 25 Oct 2015 00:59:52 +0000 (UTC) Received: by wicfv8 with SMTP id fv8so73573860wic.0 for ; Sat, 24 Oct 2015 17:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=52n/4IrprryNEX9EkGltwfx1xWGHiKWWnG/pgDU7pxY=; b=APv6fXMJ39w9UxC7qdWQjpCwAEWfTxkae3Udbzfp9NjTMl5XyBTrDYAGVbU0P0LJX7 TOINDNKEb/CeQW8RbR3nPRGZ9n2z8wusk6p7XgdQMAmrrQwgkQh/APnRox6k3/F4w+qZ ZygVw7+3jPWifrPd38lNVNFQG8N2vq4ZpP1kxiDwNSjGsNNkKlbs9VsBZvMo9FfPriiD ksKJzCmRoYo4L+BsvL8G/UPlA/2fNsW9xlYWLE6iaZyhLmwIUYWWjKiyum1beQ2Sayez 1Xe8dimgq3EZPW3e/TuS/nBMw8jOn6o66O5v2mfN7f9rCyiqn2QJQGWveYGRaS93bK9M n6XA== X-Received: by 10.180.93.197 with SMTP id cw5mr13179783wib.53.1445734791451; Sat, 24 Oct 2015 17:59:51 -0700 (PDT) Received: from localhost.localdomain (vno44-1-88-172-188-148.fbx.proxad.net. [88.172.188.148]) by smtp.gmail.com with ESMTPSA id jd9sm8406757wic.0.2015.10.24.17.59.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 24 Oct 2015 17:59:51 -0700 (PDT) From: =?UTF-8?q?Beno=C3=AEt=20Th=C3=A9baudeau?= To: Date: Sun, 25 Oct 2015 02:59:31 +0200 Message-Id: <1445734779-7212-5-git-send-email-benoit.thebaudeau.dev@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445734779-7212-1-git-send-email-benoit.thebaudeau.dev@gmail.com> References: <1445734779-7212-1-git-send-email-benoit.thebaudeau.dev@gmail.com> MIME-Version: 1.0 Cc: Thomas Petazzoni , =?UTF-8?q?Beno=C3=AEt=20Th=C3=A9baudeau?= Subject: [Buildroot] [PATCH v3 05/13] package/dhcp/S80dhcp-server: allow empty INTERFACES X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Benoît Thébaudeau The dhcpd daemon does not require network interface names to be specified on the command line. >From dhcpd(8): "The names of the network interfaces on which dhcpd should listen for broadcasts may be specified on the command line. This should be done on systems where dhcpd is unable to identify non-broadcast interfaces, but should not be required on other systems. If no interface names are specified on the command line dhcpd will identify all network interfaces which are up, eliminating non-broadcast interfaces if possible, and listen for DHCP broadcasts on each interface." dhcpd exits with "Not configured to listen on any interfaces!" only if no requested (those in INTERFACES, or all if empty) non-broadcast interfaces matching the subnet declarations in dhcpd.conf are up. Signed-off-by: Benoît Thébaudeau --- Changes v2 -> v3: none. Changes v1 -> v2: - Rebase. --- package/dhcp/S80dhcp-server | 1 - 1 file changed, 1 deletion(-) diff --git a/package/dhcp/S80dhcp-server b/package/dhcp/S80dhcp-server index c1ef53b..079727b 100755 --- a/package/dhcp/S80dhcp-server +++ b/package/dhcp/S80dhcp-server @@ -17,7 +17,6 @@ CFG_FILE="/etc/default/dhcpd" # Sanity checks test -f /usr/sbin/dhcpd || exit 0 test -f /etc/dhcp/dhcpd.conf || exit 0 -test -n "$INTERFACES" || exit 0 case "$1" in start)