From patchwork Thu Oct 8 20:03:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?C=C3=A9dric_Marie?= X-Patchwork-Id: 527875 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id C770D140DA7 for ; Fri, 9 Oct 2015 07:04:25 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=openmailbox.org header.i=@openmailbox.org header.b=c/U4l448; dkim=fail reason="signature verification failed" (1024-bit key) header.d=openmailbox.org header.i=@openmailbox.org header.b=j1qpm+xL; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 1F51A33058; Thu, 8 Oct 2015 20:04:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b+DbU0gIIOGW; Thu, 8 Oct 2015 20:04:22 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 55FBF33265; Thu, 8 Oct 2015 20:04:22 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 650791CEE74 for ; Thu, 8 Oct 2015 20:04:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 5F6DF33265 for ; Thu, 8 Oct 2015 20:04:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uRMfhcLSg1Vw for ; Thu, 8 Oct 2015 20:04:20 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from smtp6.openmailbox.org (smtp6.openmailbox.org [62.4.1.40]) by silver.osuosl.org (Postfix) with ESMTPS id D50F633058 for ; Thu, 8 Oct 2015 20:04:19 +0000 (UTC) Received: by mail2.openmailbox.org (Postfix, from userid 1004) id 433CD2AC0F21; Thu, 8 Oct 2015 22:04:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1444334655; bh=ZqEGIMzI/z+Pu+WF1IBZVGwH+jdEFdikfsmO6mW3ciU=; h=From:To:Cc:Subject:Date:From; b=c/U4l4487xFOkFv9a07Jc7EGRLYRfz80q80VRywjew8nxHZJWwPtvyANXu3timBnP aHC0auOIbUXTRNZvf7GZ9CgQPRdFQETQ41qd6y7G83pmxgo7giLaer4wuHUmsQqrnl /FwVAvzTpQWJgsUn4Yl/Moin2oHlNU7tosby7QLE= From: =?UTF-8?q?C=C3=A9dric=20Marie?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1444334649; bh=ZqEGIMzI/z+Pu+WF1IBZVGwH+jdEFdikfsmO6mW3ciU=; h=From:To:Cc:Subject:Date:From; b=j1qpm+xLHwfwAJmEeve7xEYtMZYD1bfr5GD22yOtpR8uCJ/V2EJD0EBM/OiuU9mzG cqp+P1/tEHwj4Vz9IYcxdc7kb4d9iCXZ5HjZNsO+nvaG9Byc1e5w+jCZWPcLeiqobo V7gOzwk/Lom+0WPa17GfOMQUGzrg1LW1wTxMISQs= To: buildroot@buildroot.org Date: Thu, 8 Oct 2015 22:03:37 +0200 Message-Id: <1444334617-23796-1-git-send-email-cedric.marie@openmailbox.org> X-Mailer: git-send-email 2.6.1 MIME-Version: 1.0 Cc: =?UTF-8?q?C=C3=A9dric=20Marie?= Subject: [Buildroot] [PATCH v2] Makefile: Remove 'quiet' variable X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" 'quiet' variable is set and exported, but it is not used. We can safely remove it. This variable is inherited from the Makefile of the Linux kernel, and is not used in Buildroot. In support/scripts/mkmakefile, 'quiet' value is checked, but the test is always true ('quiet' is never set to silent_), so the test can be removed as well. Signed-off-by: Cédric Marie Reviewed-by: "James Knight" Reviewed-by: Arnout Vandecappelle (Essensium/Mind) --- Changes v1 -> v2: - KBUILD_VERBOSE must not be removed, it is used for packages based on Kbuild. Title of PATCH v1 was: Makefile: Remove KBUILD_VERBOSE and quiet In order to describe how the verbosity level is managed in different infrastructures, comments will be added in Makefile (suggested by Arnout). It will be provided in a separate patch. Arnout also suggested not to export 'Q', which seems to be Buildroot internal. This will also be provided in a separate patch, if confirmed. --- Makefile | 4 +--- support/scripts/mkmakefile | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 181d446..470ea65 100644 --- a/Makefile +++ b/Makefile @@ -226,14 +226,12 @@ ifndef KBUILD_VERBOSE endif ifeq ($(KBUILD_VERBOSE),1) - quiet = Q = ifndef VERBOSE VERBOSE = 1 endif export VERBOSE else - quiet = quiet_ Q = @ endif @@ -245,7 +243,7 @@ SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \ # kconfig uses CONFIG_SHELL CONFIG_SHELL := $(SHELL) -export SHELL CONFIG_SHELL quiet Q KBUILD_VERBOSE +export SHELL CONFIG_SHELL Q KBUILD_VERBOSE ifndef HOSTAR HOSTAR := ar diff --git a/support/scripts/mkmakefile b/support/scripts/mkmakefile index 833be6a..37162a3 100755 --- a/support/scripts/mkmakefile +++ b/support/scripts/mkmakefile @@ -15,9 +15,7 @@ if test -e $2/Makefile && ! grep -q Automatically $2/Makefile then exit 0 fi -if [ "${quiet}" != "silent_" ]; then - echo " GEN $2/Makefile" -fi +echo " GEN $2/Makefile" cat << EOF > $2/Makefile # Automatically generated by $0: don't edit