From patchwork Mon Sep 21 04:27:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 520124 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id 6BA2F14027C for ; Mon, 21 Sep 2015 14:28:05 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=RV9KHtXb; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 9C2EE32A61; Mon, 21 Sep 2015 04:28:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oCQ+OkpvMWZ9; Mon, 21 Sep 2015 04:28:03 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 5270232951; Mon, 21 Sep 2015 04:28:03 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 4F11D1C11CD for ; Mon, 21 Sep 2015 04:28:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 4A7298AFA0 for ; Mon, 21 Sep 2015 04:28:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3UrkjSxpdVqw for ; Mon, 21 Sep 2015 04:28:01 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by hemlock.osuosl.org (Postfix) with ESMTPS id 6EDF98AF73 for ; Mon, 21 Sep 2015 04:28:01 +0000 (UTC) Received: by padhk3 with SMTP id hk3so104682854pad.3 for ; Sun, 20 Sep 2015 21:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sNmMq6wWePbeByzmQ9/9ouJBUPgqm+wZhHF9bXBfSO0=; b=RV9KHtXbZoHJbVlxpOwQdN9weosiaogoJn0BRwxHCWfy098Atk5+IBwwp+FDDQ7U93 tfC6PdMu+ylPx4BLakRUUvlts5FdlmYy/iKfDNA9bQ+ig7DImdLGVXED2FmexY4v6jS2 tSIb3wa2E6ytAEiICPJNnjIYOZDzKOK8Ct0PF8TwXMWeKK73VawdSjJm7X8ZbZ4sSWB0 8tF5QcZS7ACKajvJPA6Xd41yee1J/hRuPkiugqSF+y9l/dUpNTOPmvCKO4RG5QgpRwU+ GHr8Il25NEWuij/tUv7qAcMjbYxJJ2QFSkP077KeQo+6oLtQpcrTA5A3DJTGA2LfR5Hn GS1w== X-Received: by 10.68.69.35 with SMTP id b3mr6695008pbu.22.1442809680868; Sun, 20 Sep 2015 21:28:00 -0700 (PDT) Received: from chrisp-dl.ws.atlnz.lc (2-163-36-202-static.alliedtelesis.co.nz. [202.36.163.2]) by smtp.gmail.com with ESMTPSA id eu2sm11261003pbc.48.2015.09.20.21.27.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 20 Sep 2015 21:28:00 -0700 (PDT) From: Chris Packham To: buildroot@buildroot.org Date: Mon, 21 Sep 2015 16:27:46 +1200 Message-Id: <1442809666-16297-1-git-send-email-judge.packham@gmail.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <20150921033150.GJ2782@tarshish> References: <20150921033150.GJ2782@tarshish> Cc: thomas.petazzoni@free-electrons.com Subject: [Buildroot] [PATCHv2] micropython: Invert fallback detection logic X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Rather than specifying architectures that do not have explicit support in micropython invert the logic and set MICROPY_GCREGS_SETJMP=1 if the architecture does not have explicit support. MIPS is listed as being supported but this support consists of automatically defining MICROPY_GCREGS_SETJMP 1 based on __mips__ being defined. Signed-off-by: Chris Packham --- This should clean up most of the remaining build failures. Listing the architectures with explicit support makes more sense to me and is certainly a shorter list at the moment. Changes since v1: - Use positive logic ifeq(,) instead of ifneq(,y) package/micropython/micropython.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/micropython/micropython.mk b/package/micropython/micropython.mk index f2ad5bf..f8f1e80 100644 --- a/package/micropython/micropython.mk +++ b/package/micropython/micropython.mk @@ -13,7 +13,7 @@ MICROPYTHON_PATCH = https://github.com/micropython/micropython/commit/8b4fb4fe14 # Use fallback implementation for exception handling on architectures that don't # have explicit support. -ifeq ($(BR2_powerpc)$(BR2_sh)$(BR2_xtensa),y) +ifeq ($(BR2_i386)$(BR2_x86_64)$(BR2_arm)$(BR2_armeb),) MICROPYTHON_CFLAGS = -DMICROPY_GCREGS_SETJMP=1 endif