From patchwork Tue Sep 15 19:56:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Heading X-Patchwork-Id: 518099 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id A9B6914018C for ; Wed, 16 Sep 2015 05:57:08 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=o2F6iOkZ; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id E5BE588586; Tue, 15 Sep 2015 19:57:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TQ7QPIS2_Wli; Tue, 15 Sep 2015 19:57:05 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id BD6638808E; Tue, 15 Sep 2015 19:57:05 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 554921CE788 for ; Tue, 15 Sep 2015 19:57:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 5233D881BD for ; Tue, 15 Sep 2015 19:57:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5YTKEAfxjefK for ; Tue, 15 Sep 2015 19:57:03 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by hemlock.osuosl.org (Postfix) with ESMTPS id F2ABA881AA for ; Tue, 15 Sep 2015 19:57:02 +0000 (UTC) Received: by wicgb1 with SMTP id gb1so44293267wic.1 for ; Tue, 15 Sep 2015 12:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=J4129y28F8AjWAoPJXBfUfZioMn9GKFvJTdyYQnFSlE=; b=o2F6iOkZSItlqBjPKPNMRFqM/suUIesoPbwvx07oOE/O/HKra+LBm3xHQF6FWlYa+N xlvj2yiHUBoNsVri8JRN+rpbzrkq7TFf4vwi4FO3ZaRYTQIVOja1hLDYbqd0Oyi1aeOV Qt0k8chqVV5Wa3yxyIE9Yum2m6Ik8CQ1T25r4mwFk3/1xuqwjhUeiqQ+29nUzsHN8iiA 1aBeqAh+KCg8Gaf1QB37JWiw+8S76VMPsMSlEBhCISMinIh+JR9Sa+lZSsriabDg8BPS Gw0UPrCGi2ppGmajWKyfvMjnT2dS14M5a/yoru2VGRUMBGFFSK2KJs13UIPcpQjEHi33 PnoQ== X-Received: by 10.180.96.230 with SMTP id dv6mr10839158wib.23.1442347021489; Tue, 15 Sep 2015 12:57:01 -0700 (PDT) Received: from bhfedora.members.unit1.farsetlabs.org.uk (members.unit1.farsetlabs.org.uk. [89.185.154.123]) by smtp.gmail.com with ESMTPSA id gl4sm2311311wjb.29.2015.09.15.12.57.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Sep 2015 12:57:00 -0700 (PDT) From: Brendan Heading To: buildroot@buildroot.org Date: Tue, 15 Sep 2015 20:56:59 +0100 Message-Id: <1442347019-28368-1-git-send-email-brendanheading@gmail.com> X-Mailer: git-send-email 2.4.3 Cc: Brendan Heading Subject: [Buildroot] [PATCH 1/1] package/ruby: disable use of stack protector when not available X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Fixes: http://autobuild.buildroot.net/results/22e/22eced2dc9ca1bc90ef193b4dc40891c47157e89/ ruby, by default, attempts to use the stack protector if configure detects that it exists. The stack protector detection does not attempt to link libssp, which can cause a false positive. Instead, check if the stack protector is enabled in the buildroot toolchain config, and set the stack_protector=no environment variable to force the stack protector off. Signed-off-by: Brendan Heading --- package/ruby/ruby.mk | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/package/ruby/ruby.mk b/package/ruby/ruby.mk index 243cd0b..9f78c33 100644 --- a/package/ruby/ruby.mk +++ b/package/ruby/ruby.mk @@ -36,6 +36,11 @@ RUBY_CONF_ENV = ac_cv_func_dl_iterate_phdr=no RUBY_CONF_OPTS += --with-out-ext=fiddle endif +ifeq ($(BR2_TOOLCHAIN_HAS_SSP),) +# Don't force -fstack-protector when SSP is not available in toolchain +RUBY_CONF_ENV += stack_protector=no +endif + # Force optionals to build before we do ifeq ($(BR2_PACKAGE_BERKELEYDB),y) RUBY_DEPENDENCIES += berkeleydb