From patchwork Tue Sep 8 19:27:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Heading X-Patchwork-Id: 515527 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 44184140325 for ; Wed, 9 Sep 2015 05:27:39 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=C4bLyHyj; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id A12B7A4831; Tue, 8 Sep 2015 19:27:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9dE4w5e0bZ1b; Tue, 8 Sep 2015 19:27:38 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 01719A4835; Tue, 8 Sep 2015 19:27:38 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 511741C16DD for ; Tue, 8 Sep 2015 19:27:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 4D2AE90D72 for ; Tue, 8 Sep 2015 19:27:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s9llyWEzxbAq for ; Tue, 8 Sep 2015 19:27:35 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by whitealder.osuosl.org (Postfix) with ESMTPS id 6BFBD90CF0 for ; Tue, 8 Sep 2015 19:27:35 +0000 (UTC) Received: by wiclk2 with SMTP id lk2so132195635wic.0 for ; Tue, 08 Sep 2015 12:27:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=AUf9cRXN3qL8T2jUkjg/BxELJBakpx73EYPkFjq5ajs=; b=C4bLyHyj5/89Oovo9R9/+9zc0IQ++cMNO2WjkH999LrZQfyY8i19NzD+UaTGV+U3x0 9MwSWdRPQNdv5pheP6woi7eZpYCmJJBOm+DnnkIN6hOuEWu/A00neyTUbZ43Jhiyd4pw UZ3P94XlC+pgbi33cuf4gHWULxCNaJ7J8prsIEPCVf8zxQKeDr06BLAtnZricp7nzXt6 +Y/lFUa5m8aGpVqNGN/r17JFdkiSj5ndS8mfhwcZxPa6vbV+QXgpDls61HDU9eDvI0Wf EwfYvYwgbuLycH357L6Ed+vAzaLR2JQtGpjlJT3tpNzBB5gFRpl7tNR+gNoRlMfgCM5E M9Ug== X-Received: by 10.180.8.68 with SMTP id p4mr49122728wia.27.1441740454128; Tue, 08 Sep 2015 12:27:34 -0700 (PDT) Received: from bhfedora.localdomain ([82.15.84.251]) by smtp.gmail.com with ESMTPSA id bi6sm6379638wjc.25.2015.09.08.12.27.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Sep 2015 12:27:33 -0700 (PDT) From: Brendan Heading To: buildroot@buildroot.org Date: Tue, 8 Sep 2015 20:27:23 +0100 Message-Id: <1441740443-7280-1-git-send-email-brendanheading@gmail.com> X-Mailer: git-send-email 2.4.3 Cc: Brendan Heading Subject: [Buildroot] [PATCH v3 1/1] package/gdb: host-texinfo needed for full gdb X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Fixes : http://autobuild.buildroot.net/results/dd5/dd50ed99abb2c8495def826866b184030953f90e/ .. and many others. when building the full gdb (ie not just gdbserver) on the host or target the "make install" phase seems to expect makeinfo (from texinfo) to be present. Added a dependency so that the host always depends on host-texinfo, and the target depends on it if the full GDB is being built. No need to set ac_cv_prog_MAKEINFO anymore as it doesn't seem to achieve the desired effect. Signed-off-by: Brendan Heading Reviewed-by: Vicente Olivert Riera --- v1->v2: fixed for target, removed duplication in gdb.mk. Used better subject suggested by Vicente. v2->v3: fix typos, fixed subject to reflect that the issue applies to gdb in general (host and target). --- package/gdb/gdb.mk | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk index 338de20..3114fd4 100644 --- a/package/gdb/gdb.mk +++ b/package/gdb/gdb.mk @@ -33,7 +33,8 @@ ifeq ($(BR2_PACKAGE_GDB_DEBUGGER),) GDB_SUBDIR = gdb/gdbserver HOST_GDB_SUBDIR = . else -GDB_DEPENDENCIES = ncurses \ +# need makeinfo if building the full debugger +GDB_DEPENDENCIES = ncurses host-texinfo \ $(if $(BR2_PACKAGE_LIBICONV),libiconv) endif @@ -165,14 +166,8 @@ else HOST_GDB_CONF_OPTS += --without-python endif -ifeq ($(GDB_FROM_GIT),y) -GDB_DEPENDENCIES += host-texinfo +# since we always build the full GDB on the host, texinfo/makeinfo is required HOST_GDB_DEPENDENCIES += host-texinfo -else -# don't generate documentation -GDB_CONF_ENV += ac_cv_prog_MAKEINFO=missing -HOST_GDB_CONF_ENV += ac_cv_prog_MAKEINFO=missing -endif # legacy $arch-linux-gdb symlink define HOST_GDB_ADD_SYMLINK