From patchwork Tue Sep 8 18:52:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Heading X-Patchwork-Id: 515521 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ozlabs.org (Postfix) with ESMTP id CD37E1400CB for ; Wed, 9 Sep 2015 04:52:29 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=tzwhmP3N; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id DF3C7965D2; Tue, 8 Sep 2015 18:52:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HSdmrkAqeCQ6; Tue, 8 Sep 2015 18:52:28 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 5FFFD965D7; Tue, 8 Sep 2015 18:52:28 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 1B06E1C15D7 for ; Tue, 8 Sep 2015 18:52:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 18963965D9 for ; Tue, 8 Sep 2015 18:52:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QHg6J9ZMiFHN for ; Tue, 8 Sep 2015 18:52:26 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by hemlock.osuosl.org (Postfix) with ESMTPS id 118D4965D2 for ; Tue, 8 Sep 2015 18:52:26 +0000 (UTC) Received: by wiclk2 with SMTP id lk2so126073607wic.1 for ; Tue, 08 Sep 2015 11:52:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=h7AqM4h2PgwE9lByH7cRRj7Fkbf6wUhSacReQ8vQqhU=; b=tzwhmP3NaULzvbBcRNOCEQuvKAzOJm+Aq8bjiDHmZteUp2U5AvVZfMif4ViCkMPRUD TFcKcc2oy/mL2B/ONs7IUtk3j7o5Fxj6bY4EEVSyw5trcAFqFB4/W7SVRvVj1i9enZyO oOVKBuwFkOTSsvPSxWNehc3GzI/dTkeYKMZHsCIs33DSrEblAzAzKXWrgREoSZ9wNXn6 6Jzu3+xnynxtrfMo6RhqPJlHhX199mCTGB5M3DSBwkpm2KJv18xPIzu++QJFPGxQ3FDF yiivJL02iMPIWYiMwwpNP9IOJeeq+EwfnF5N35s3cb0cosnTA0oxopku0fLCPE8VW63U 1Vmw== X-Received: by 10.180.218.103 with SMTP id pf7mr47936747wic.6.1441738344669; Tue, 08 Sep 2015 11:52:24 -0700 (PDT) Received: from bhfedora.localdomain ([82.15.84.251]) by smtp.gmail.com with ESMTPSA id l17sm6254174wjr.18.2015.09.08.11.52.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Sep 2015 11:52:24 -0700 (PDT) From: Brendan Heading To: buildroot@buildroot.org Date: Tue, 8 Sep 2015 19:52:19 +0100 Message-Id: <1441738339-2011-1-git-send-email-brendanheading@gmail.com> X-Mailer: git-send-email 2.4.3 Cc: Brendan Heading Subject: [Buildroot] [PATCH 1/1] package/valgrind: disable for static-only builds X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Fixes: http://autobuild.buildroot.net/results/3b6/3b6f253f30afaee428ea0fc559be210dcec61dae http://autobuild.buildroot.net/results/60e/60e5a49360e2ee9482b4d548789f874a6502c429 http://autobuild.buildroot.net/results/5cc/5ccc2e48fa4deb90ab214c82e8921ec494555457 http://autobuild.buildroot.net/results/452/4524184b407bb6f9b55f8f85c8e0b475ff105420 Valgrind ordinarily works by preloading a shared object to replace malloc, free and friends. Some combinations of toolchain/libc allow this to build with -static, but others complain. Since it makes little sense to try to build this on a static-only system, this patch disables it on static platforms entirely. Signed-off-by: Brendan Heading --- v1 - theoretically we could try to support valgrind static builds on platforms where it appears to work (eg i686). However this would add a lot of conditional stuff, so I figured it would be easier just to disable it outright. --- package/valgrind/Config.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in index 8da007b..5635ada 100644 --- a/package/valgrind/Config.in +++ b/package/valgrind/Config.in @@ -4,11 +4,15 @@ config BR2_PACKAGE_VALGRIND BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \ BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \ BR2_x86_64 + depends on !BR2_STATIC_LIBS help Tool for debugging and profiling Linux programs. http://valgrind.org/ +comment "valgrind needs a toolchain w/ dynamic library" + depends on BR2_STATIC_LIBS + if BR2_PACKAGE_VALGRIND config BR2_PACKAGE_VALGRIND_MEMCHECK