From patchwork Tue Sep 8 15:57:29 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Heading X-Patchwork-Id: 515442 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id BA70514018C for ; Wed, 9 Sep 2015 01:57:41 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=HCeCZWKG; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id D1BBA339B6; Tue, 8 Sep 2015 15:57:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tUP2bnksIpwx; Tue, 8 Sep 2015 15:57:37 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 72806339B4; Tue, 8 Sep 2015 15:57:35 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 39B5C1CE52E for ; Tue, 8 Sep 2015 15:57:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 2E4EB339AD for ; Tue, 8 Sep 2015 15:57:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8LbqHebLtDqy for ; Tue, 8 Sep 2015 15:57:33 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by silver.osuosl.org (Postfix) with ESMTPS id BB892339BB for ; Tue, 8 Sep 2015 15:57:32 +0000 (UTC) Received: by wiclk2 with SMTP id lk2so120920764wic.1 for ; Tue, 08 Sep 2015 08:57:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=NKsJ9JW0egXa6xI/oP4yV0dWEwtsvnQ5sip/dh5QEFg=; b=HCeCZWKGJ2dIV/eK//yJXb7jdUSHWlKaXK+BzyXJVLBFQHTKrE6EHcxx6mIb+cOjTx G1T1TXQFo/VfJOpew/+DdCtKHCPA7S31Hsa8aPrXHj0Q6BBxODdpqQQbAAaY+zW2H60M h2qDdx5SQn1ZSR+SkZlLovrXvxiQNTlA+Pawyn+zfUyy7ffKJKVtgKLRn8ldFOEb9LmI OudhHYqDrDJc5rAMCHvxDDKhT8v3cRSSZZzJA7vBAN4X+/JTLX4b+5fVQQnu4396uz0E GdLc/k2iWrcQQd/Sk5CuWdy6BTpYJ7wKI77VawkLRhGf42cxVv7rPY4xuRKxZEXWv07g VKUw== X-Received: by 10.180.87.1 with SMTP id t1mr45115140wiz.33.1441727851376; Tue, 08 Sep 2015 08:57:31 -0700 (PDT) Received: from bhfedora.localdomain ([82.15.84.251]) by smtp.gmail.com with ESMTPSA id lh3sm5502816wjc.44.2015.09.08.08.57.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Sep 2015 08:57:30 -0700 (PDT) From: Brendan Heading To: buildroot@buildroot.org Date: Tue, 8 Sep 2015 16:57:29 +0100 Message-Id: <1441727849-4997-1-git-send-email-brendanheading@gmail.com> X-Mailer: git-send-email 2.4.3 Cc: Brendan Heading Subject: [Buildroot] [PATCH v2 1/1] package/host-gdb: host-texinfo needed for full gdb X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Fixes : http://autobuild.buildroot.net/results/dd5/dd50ed99abb2c8495def826866b184030953f90e/ .. and many others. when building the full gdb (ie not just gdbserver) on the host or target the "make install" phase seems to expect makeinfo (from texinfo) to be present. Added a dependency so that the host always depends on host-texinfo, and the target depends on it if the full GDB is being built. No need to set ac_cv_prog_MAKEINFO anymore as it doesn't seem to achieve the desired effect. Signed-off-by: Brendan Heading --- v1 -> v2: fixed for target, removed duplication in gdb.mk. Used better subject suggested by Vicente. --- package/gdb/gdb.mk | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk index 338de20..d144d6b 100644 --- a/package/gdb/gdb.mk +++ b/package/gdb/gdb.mk @@ -33,7 +33,8 @@ ifeq ($(BR2_PACKAGE_GDB_DEBUGGER),) GDB_SUBDIR = gdb/gdbserver HOST_GDB_SUBDIR = . else -GDB_DEPENDENCIES = ncurses \ +# need makeinfo if building the full debugger +GDB_DEPENDENCIES = ncurses host-texinfo \ $(if $(BR2_PACKAGE_LIBICONV),libiconv) endif @@ -165,14 +166,8 @@ else HOST_GDB_CONF_OPTS += --without-python endif -ifeq ($(GDB_FROM_GIT),y) -GDB_DEPENDENCIES += host-texinfo +#since we always build the full GDB on the host, texinfo/makeinfo is required HOST_GDB_DEPENDENCIES += host-texinfo -else -# don't generate documentation -GDB_CONF_ENV += ac_cv_prog_MAKEINFO=missing -HOST_GDB_CONF_ENV += ac_cv_prog_MAKEINFO=missing -endif # legacy $arch-linux-gdb symlink define HOST_GDB_ADD_SYMLINK