diff mbox

[1/1] package/empty - fix build failure

Message ID 1438703581-25996-1-git-send-email-brendanheading@gmail.com
State Rejected, archived
Headers show

Commit Message

Brendan Heading Aug. 4, 2015, 3:53 p.m. UTC
Fixes http://autobuild.buildroot.net/results/e07/e07aec9a839e89b7452b13bf5445164530e27414/

"empty" fails to build if _POSIX_SEMAPHORES is not defined, which is the
case on a toolchain with no threading support.

Signed-off-by: Brendan Heading <brendanheading@gmail.com>
---
 package/empty/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Waldemar Brodkorb Aug. 6, 2015, 6:59 p.m. UTC | #1
Hi Brendan,
Brendan Heading wrote,

> Fixes http://autobuild.buildroot.net/results/e07/e07aec9a839e89b7452b13bf5445164530e27414/
> 
> "empty" fails to build if _POSIX_SEMAPHORES is not defined, which is the
> case on a toolchain with no threading support.

Threads are not required for SysV semaphores. I have sent a patch
fixing the build with a toolchain without threads, but I got no
response on that.

http://patchwork.ozlabs.org/patch/493343/

best regards
 Waldemar
Brendan Heading Aug. 6, 2015, 7:51 p.m. UTC | #2
On 6 August 2015 at 19:59, Waldemar Brodkorb <wbx@openadk.org> wrote:

> Threads are not required for SysV semaphores. I have sent a patch
> fixing the build with a toolchain without threads, but I got no
> response on that.
>
> http://patchwork.ozlabs.org/patch/493343/

Agreed, that looks like a much better solution.

Brendan
diff mbox

Patch

diff --git a/package/empty/Config.in b/package/empty/Config.in
index 7fd0877..9a77f8d 100644
--- a/package/empty/Config.in
+++ b/package/empty/Config.in
@@ -1,7 +1,11 @@ 
 config BR2_PACKAGE_EMPTY
 	bool "empty"
 	depends on BR2_USE_MMU # uses fork()
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  Run processes and applications under pseudo-terminal (PTY) sessions.
 
 	  http://empty.sourceforge.net/
+
+comment "empty needs a toolchain w/ threads"
+	depends on BR2_TOOLCHAIN_HAS_THREADS