From patchwork Thu Jul 16 20:53:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=C3=B6rg_Krause?= X-Patchwork-Id: 496874 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ozlabs.org (Postfix) with ESMTP id 212BC140776 for ; Fri, 17 Jul 2015 06:53:26 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 71EC094B66; Thu, 16 Jul 2015 20:53:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zWYINGHEezJC; Thu, 16 Jul 2015 20:53:23 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 1B21E94B5D; Thu, 16 Jul 2015 20:53:23 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 52A431CE738 for ; Thu, 16 Jul 2015 20:53:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 4FED03213C for ; Thu, 16 Jul 2015 20:53:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aly7SA9ZrzS8 for ; Thu, 16 Jul 2015 20:53:19 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mx02.posteo.de (mx02.posteo.de [89.146.194.165]) by silver.osuosl.org (Postfix) with ESMTPS id D29E03219C for ; Thu, 16 Jul 2015 20:53:17 +0000 (UTC) Received: from dovecot04.posteo.de (unknown [185.67.36.27]) by mx02.posteo.de (Postfix) with ESMTPS id 795C622B47E3 for ; Thu, 16 Jul 2015 22:53:15 +0200 (CEST) Received: from mail.posteo.de (localhost [127.0.0.1]) by dovecot04.posteo.de (Postfix) with ESMTPSA id 3mXSTl0mj7zFpW8 for ; Thu, 16 Jul 2015 22:53:15 +0200 (CEST) Received: from nzxt.fritz.box (nzxt.localdomain [192.168.178.46]) (Authenticated sender: joerg.krause@embedded.rocks) by embedded.rocks (Postfix) with ESMTPSA id 6B4479800A9; Thu, 16 Jul 2015 22:53:14 +0200 (CEST) From: =?UTF-8?q?J=C3=B6rg=20Krause?= To: buildroot@buildroot.org Date: Thu, 16 Jul 2015 22:53:12 +0200 Message-Id: <1437079992-31679-1-git-send-email-joerg.krause@embedded.rocks> X-Mailer: git-send-email 2.4.6 MIME-Version: 1.0 Subject: [Buildroot] [PATCH 1/1] package/upmpdcli: Add patch to fix OPEN_MAX build error X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Not all systems define POSIX.1 value OPEN_MAX. In this case just close all descriptors up to some arbitrary limit - say 256 [1]. Fixes: http://autobuild.buildroot.net/results/d66/d660a9409552b3e1ad9e3ed716386fd0a67fd8db http://autobuild.buildroot.net/results/f19/f19e843cdcc968a72919ca3792a90dd40552bd59 http://autobuild.buildroot.net/results/a77/a776001dae51c4dae1f25b3a9bf9a9fe2ca69003 http://autobuild.buildroot.net/results/3e7/3e7590566ed3cc7a1dd412fb66b7b987e847aa25 and many more. Pull request is opened on github [2]. [1] Advanced Programming in the UNIX Environment, Richard Stevens, p. 52. [2] https://github.com/medoc92/upmpdcli/pull/13 Signed-off-by: Jörg Krause --- .../0001-Fix-undefined-OPEN_MAX-error.patch | 37 ++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 package/upmpdcli/0001-Fix-undefined-OPEN_MAX-error.patch diff --git a/package/upmpdcli/0001-Fix-undefined-OPEN_MAX-error.patch b/package/upmpdcli/0001-Fix-undefined-OPEN_MAX-error.patch new file mode 100644 index 0000000..d74eb99 --- /dev/null +++ b/package/upmpdcli/0001-Fix-undefined-OPEN_MAX-error.patch @@ -0,0 +1,37 @@ +From eb2fb0b2ce8987c5288c571cfb0586710c4486bb Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?J=C3=B6rg=20Krause?= +Date: Thu, 16 Jul 2015 22:24:13 +0200 +Subject: [PATCH 1/1] Fix undefined OPEN_MAX error +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +Not all systems define POSIX.1 value OPEN_MAX. In this case just close +all descriptors up to some arbitrary limit - say 256 [1]. + +[1] +Advanced Programming in the UNIX Environment, Richard Stevens, p. 52. + +Signed-off-by: Jörg Krause +--- + src/closefrom.cpp | 4 ++++ + 1 file changed, 4 insertions(+) + +diff --git a/src/closefrom.cpp b/src/closefrom.cpp +index a713875..4429b20 100644 +--- a/src/closefrom.cpp ++++ b/src/closefrom.cpp +@@ -154,6 +154,10 @@ int libclf_closefrom(int fd0) + + static int closefrom_maxfd = -1; + ++#ifndef OPEN_MAX ++#define OPEN_MAX 256 /* Guess */ ++#endif ++ + void libclf_setmaxfd(int max) + { + closefrom_maxfd = max; +-- +2.4.6 +