From patchwork Wed Apr 22 20:11:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?C=C3=A9dric_Marie?= X-Patchwork-Id: 463794 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id BAB1F1402DE for ; Thu, 23 Apr 2015 06:12:19 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=openmailbox.org header.i=@openmailbox.org header.b=eEYv3VDq; dkim-adsp=fail (unprotected policy); dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id E51BFA157D; Wed, 22 Apr 2015 20:12:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sUROcB73FNFX; Wed, 22 Apr 2015 20:12:17 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 1633DA157C; Wed, 22 Apr 2015 20:12:17 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id AC40A1C260A for ; Wed, 22 Apr 2015 20:12:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id A77398C126 for ; Wed, 22 Apr 2015 20:12:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v14SRTkygmNq for ; Wed, 22 Apr 2015 20:12:14 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail2.openmailbox.org (mail2.openmailbox.org [62.4.1.33]) by whitealder.osuosl.org (Postfix) with ESMTPS id 322EC8C120 for ; Wed, 22 Apr 2015 20:12:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail2.openmailbox.org (Postfix) with ESMTP id 2FE83203A77 for ; Wed, 22 Apr 2015 22:12:11 +0200 (CEST) Authentication-Results: mail.openmailbox.org (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=openmailbox.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=openmailbox.org; h=content-transfer-encoding:content-type:content-type :mime-version:x-mailer:message-id:date:date:subject:subject:from :from:received; s=openmailbox; t=1429733529; bh=4RtEALLFWOUYUM2W XVTI7gV6I7WiTSCxAeK5xN940qc=; b=eEYv3VDqX1ZnU1eM3LFn8cBHH0MViX8x sE3mNhKZuSZk3Rrj008tgMm8EiJOuv33XdjCiMIwXqyVUClpr6a4Qw24ymxKnvYM iaZ6/48EPFrf8GtKSjlJPDvtaAUy27+1wmrcyFhnguMGIYQcrmdp14jb37YYVnCB m7dYChL41LM= X-Virus-Scanned: amavisd-new at openmailbox.org Received: from mail2.openmailbox.org ([62.4.1.33]) by localhost (mail.openmailbox.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id n2yl2Vv2FxXd; Wed, 22 Apr 2015 22:12:09 +0200 (CEST) From: =?UTF-8?q?C=C3=A9dric=20Marie?= To: buildroot@busybox.net Date: Wed, 22 Apr 2015 22:11:56 +0200 Message-Id: <1429733516-4466-1-git-send-email-cedric.marie@openmailbox.org> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Cc: =?UTF-8?q?C=C3=A9dric=20Marie?= Subject: [Buildroot] [PATCH] pkg-cmake: Skip compilation in installation step X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" With CMake build system, the "make install" command always compiles before installing, to make sure that everything is up-to-date. In Buildroot environment, this is quite useless, because the package has always already been compiled, either at first build, or when invoking "make -rebuild". In all cases, when it comes to staging or target installation step, the package has just been compiled. Using "make install/fast" - in order to skip the compilation step - is therefore more appropriate, more consistent with what other build systems do, and saves time when you need to rebuild your package. Signed-off-by: Cédric Marie Acked-by: Arnout Vandecappelle (Essensium/Mind) Tested-by: Arnout Vandecappelle (Essensium/Mind) --- package/pkg-cmake.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk index 2262012..f17a883 100644 --- a/package/pkg-cmake.mk +++ b/package/pkg-cmake.mk @@ -57,8 +57,8 @@ $(2)_MAKE ?= $$(MAKE) $(2)_MAKE_ENV ?= $(2)_MAKE_OPTS ?= $(2)_INSTALL_OPTS ?= install -$(2)_INSTALL_STAGING_OPTS ?= DESTDIR=$$(STAGING_DIR) install -$(2)_INSTALL_TARGET_OPTS ?= DESTDIR=$$(TARGET_DIR) install +$(2)_INSTALL_STAGING_OPTS ?= DESTDIR=$$(STAGING_DIR) install/fast +$(2)_INSTALL_TARGET_OPTS ?= DESTDIR=$$(TARGET_DIR) install/fast $(2)_SRCDIR = $$($(2)_DIR)/$$($(2)_SUBDIR)