| Message ID | 1428933447-32061-2-git-send-email-angelo.compagnucci@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
Dear Angelo Compagnucci, On Mon, 13 Apr 2015 15:57:26 +0200, Angelo Compagnucci wrote: > diff --git a/package/python-pydal/Config.in b/package/python-pydal/Config.in > new file mode 100644 > index 0000000..eda2f77 > --- /dev/null > +++ b/package/python-pydal/Config.in > @@ -0,0 +1,2 @@ > +config BR2_PACKAGE_PYTHON_PYDAL > + bool I understand that the source code for this package is copied into the web2py code, so that's why it's a prompt-less package. Is it the only way of doing things? > diff --git a/package/python-pydal/python-pydal.mk b/package/python-pydal/python-pydal.mk > new file mode 100644 > index 0000000..a88bf8b > --- /dev/null > +++ b/package/python-pydal/python-pydal.mk > @@ -0,0 +1,13 @@ > +################################################################################ > +# > +# python-pydal > +# > +################################################################################ > + > +PYTHON_PYDAL_VERSION = v15.03 > +PYTHON_PYDAL_SITE = https://github.com/web2py/pydal.git > +PYTHON_PYDAL_SITE_METHOD = git github function? > +PYTHON_PYDAL_LICENSE = BSDv3 BSDv3 does not exist. You're confusing GPLv3 and BSD-3c. > +PYTHON_PYDAL_LICENSE_FILES = LICENSE > + > +$(eval $(generic-package)) A comment above this to explain why we have this generic-package that doesn't do anything. Thomas
Dear Thomas Petazzoni, 2015-04-13 16:17 GMT+02:00 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>: > Dear Angelo Compagnucci, > > On Mon, 13 Apr 2015 15:57:26 +0200, Angelo Compagnucci wrote: > >> diff --git a/package/python-pydal/Config.in b/package/python-pydal/Config.in >> new file mode 100644 >> index 0000000..eda2f77 >> --- /dev/null >> +++ b/package/python-pydal/Config.in >> @@ -0,0 +1,2 @@ >> +config BR2_PACKAGE_PYTHON_PYDAL >> + bool > > I understand that the source code for this package is copied into the > web2py code, so that's why it's a prompt-less package. Is it the only > way of doing things? No. Unfortunately buildroot doesn't support git submodules: the download helper makes a bare clone and zip the results without git informations, so it's not possible to do a submodule init in a POST_EXTRACT action. The only way is to add a dummy package for the submodule and copy the downloaded content to appropriate folders. I was inspired by other packages (ex sunxi-mali-prop) that use the same exact method. >> diff --git a/package/python-pydal/python-pydal.mk b/package/python-pydal/python-pydal.mk >> new file mode 100644 >> index 0000000..a88bf8b >> --- /dev/null >> +++ b/package/python-pydal/python-pydal.mk >> @@ -0,0 +1,13 @@ >> +################################################################################ >> +# >> +# python-pydal >> +# >> +################################################################################ >> + >> +PYTHON_PYDAL_VERSION = v15.03 >> +PYTHON_PYDAL_SITE = https://github.com/web2py/pydal.git >> +PYTHON_PYDAL_SITE_METHOD = git > > github function? Using this method I can use alternatively both commit id or tag. Usually web2py uses a tagged pydal version as a submodule, sometimes not. >> +PYTHON_PYDAL_LICENSE = BSDv3 > > BSDv3 does not exist. You're confusing GPLv3 and BSD-3c. Doh! Probably also the original author is wrong: "License pyDAL is released under the BSDv3 License. For further details, please check the LICENSE file." I will submit a PR to Giovanni Barillari! >> +PYTHON_PYDAL_LICENSE_FILES = LICENSE >> + >> +$(eval $(generic-package)) > > A comment above this to explain why we have this generic-package that > doesn't do anything. Ok! > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com
diff --git a/package/Config.in b/package/Config.in index c27fc20..839b80a 100644 --- a/package/Config.in +++ b/package/Config.in @@ -592,6 +592,7 @@ menu "external python modules" source "package/python-psutil/Config.in" source "package/python-pyasn/Config.in" source "package/python-pycrypto/Config.in" + source "package/python-pydal/Config.in" source "package/python-pyftpdlib/Config.in" source "package/python-pygame/Config.in" source "package/python-pyinotify/Config.in" diff --git a/package/python-pydal/Config.in b/package/python-pydal/Config.in new file mode 100644 index 0000000..eda2f77 --- /dev/null +++ b/package/python-pydal/Config.in @@ -0,0 +1,2 @@ +config BR2_PACKAGE_PYTHON_PYDAL + bool diff --git a/package/python-pydal/python-pydal.mk b/package/python-pydal/python-pydal.mk new file mode 100644 index 0000000..a88bf8b --- /dev/null +++ b/package/python-pydal/python-pydal.mk @@ -0,0 +1,13 @@ +################################################################################ +# +# python-pydal +# +################################################################################ + +PYTHON_PYDAL_VERSION = v15.03 +PYTHON_PYDAL_SITE = https://github.com/web2py/pydal.git +PYTHON_PYDAL_SITE_METHOD = git +PYTHON_PYDAL_LICENSE = BSDv3 +PYTHON_PYDAL_LICENSE_FILES = LICENSE + +$(eval $(generic-package))
This package adds the python-pydal dependency for web2py. This is a submodule and used by web2py only. Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> --- package/Config.in | 1 + package/python-pydal/Config.in | 2 ++ package/python-pydal/python-pydal.mk | 13 +++++++++++++ 3 files changed, 16 insertions(+) create mode 100644 package/python-pydal/Config.in create mode 100644 package/python-pydal/python-pydal.mk