diff mbox

[v2,2/3] lame: Remove --enable-debug workaround.

Message ID 1426173147-27755-2-git-send-email-johan.oudinet@gmail.com
State Accepted
Headers show

Commit Message

Johan Oudinet March 12, 2015, 3:12 p.m. UTC
This is not needed since BR2_ENABLE_DEBUG does not set this flag
anymore.

Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>
---
 package/lame/lame.mk | 7 -------
 1 file changed, 7 deletions(-)

Comments

Yann E. MORIN April 6, 2015, 3:29 p.m. UTC | #1
Johan, All,

On 2015-03-12 16:12 +0100, Johan Oudinet spake thusly:
> This is not needed since BR2_ENABLE_DEBUG does not set this flag
> anymore.
> 
> Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/lame/lame.mk | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/package/lame/lame.mk b/package/lame/lame.mk
> index e47e0af..dcd155f 100644
> --- a/package/lame/lame.mk
> +++ b/package/lame/lame.mk
> @@ -14,13 +14,6 @@ LAME_CONF_OPTS = --enable-dynamic-frontends
>  LAME_LICENSE = LGPLv2+
>  LAME_LICENSE_FILES = COPYING
>  
> -# Building lame with debug symbols needs the following macros to be
> -# defined: _FPU_MASK_IM, _FPU_MASK_ZM, _FPU_MASK_OM.
> -# So, if BR2_ENABLE_DEBUG is selected, then we have force lame to be
> -# built without debug symbols because a number of architectures don't
> -# have those macros defined.
> -LAME_CONF_OPTS += --disable-debug
> -
>  ifeq ($(BR2_PACKAGE_LIBSNDFILE),y)
>  LAME_DEPENDENCIES += libsndfile
>  LAME_CONF_OPTS += --with-fileio=sndfile
> -- 
> 2.1.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox

Patch

diff --git a/package/lame/lame.mk b/package/lame/lame.mk
index e47e0af..dcd155f 100644
--- a/package/lame/lame.mk
+++ b/package/lame/lame.mk
@@ -14,13 +14,6 @@  LAME_CONF_OPTS = --enable-dynamic-frontends
 LAME_LICENSE = LGPLv2+
 LAME_LICENSE_FILES = COPYING
 
-# Building lame with debug symbols needs the following macros to be
-# defined: _FPU_MASK_IM, _FPU_MASK_ZM, _FPU_MASK_OM.
-# So, if BR2_ENABLE_DEBUG is selected, then we have force lame to be
-# built without debug symbols because a number of architectures don't
-# have those macros defined.
-LAME_CONF_OPTS += --disable-debug
-
 ifeq ($(BR2_PACKAGE_LIBSNDFILE),y)
 LAME_DEPENDENCIES += libsndfile
 LAME_CONF_OPTS += --with-fileio=sndfile