From patchwork Thu Mar 12 15:12:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Oudinet X-Patchwork-Id: 449522 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 0CD3E14010F for ; Fri, 13 Mar 2015 02:13:01 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=gmail.com header.i=@gmail.com header.b=MWoeBCsN; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id C5D06A38BF; Thu, 12 Mar 2015 15:13:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fO-BWmrit5ys; Thu, 12 Mar 2015 15:13:00 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 263EFA38AE; Thu, 12 Mar 2015 15:13:00 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 1A14F1C245A for ; Thu, 12 Mar 2015 15:12:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 172D932174 for ; Thu, 12 Mar 2015 15:12:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cFXZp-6Tqi5y for ; Thu, 12 Mar 2015 15:12:58 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) by silver.osuosl.org (Postfix) with ESMTPS id 2BF883067F for ; Thu, 12 Mar 2015 15:12:58 +0000 (UTC) Received: by wggx13 with SMTP id x13so17077875wgg.4 for ; Thu, 12 Mar 2015 08:12:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=Ca+HeKvmevz542Pn63VyvHqEmQ0d2u+icLGSFC7lhdY=; b=MWoeBCsNVApJ0WwUIBkbkODUbSuEyMS0I6AoVJVFNX6kDXU1DQYem1e4/hfUFw2pIi 7VcXxDWmH92G1+p4qS5MpBoH90VR4T+047GTly250TnHEvCsxeFr1U3rfDo/nvQ6/c0c 38sXUqk7Ja1tO8C5m768iJub6K2Q+OZYKoi7lRH2Hc5hRWeDjWoVwKm2cC24wyMsO5JF wcoogwrPErXqYCsNAZGKHbC0rw4EMwRUhPy+Aa66wPgAMwk6GTWUa2LaZ5sm1Wot7Ej2 B7rtexYQVHarb0qXlp346Nop7+8ST0K6CMnejnXsdbbLlTf9NjN9/wTg/3sf/KVyBOdO O0SA== X-Received: by 10.180.75.140 with SMTP id c12mr59957780wiw.14.1426173176665; Thu, 12 Mar 2015 08:12:56 -0700 (PDT) Received: from localhost.localdomain ([193.51.194.209]) by mx.google.com with ESMTPSA id at4sm10480926wjc.16.2015.03.12.08.12.55 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 12 Mar 2015 08:12:55 -0700 (PDT) From: Johan Oudinet To: buildroot@buildroot.org Date: Thu, 12 Mar 2015 16:12:25 +0100 Message-Id: <1426173147-27755-1-git-send-email-johan.oudinet@gmail.com> X-Mailer: git-send-email 2.1.0 Subject: [Buildroot] [PATCH v2 1/3] Remove --{enable, disable}-debug configure flags. X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Adding this flag when BR2_ENABLE_DEBUG is activated make several packages to produce binaries that do not work as expected (e.g., dhcp, lame, nano). Moreover, the help message of BR2_ENABLE_DEBUG does not say it is adding this flag. It is supposed to build packages with debugging symbols enabled. So, let it do that only. * package/Makefile.in: Do not add --{enable,disable}-debug flags. * package/pkg-autotools.mk: Remove ENABLE_DEBUG as it is not set anymore. Signed-off-by: Johan Oudinet Reviewed-by: "Yann E. MORIN" --- Changes v1 -> v2: - Do not pass --disable-debug neither. --- package/Makefile.in | 6 ------ package/pkg-autotools.mk | 1 - 2 files changed, 7 deletions(-) diff --git a/package/Makefile.in b/package/Makefile.in index 803b162..049c89b 100644 --- a/package/Makefile.in +++ b/package/Makefile.in @@ -387,12 +387,6 @@ ifneq ($(BR2_INSTALL_LIBSTDCPP),y) TARGET_CONFIGURE_OPTS += CXX=false endif -ifeq ($(BR2_ENABLE_DEBUG),y) -ENABLE_DEBUG := --enable-debug -else -ENABLE_DEBUG := --disable-debug -endif - ifeq ($(BR2_STATIC_LIBS),y) SHARED_STATIC_LIBS_OPTS = --enable-static --disable-shared TARGET_CFLAGS += -static diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk index d2f15fa..11bc643 100644 --- a/package/pkg-autotools.mk +++ b/package/pkg-autotools.mk @@ -203,7 +203,6 @@ define $(2)_CONFIGURE_CMDS $$(DISABLE_NLS) \ $$(DISABLE_LARGEFILE) \ $$(DISABLE_IPV6) \ - $$(ENABLE_DEBUG) \ $$(SHARED_STATIC_LIBS_OPTS) \ $$(QUIET) $$($$(PKG)_CONF_OPTS) \ )