From patchwork Sun Mar 1 21:06:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Porcedda X-Patchwork-Id: 444860 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ozlabs.org (Postfix) with ESMTP id 44A951401AC for ; Mon, 2 Mar 2015 08:07:09 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=gmail.com header.i=@gmail.com header.b=SbTVX+Os; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 3F6819124D; Sun, 1 Mar 2015 21:07:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tyu7kfKTXT0Z; Sun, 1 Mar 2015 21:07:07 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 2E66991557; Sun, 1 Mar 2015 21:07:07 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 43C251C22B6 for ; Sun, 1 Mar 2015 21:07:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3DCF2A1C8B for ; Sun, 1 Mar 2015 21:07:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qgp6OSydTtC6 for ; Sun, 1 Mar 2015 21:07:04 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 48849A1C67 for ; Sun, 1 Mar 2015 21:07:04 +0000 (UTC) Received: by wghl2 with SMTP id l2so29894989wgh.9 for ; Sun, 01 Mar 2015 13:07:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:in-reply-to:references; bh=TFKsPaHk9QVKJcWcRjrd9th+6694/JX7wd+qhPkPWK4=; b=SbTVX+OsNMd5J3QeBCGzIuO+i9NOc4E+aU1z/2C7xTX4h2SBUAeBFRm9vRGdcvGRCA g8MXxAGnhqLdZA+4+QUHb2+IWIT6cCgrCxi/zoHzwGDLwhSh1MmY9ZuSTA2rVWh2As5M Q+Zj1g46CKPwLhFeCsg8zVu3rHFwaPOPSWVBGUXp+ERMZBLc4Kh8aJFrmJWE0zox/n8x nh1jHWDD3f0VG049ji3f5A8rmhpRjuoqsn68TLJGuOuqn5ilFZpEqMuytW9L/3np3tO3 HZyj5+bwDVn4SPA86FS63uoBTPnRtPr3ZXlB/e2OxshhaTPBlUo1ry7WXje/z6SGUhhv bDsw== X-Received: by 10.194.89.163 with SMTP id bp3mr50811140wjb.145.1425244022776; Sun, 01 Mar 2015 13:07:02 -0800 (PST) Received: from mobeast.localdomain (dynamic-adsl-78-15-134-179.clienti.tiscali.it. [78.15.134.179]) by mx.google.com with ESMTPSA id ha5sm13149361wib.1.2015.03.01.13.07.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Mar 2015 13:07:01 -0800 (PST) From: Fabio Porcedda To: buildroot@uclibc.org Date: Sun, 1 Mar 2015 22:06:53 +0100 Message-Id: <1425244013-2509-3-git-send-email-fabio.porcedda@gmail.com> X-Mailer: git-send-email 2.3.1 In-Reply-To: <1425244013-2509-1-git-send-email-fabio.porcedda@gmail.com> References: <1425244013-2509-1-git-send-email-fabio.porcedda@gmail.com> Subject: [Buildroot] [PATCH v3 2/2] logrotate: use pkg-config for the opt library X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Without using the pkg-config the dependencies are not included for a static linking so it fails to build. These failures are fixed by linking the libintl library that is a dependency of the opt library. This commit to be useful requires the previous commit 'popt: add to the "popt.pc" file the libintl library'. Fixes: http://autobuild.buildroot.net/results/159bf5730414ca7f73dcdae95090177355193636 http://autobuild.buildroot.net/results/ebe6ab7fc0f2cff98de06b3dc374730da9e9e4f2 Minimal defconfig to reproduce the build failure: BR2_STATIC_LIBS=y BR2_TOOLCHAIN_BUILDROOT_LOCALE=y BR2_PACKAGE_GETTEXT=y BR2_PACKAGE_LOGROTATE=y Signed-off-by: Fabio Porcedda --- package/logrotate/logrotate.mk | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/package/logrotate/logrotate.mk b/package/logrotate/logrotate.mk index dc26d85..c1bca48 100644 --- a/package/logrotate/logrotate.mk +++ b/package/logrotate/logrotate.mk @@ -9,10 +9,12 @@ LOGROTATE_SITE = https://www.fedorahosted.org/releases/l/o/logrotate LOGROTATE_LICENSE = GPLv2+ LOGROTATE_LICENSE_FILES = COPYING -LOGROTATE_DEPENDENCIES = popt +LOGROTATE_DEPENDENCIES = popt host-pkgconf define LOGROTATE_BUILD_CMDS - $(MAKE) CC="$(TARGET_CC) $(TARGET_CFLAGS)" LDFLAGS="$(LDFLAGS)" -C $(@D) + $(MAKE) CC="$(TARGET_CC) $(TARGET_CFLAGS)" LDFLAGS="$(LDFLAGS)" \ + LOADLIBES="$(shell $(PKG_CONFIG_HOST_BINARY) --libs popt)" \ + -C $(@D) endef define LOGROTATE_INSTALL_TARGET_CMDS