| Message ID | 1422855653-6338-2-git-send-email-skenton@ou.edu |
|---|---|
| State | Changes Requested |
| Headers | show |
Dear Steve Kenton, On Mon, 2 Feb 2015 05:40:53 +0000, Steve Kenton wrote: > Signed-off-by: Steve Kenton <skenton@ou.edu> > --- > package/cdrtools/cdrtools.hash | 3 +++ > 1 file changed, 3 insertions(+) > create mode 100644 package/cdrtools/cdrtools.hash This patch should not be separated from the previous, it should be merged with it. > > diff --git a/package/cdrtools/cdrtools.hash b/package/cdrtools/cdrtools.hash > new file mode 100644 > index 0000000..c9f9c29 > --- /dev/null > +++ b/package/cdrtools/cdrtools.hash > @@ -0,0 +1,3 @@ > +cdrtools-3.00.tar.gz 2010-06-02 2.5 MB 6363 weekly downloads i This line doesn't make sense in a hash file. There should instead be a comment saying where the hashes are coming from. Something like: # From http://sourceforge.net/.... or # Locally computed Thanks, Thomas
On 2/2/2015 3:50 AM, Thomas Petazzoni wrote: > Dear Steve Kenton, > > On Mon, 2 Feb 2015 05:40:53 +0000, Steve Kenton wrote: >> Signed-off-by: Steve Kenton<skenton@ou.edu> >> --- >> package/cdrtools/cdrtools.hash | 3 +++ >> 1 file changed, 3 insertions(+) >> create mode 100644 package/cdrtools/cdrtools.hash > This patch should not be separated from the previous, it should be > merged with it. This was my first attempt at git. I tried to follow the directions in the buildroot manual but since these were separate commits they generated separate emails using the git format patch command example. What should it be to make it all one patch? Steve
Dear Steve Kenton, On Mon, 02 Feb 2015 09:03:19 -0600, Steve Kenton wrote: > This was my first attempt at git. I tried to follow the directions in > the buildroot manual but > since these were separate commits they generated separate emails using the > git format patch command example. What should it be to make it all one > patch? Look at "Interactive git rebasing", using 'git rebase -i'. It allows you to reorder patches, merge patches, edit patches, etc. Best regards, Thomas
diff --git a/package/cdrtools/cdrtools.hash b/package/cdrtools/cdrtools.hash new file mode 100644 index 0000000..c9f9c29 --- /dev/null +++ b/package/cdrtools/cdrtools.hash @@ -0,0 +1,3 @@ +cdrtools-3.00.tar.gz 2010-06-02 2.5 MB 6363 weekly downloads i +md5 bb21cefefcfbb76cf249120e8978ffdd cdrtools-3.00.tar.gz +sha1 2cd7d1725e0da2267b7a033cc744295d6e2bc6b9 cdrtools-3.00.tar.gz
Signed-off-by: Steve Kenton <skenton@ou.edu> --- package/cdrtools/cdrtools.hash | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 package/cdrtools/cdrtools.hash