From patchwork Fri Jan 23 18:10:22 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Barnett X-Patchwork-Id: 432249 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id CA9741402B1 for ; Sat, 24 Jan 2015 05:10:35 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id CE109A148F; Fri, 23 Jan 2015 18:10:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 035fw0De239R; Fri, 23 Jan 2015 18:10:33 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id DB14CA12AC; Fri, 23 Jan 2015 18:10:32 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 92BE21BFA4A for ; Fri, 23 Jan 2015 18:10:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 8DB1C31459 for ; Fri, 23 Jan 2015 18:10:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vpFx9o-wayJn for ; Fri, 23 Jan 2015 18:10:30 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from secvs02.rockwellcollins.com (secvs02.rockwellcollins.com [205.175.225.241]) by silver.osuosl.org (Postfix) with ESMTPS id 50BDD26C7F for ; Fri, 23 Jan 2015 18:10:30 +0000 (UTC) Received: from nosuchhost.198.131.in-addr.arpa (HELO crulimr01.rockwellcollins.com) ([131.198.26.129]) by secvs02.rockwellcollins.com with ESMTP; 23 Jan 2015 12:10:29 -0600 X-Received: from smtplb.rockwellcollins.com (smtplb.rockwellcollins.com [131.198.63.134]) by crulimr01.rockwellcollins.com (Postfix) with ESMTP id 5602A60100; Fri, 23 Jan 2015 12:10:29 -0600 (CST) X-Received: from largo.rockwellcollins.com (unknown [192.168.140.76]) by smtplb.rockwellcollins.com (Postfix) with ESMTP id 509CA8022E; Fri, 23 Jan 2015 12:10:29 -0600 (CST) From: Ryan Barnett To: buildroot@buildroot.org Date: Fri, 23 Jan 2015 12:10:22 -0600 Message-Id: <1422036622-54535-1-git-send-email-ryan.barnett@rockwellcollins.com> X-Mailer: git-send-email 1.9.1 Cc: "Yann E. MORIN" Subject: [Buildroot] [PATCH 1/1] pkg-cmake: fix host-cmake-package type X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" When trying to compile a host-cmake-package type such as host-cdrkit, an error happens in regards to HOSTCC and HOSTCXX not being found. /bin/sh: HOSTCC: command not found /bin/sh: HOSTCXX: command not found This due to the fact that the environment is incorrectly configured by having the following: -DCMAKE_C_COMPILER=""$(HOSTCC)"" -DCMAKE_CXX_COMPILER=""$(HOSTCXX)"" This is due to having too many dollar signs. The fix is to remove the extra dollar sign. Also removing the unncessary quotes since the HOSTCC/HOSTCXX will already contain quotes. This could cause an issue with make as double quotes are not interpreted by make. Minor formatting fix too. Signed-off-by: Ryan Barnett Acked-by: Samuel Martin CC: Yann E. MORIN Reviewed-by: "Yann E. MORIN" --- v1 -> v2 - Implemented spacing and quote concerns from Yann E. MORIN and Samuel Marin. Signed-off-by: Ryan Barnett --- package/pkg-cmake.mk | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk index 1037513..e738ba9 100644 --- a/package/pkg-cmake.mk +++ b/package/pkg-cmake.mk @@ -22,13 +22,13 @@ # Set compiler variables. ifeq ($(BR2_CCACHE),y) -CMAKE_HOST_C_COMPILER="$(HOST_DIR)/usr/bin/ccache" -CMAKE_HOST_CXX_COMPILER="$(HOST_DIR)/usr/bin/ccache" -CMAKE_HOST_C_COMPILER_ARG1="$(HOSTCC_NOCCACHE)" -CMAKE_HOST_CXX_COMPILER_ARG1="$(HOSTCXX_NOCCACHE)" +CMAKE_HOST_C_COMPILER = "$(HOST_DIR)/usr/bin/ccache" +CMAKE_HOST_CXX_COMPILER = "$(HOST_DIR)/usr/bin/ccache" +CMAKE_HOST_C_COMPILER_ARG1 = $(HOSTCC_NOCCACHE) +CMAKE_HOST_CXX_COMPILER_ARG1 = $(HOSTCXX_NOCCACHE) else -CMAKE_HOST_C_COMPILER="$$(HOSTCC)" -CMAKE_HOST_CXX_COMPILER="$$(HOSTCXX)" +CMAKE_HOST_C_COMPILER = $(HOSTCC) +CMAKE_HOST_CXX_COMPILER = $(HOSTCXX) endif ################################################################################