| Message ID | 1421227116-22976-1-git-send-email-paul@crapouillou.net |
|---|---|
| State | Rejected |
| Headers | show |
Dear Paul Cercueil, On Wed, 14 Jan 2015 10:18:36 +0100, Paul Cercueil wrote: > Disassembler support in Lightning requires libopcodes to be installed. > We cannot assume that an external toolchain will provide it. As such, > we now require a Buildroot toolchain for this option to be enabled. > > This fixes the following build issue: > http://autobuild.buildroot.net/results/ed7/ed7abf07f5f870ac332ed909f3cd1d92a2b8d75c/ > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > package/lightning/Config.in | 4 ++++ > 1 file changed, 4 insertions(+) This doesn't make sense. The libopcodes library is part of the target binutils, which can be enabled regardless of whether an internal (Buildroot) or external toolchain is used. When I merged the Lightning package, I did some testing including of the disassembler support, with a ARM external toolchain, and it was building fine. So, this patch is not the proper solution, I believe. Best regards, Thomas
diff --git a/package/lightning/Config.in b/package/lightning/Config.in index 8caf39f..3e5c133 100644 --- a/package/lightning/Config.in +++ b/package/lightning/Config.in @@ -14,6 +14,7 @@ config BR2_PACKAGE_LIGHTNING_DISASSEMBLER bool "enable disassembler" select BR2_PACKAGE_BINUTILS select BR2_PACKAGE_ZLIB + depends on BR2_TOOLCHAIN_BUILDROOT depends on !BR2_aarch64 && !BR2_nios2 # binutils depends on BR2_USE_WCHAR # binutils help @@ -23,4 +24,7 @@ comment "lightning disassembler needs a toolchain w/ wchar" depends on !BR2_aarch64 && !BR2_nios2 depends on !BR2_USE_WCHAR +comment "lightning disassembler requires a buildroot toolchain" + depends on !BR2_TOOLCHAIN_BUILDROOT + endif
Disassembler support in Lightning requires libopcodes to be installed. We cannot assume that an external toolchain will provide it. As such, we now require a Buildroot toolchain for this option to be enabled. This fixes the following build issue: http://autobuild.buildroot.net/results/ed7/ed7abf07f5f870ac332ed909f3cd1d92a2b8d75c/ Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- package/lightning/Config.in | 4 ++++ 1 file changed, 4 insertions(+)