Message ID | 1419074278-17625-2-git-send-email-gwenj@trabucayre.com |
---|---|
State | Superseded |
Headers | show |
Hi Gwenhael, On Sat, Dec 20, 2014 at 12:17 PM, Gwenhael Goavec-Merou <gwenj@trabucayre.com> wrote: > From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com> > > Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com> > --- > Changes v1 -> v2: > - Add python-cheetah patch > > package/Config.in | 1 + > package/python-cheetah/Config.in | 12 ++++++++++++ > package/python-cheetah/python-cheetah.mk | 14 ++++++++++++++ > 3 files changed, 27 insertions(+) > create mode 100644 package/python-cheetah/Config.in > create mode 100644 package/python-cheetah/python-cheetah.mk > > diff --git a/package/Config.in b/package/Config.in > index 51630ba..3324f17 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -489,6 +489,7 @@ menu "external python modules" > source "package/python-bottle/Config.in" > source "package/python-certifi/Config.in" > source "package/python-cffi/Config.in" > + source "package/python-cheetah/Config.in" > source "package/python-configobj/Config.in" > source "package/python-configshell-fb/Config.in" > source "package/python-crc16/Config.in" > diff --git a/package/python-cheetah/Config.in b/package/python-cheetah/Config.in > new file mode 100644 > index 0000000..732da6a > --- /dev/null > +++ b/package/python-cheetah/Config.in > @@ -0,0 +1,12 @@ > +config BR2_PACKAGE_PYTHON_CHEETAH > + bool "python-cheetah" > + depends on BR2_PACKAGE_PYTHON_MARKDOWN Why do you depends on python-markdown here, but not in the *.mk file? If it is just because of the dependency on host-python-markdown, this statement is not needed. If you mean: "target python-cheetah needs target python-markdown package", we usually use "select ...", and don't forget to add this dependency in the *.mk file too. > + help > + Cheetah is an open source template engine and code generation tool. > + > + It can be used standalone or combined with other tools and frameworks. > + Web development is its principle use, but Cheetah is very flexible > + and is also being used to generate C++ game code, Java, sql, form > + emails and even Python code. > + > + https://pypi.python.org/pypi/Cheetah/ > diff --git a/package/python-cheetah/python-cheetah.mk b/package/python-cheetah/python-cheetah.mk > new file mode 100644 > index 0000000..523ad26 > --- /dev/null > +++ b/package/python-cheetah/python-cheetah.mk > @@ -0,0 +1,14 @@ > +################################################################################ > +# > +# python-cheetah > +# > +################################################################################ > + > +PYTHON_CHEETAH_VERSION = 2.4.4 > +PYTHON_CHEETAH_SOURCE = Cheetah-$(PYTHON_CHEETAH_VERSION).tar.gz > +PYTHON_CHEETAH_SITE = http://pypi.python.org/packages/source/C/Cheetah > +PYTHON_CHEETAH_LICENSE = MIT > +PYTHON_CHEETAH_SETUP_TYPE = setuptools > +PYTHON_CHEETAH_DEPENDENCIES += host-python-markdown > + > +$(eval $(python-package)) > -- > 2.0.4 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot Regards,
Dear Samuel Martin, On Sat, 20 Dec 2014 13:59:36 +0100, Samuel Martin wrote: > If you mean: "target python-cheetah needs target python-markdown > package", we usually use "select ...", and don't forget to add this > dependency in the *.mk file too. Unless it's a runtime dependency, which is very often the case for Python modules. In this case, having a select in Config.in is sufficient, there is no need to have a dependency in the .mk file. However, in such cases, we clarify things by doing: # runtime dependency only select BR2_PACKAGE_<foobar> Thomas
diff --git a/package/Config.in b/package/Config.in index 51630ba..3324f17 100644 --- a/package/Config.in +++ b/package/Config.in @@ -489,6 +489,7 @@ menu "external python modules" source "package/python-bottle/Config.in" source "package/python-certifi/Config.in" source "package/python-cffi/Config.in" + source "package/python-cheetah/Config.in" source "package/python-configobj/Config.in" source "package/python-configshell-fb/Config.in" source "package/python-crc16/Config.in" diff --git a/package/python-cheetah/Config.in b/package/python-cheetah/Config.in new file mode 100644 index 0000000..732da6a --- /dev/null +++ b/package/python-cheetah/Config.in @@ -0,0 +1,12 @@ +config BR2_PACKAGE_PYTHON_CHEETAH + bool "python-cheetah" + depends on BR2_PACKAGE_PYTHON_MARKDOWN + help + Cheetah is an open source template engine and code generation tool. + + It can be used standalone or combined with other tools and frameworks. + Web development is its principle use, but Cheetah is very flexible + and is also being used to generate C++ game code, Java, sql, form + emails and even Python code. + + https://pypi.python.org/pypi/Cheetah/ diff --git a/package/python-cheetah/python-cheetah.mk b/package/python-cheetah/python-cheetah.mk new file mode 100644 index 0000000..523ad26 --- /dev/null +++ b/package/python-cheetah/python-cheetah.mk @@ -0,0 +1,14 @@ +################################################################################ +# +# python-cheetah +# +################################################################################ + +PYTHON_CHEETAH_VERSION = 2.4.4 +PYTHON_CHEETAH_SOURCE = Cheetah-$(PYTHON_CHEETAH_VERSION).tar.gz +PYTHON_CHEETAH_SITE = http://pypi.python.org/packages/source/C/Cheetah +PYTHON_CHEETAH_LICENSE = MIT +PYTHON_CHEETAH_SETUP_TYPE = setuptools +PYTHON_CHEETAH_DEPENDENCIES += host-python-markdown + +$(eval $(python-package))