Message ID | 1418135662-773-7-git-send-email-johan.oudinet@gmail.com |
---|---|
State | Superseded |
Headers | show |
Dear Johan Oudinet, On Tue, 9 Dec 2014 15:34:11 +0100, Johan Oudinet wrote: > diff --git a/package/erlang-lager/Config.in b/package/erlang-lager/Config.in > new file mode 100644 > index 0000000..f83239e > --- /dev/null > +++ b/package/erlang-lager/Config.in > @@ -0,0 +1,12 @@ > +config BR2_PACKAGE_ERLANG_LAGER > + bool "erlang-lager" > + depends on BR2_PACKAGE_ERLANG Same as erlang-goldrush. > + select BR2_PACKAGE_ERLANG_GOLDRUSH > + help > + Logging framework for Erlang. > + > + Lager (as in the beer) is a logging framework for > + Erlang. Its purpose is to provide a more traditional way to > + perform logging in an erlang application that plays nicely > + with traditional UNIX logging tools like logrotate and > + syslog. We generally want an upstream web site location at the end of the Config.in help text. > diff --git a/package/erlang-lager/erlang-lager.mk b/package/erlang-lager/erlang-lager.mk > new file mode 100644 > index 0000000..b530c8e > --- /dev/null > +++ b/package/erlang-lager/erlang-lager.mk > @@ -0,0 +1,14 @@ > +################################################################################ > +# > +# erlang-lager > +# > +################################################################################ > + > +ERLANG_LAGER_VERSION = 2.0.3 > +ERLANG_LAGER_SITE = $(call github,basho,lager,$(ERLANG_LAGER_VERSION)) > +ERLANG_LAGER_LICENSE = Apache-2.0 > +ERLANG_LAGER_LICENSE_FILES = LICENSE > +ERLANG_LAGER_DEPENDENCIES = erlang erlang-goldrush The dependency on erlang-goldrush looks OK, but why isn't the dependency on erlang added automatically by the rebar-package macro? > +$(eval $(rebar-package)) > +$(eval $(host-rebar-package)) Same as previous package: why a host variant is needed? Thanks! Thomas
Thomas, All, On Sun, Jan 4, 2015 at 10:37 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > On Tue, 9 Dec 2014 15:34:11 +0100, Johan Oudinet wrote: > >> diff --git a/package/erlang-lager/erlang-lager.mk b/package/erlang-lager/erlang-lager.mk >> new file mode 100644 >> index 0000000..b530c8e >> --- /dev/null >> +++ b/package/erlang-lager/erlang-lager.mk >> @@ -0,0 +1,14 @@ >> +$(eval $(rebar-package)) >> +$(eval $(host-rebar-package)) > > Same as previous package: why a host variant is needed? host-erlang-lager is listed in ejabberd dependencies. I do not remember why, so I'm going to check if it is really needed and add an explanation on the commit message if so. Thanks.
Dear Johan Oudinet, On Mon, 5 Jan 2015 17:10:32 +0100, Johan Oudinet wrote: > Thomas, All, > > On Sun, Jan 4, 2015 at 10:37 PM, Thomas Petazzoni > <thomas.petazzoni@free-electrons.com> wrote: > > On Tue, 9 Dec 2014 15:34:11 +0100, Johan Oudinet wrote: > > > >> diff --git a/package/erlang-lager/erlang-lager.mk b/package/erlang-lager/erlang-lager.mk > >> new file mode 100644 > >> index 0000000..b530c8e > >> --- /dev/null > >> +++ b/package/erlang-lager/erlang-lager.mk > >> @@ -0,0 +1,14 @@ > >> +$(eval $(rebar-package)) > >> +$(eval $(host-rebar-package)) > > > > Same as previous package: why a host variant is needed? > > host-erlang-lager is listed in ejabberd dependencies. I do not > remember why, so I'm going to check if it is really needed and add an > explanation on the commit message if so. Ah, my review did not go all the way to ejabberd, sorry about missing this. Indeed, please check if host-erlang-lager is needed, and if it is, quickly indicate in the commit log which package uses it. Thanks a lot! Thomas
Thomas, All, On Mon, Jan 5, 2015 at 5:38 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > On Mon, 5 Jan 2015 17:10:32 +0100, Johan Oudinet wrote: >> On Sun, Jan 4, 2015 at 10:37 PM, Thomas Petazzoni >> <thomas.petazzoni@free-electrons.com> wrote: >> > On Tue, 9 Dec 2014 15:34:11 +0100, Johan Oudinet wrote: >> > >> >> diff --git a/package/erlang-lager/erlang-lager.mk b/package/erlang-lager/erlang-lager.mk >> >> new file mode 100644 >> >> index 0000000..b530c8e >> >> --- /dev/null >> >> +++ b/package/erlang-lager/erlang-lager.mk >> >> @@ -0,0 +1,14 @@ >> >> +$(eval $(rebar-package)) >> >> +$(eval $(host-rebar-package)) >> > >> > Same as previous package: why a host variant is needed? >> >> host-erlang-lager is listed in ejabberd dependencies. I do not >> remember why, so I'm going to check if it is really needed and add an >> explanation on the commit message if so. > > Ah, my review did not go all the way to ejabberd, sorry about missing > this. Indeed, please check if host-erlang-lager is needed, and if it > is, quickly indicate in the commit log which package uses it. > It does need it otherwise ejabberd compilation failed at src/gen_mod.erl, which includes include/logger.hrl. At line 23 of this file there is such statement : -compile([{parse_transform, lager_transform}]). And lager_transform is provided by erlang-lager. So, I'll mention that ejabberd uses host-erlang-lager in the patches for erlang-lager and erlang-goldrush, which is a dependency of erlang-lager.
diff --git a/package/Config.in b/package/Config.in index 06c8e04..7703828 100644 --- a/package/Config.in +++ b/package/Config.in @@ -395,6 +395,7 @@ menu "Interpreter languages and scripting" if BR2_PACKAGE_ERLANG menu "Erlang libraries/modules" source "package/erlang-goldrush/Config.in" + source "package/erlang-lager/Config.in" endmenu endif source "package/guile/Config.in" diff --git a/package/erlang-lager/Config.in b/package/erlang-lager/Config.in new file mode 100644 index 0000000..f83239e --- /dev/null +++ b/package/erlang-lager/Config.in @@ -0,0 +1,12 @@ +config BR2_PACKAGE_ERLANG_LAGER + bool "erlang-lager" + depends on BR2_PACKAGE_ERLANG + select BR2_PACKAGE_ERLANG_GOLDRUSH + help + Logging framework for Erlang. + + Lager (as in the beer) is a logging framework for + Erlang. Its purpose is to provide a more traditional way to + perform logging in an erlang application that plays nicely + with traditional UNIX logging tools like logrotate and + syslog. diff --git a/package/erlang-lager/erlang-lager.mk b/package/erlang-lager/erlang-lager.mk new file mode 100644 index 0000000..b530c8e --- /dev/null +++ b/package/erlang-lager/erlang-lager.mk @@ -0,0 +1,14 @@ +################################################################################ +# +# erlang-lager +# +################################################################################ + +ERLANG_LAGER_VERSION = 2.0.3 +ERLANG_LAGER_SITE = $(call github,basho,lager,$(ERLANG_LAGER_VERSION)) +ERLANG_LAGER_LICENSE = Apache-2.0 +ERLANG_LAGER_LICENSE_FILES = LICENSE +ERLANG_LAGER_DEPENDENCIES = erlang erlang-goldrush + +$(eval $(rebar-package)) +$(eval $(host-rebar-package))