From patchwork Sun Nov 2 23:58:16 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Hadjinlian X-Patchwork-Id: 405992 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ozlabs.org (Postfix) with ESMTP id EB20A14008C for ; Mon, 3 Nov 2014 10:58:39 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 3B96391B81; Sun, 2 Nov 2014 23:58:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JYtgR04AIid3; Sun, 2 Nov 2014 23:58:36 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 47EB791BD6; Sun, 2 Nov 2014 23:58:31 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id C16691C288A for ; Sun, 2 Nov 2014 23:58:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id B900F320CE for ; Sun, 2 Nov 2014 23:58:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XC4EyUaZEyCH for ; Sun, 2 Nov 2014 23:58:26 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by silver.osuosl.org (Postfix) with ESMTPS id A6EAC30041 for ; Sun, 2 Nov 2014 23:58:26 +0000 (UTC) Received: by mail-wg0-f48.google.com with SMTP id m15so4568815wgh.21 for ; Sun, 02 Nov 2014 15:58:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=e0Nj+hKForgrcZ8Jcd/ivid5wUJtL1Mq4GzbG+37ixE=; b=Sq4/PDKWpLlQC/55RnI5H/bbhp4Q87DV8+eJW9iE5kTlgwly5F1dS1AZR4RYcWxus1 peovI5fi3AmqgYSJgXdqRnhoJiiOoZIyrF/X8gf3mpn1V4qjE9gKB12tVeU033Uy+4kB 7Wovej8+DjceiouBRGzCSbKgJq1CAD8GfsFKB/LGu5NDSMz7rvXXYCMMcWra2rfIL9rG 0D/TqlE89mKt8sQ36aC4JvmFZ0jyUcvaEbkdmT/5vYX/BqOeyYy0tOBjRtJg3TiW0kTE iS7bMuu10Ap9CDW3JWIEhzt234Vrig9HYqBbj+feKfZu0ojKKw017GZD50DqH0E0WqB4 XEjw== X-Received: by 10.194.205.132 with SMTP id lg4mr5833813wjc.84.1414972705045; Sun, 02 Nov 2014 15:58:25 -0800 (PST) Received: from localhost.localdomain (13-105-190-109.dsl.ovh.fr. [109.190.105.13]) by mx.google.com with ESMTPSA id fa16sm6851985wid.5.2014.11.02.15.58.24 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 02 Nov 2014 15:58:24 -0800 (PST) From: Maxime Hadjinlian To: buildroot@buildroot.org Date: Mon, 3 Nov 2014 00:58:16 +0100 Message-Id: <1414972696-10647-3-git-send-email-maxime.hadjinlian@gmail.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1414972696-10647-1-git-send-email-maxime.hadjinlian@gmail.com> References: <1414972696-10647-1-git-send-email-maxime.hadjinlian@gmail.com> Subject: [Buildroot] [PATCH 3/3] website: Tidy up code X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" By inversing the "if (!result.error)" we gain one level of indent. Also moving variable declarations into a more correct block of code. Signed-off-by: Maxime Hadjinlian --- docs/js/buildroot.js | 53 ++++++++++++++++++++++++++-------------------------- 1 file changed, 27 insertions(+), 26 deletions(-) diff --git a/docs/js/buildroot.js b/docs/js/buildroot.js index dd6ca6e..83a3ac0 100644 --- a/docs/js/buildroot.js +++ b/docs/js/buildroot.js @@ -1,33 +1,34 @@ function load_activity(feedurl, divid) { var feed = new google.feeds.Feed(feedurl); + var container = document.getElementById(divid); + var loaded = 0; + var nb_display = 8; feed.setNumEntries(30); feed.load(function(result) { - if (!result.error) { - var container = document.getElementById(divid); - var loaded = 0; - var nb_display = 8; - for (var i = 0; i < result.feed.entries.length; i++) { - var entry = result.feed.entries[i]; - if (entry.title.indexOf("git commit") != -1) - continue; - loaded += 1; - if (loaded > nb_display) - break; - var div = document.createElement("p"); - var link = document.createElement("a"); - var d = new Date(entry.publishedDate); - var data = '[' + d.toLocaleDateString() + '] ' + entry.title - var text = document.createTextNode(data); - link.appendChild(text); - link.title = entry.title; - link.href = entry.link - div.appendChild(link); - container.appendChild(div); - } - var empty = nb_display - loaded; - for (var i = 0; i < empty; i++) { - container.appendChild(document.createElement("p")); - } + if (result.error) { + return; + } + for (var i = 0; i < result.feed.entries.length; i++) { + var entry = result.feed.entries[i]; + if (entry.title.indexOf("git commit") != -1) + continue; + loaded += 1; + if (loaded > nb_display) + break; + var div = document.createElement("p"); + var link = document.createElement("a"); + var d = new Date(entry.publishedDate); + var data = '[' + d.toLocaleDateString() + '] ' + entry.title + var text = document.createTextNode(data); + link.appendChild(text); + link.title = entry.title; + link.href = entry.link + div.appendChild(link); + container.appendChild(div); + } + var empty = nb_display - loaded; + for (var i = 0; i < empty; i++) { + container.appendChild(document.createElement("p")); } }); }