| Message ID | 1414345306-27184-3-git-send-email-dywi@mailerd.de |
|---|---|
| State | Accepted |
| Headers | show |
Dear André Erdmann, On Sun, 26 Oct 2014 18:41:45 +0100, André Erdmann wrote: > "<command> &>/dev/null" is supposed to redirect all output to /dev/null. > > However, in shells that don't support it (dash, ash without bash extensions), > a command like "echo a &>/dev/null" is interpreted as > > (a) "echo a" in background > (b) write nothing to /dev/null (redirect <empty command> to /dev/null) > > This commit replaces "&>..." with ">/dev/null 2>&1". > > Signed-off-by: André Erdmann <dywi@mailerd.de> > --- > package/network-manager/S45network-manager | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Thomas
diff --git a/package/network-manager/S45network-manager b/package/network-manager/S45network-manager index 112aa66..7880891 100755 --- a/package/network-manager/S45network-manager +++ b/package/network-manager/S45network-manager @@ -24,7 +24,7 @@ case "$1" in ;; stop) echo -n "Stopping NetworkManager ... " - [ ! -z "$PID" ] && kill $PID &> /dev/null + [ ! -z "$PID" ] && kill $PID > /dev/null 2>&1 if [ $? -gt 0 ]; then echo "failed!" else
"<command> &>/dev/null" is supposed to redirect all output to /dev/null. However, in shells that don't support it (dash, ash without bash extensions), a command like "echo a &>/dev/null" is interpreted as (a) "echo a" in background (b) write nothing to /dev/null (redirect <empty command> to /dev/null) This commit replaces "&>..." with ">/dev/null 2>&1". Signed-off-by: André Erdmann <dywi@mailerd.de> --- package/network-manager/S45network-manager | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)