| Message ID | 1400063214-29462-2-git-send-email-maxime.hadjinlian@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes: > printf is POSIX-compliant, echo -e is not. > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> > --- > package/acpid/acpid.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > diff --git a/package/acpid/acpid.mk b/package/acpid/acpid.mk > index 1f4ec31..4a61f16 100644 > --- a/package/acpid/acpid.mk > +++ b/package/acpid/acpid.mk > @@ -17,7 +17,7 @@ endef > define ACPID_SET_EVENTS > mkdir -p $(TARGET_DIR)/etc/acpi/events > - /bin/echo -e "event=button[ /]power\naction=/sbin/poweroff" \ > + printf "event=button[ /]power\naction=/sbin/poweroff" \ >> $(TARGET_DIR)/etc/acpi/events/powerbtn These are not 100% identical (printf doesn't add a trailing newline). Have you tested if the newline isn't needed?
diff --git a/package/acpid/acpid.mk b/package/acpid/acpid.mk index 1f4ec31..4a61f16 100644 --- a/package/acpid/acpid.mk +++ b/package/acpid/acpid.mk @@ -17,7 +17,7 @@ endef define ACPID_SET_EVENTS mkdir -p $(TARGET_DIR)/etc/acpi/events - /bin/echo -e "event=button[ /]power\naction=/sbin/poweroff" \ + printf "event=button[ /]power\naction=/sbin/poweroff" \ >$(TARGET_DIR)/etc/acpi/events/powerbtn endef
printf is POSIX-compliant, echo -e is not. Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> --- package/acpid/acpid.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)