| Message ID | 1392680233-24585-2-git-send-email-maxime.hadjinlian@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
Dear Maxime Hadjinlian, On Tue, 18 Feb 2014 00:37:10 +0100, Maxime Hadjinlian wrote: > diff --git a/package/sdl/sdl.mk b/package/sdl/sdl.mk > index ba5fbca..bc48d35 100644 > --- a/package/sdl/sdl.mk > +++ b/package/sdl/sdl.mk > @@ -18,8 +18,9 @@ define SDL_RUN_AUTOGEN > endef > > SDL_POST_PATCH_HOOKS += SDL_RUN_AUTOGEN > -SDL_DEPENDENCIES += host-automake host-autoconf host-libtool > +HOST_SDL_POST_PATCH_HOOKS += SDL_RUN_AUTOGEN This should be a pre-configure hook, as we discussed recently on the list. Thomas
On Tue, Feb 18, 2014 at 5:13 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Maxime Hadjinlian, > > On Tue, 18 Feb 2014 00:37:10 +0100, Maxime Hadjinlian wrote: > >> diff --git a/package/sdl/sdl.mk b/package/sdl/sdl.mk >> index ba5fbca..bc48d35 100644 >> --- a/package/sdl/sdl.mk >> +++ b/package/sdl/sdl.mk >> @@ -18,8 +18,9 @@ define SDL_RUN_AUTOGEN >> endef >> >> SDL_POST_PATCH_HOOKS += SDL_RUN_AUTOGEN >> -SDL_DEPENDENCIES += host-automake host-autoconf host-libtool >> +HOST_SDL_POST_PATCH_HOOKS += SDL_RUN_AUTOGEN > > This should be a pre-configure hook, as we discussed recently on the > list. Argh. Forgot to change this...will do ! > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com
>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes: > Host version is needed to build xbmc > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > --- > Changes v6 -> v7: > - Add one empty line for clarity > Changes v5 -> v6: > - None > Changes v4 -> v5: > - None > Changes v3 -> v4: > - None > Changes v2 -> v3: > - None > Changes v1 -> v2: > - None > --- > package/sdl/sdl.mk | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > diff --git a/package/sdl/sdl.mk b/package/sdl/sdl.mk > index ba5fbca..bc48d35 100644 > --- a/package/sdl/sdl.mk > +++ b/package/sdl/sdl.mk > @@ -18,8 +18,9 @@ define SDL_RUN_AUTOGEN > endef > SDL_POST_PATCH_HOOKS += SDL_RUN_AUTOGEN > -SDL_DEPENDENCIES += host-automake host-autoconf host-libtool > +HOST_SDL_POST_PATCH_HOOKS += SDL_RUN_AUTOGEN Committed to next with this fixed up to use PRE_CONFIGURE_HOOKS instead, thanks.
diff --git a/package/sdl/sdl.mk b/package/sdl/sdl.mk index ba5fbca..bc48d35 100644 --- a/package/sdl/sdl.mk +++ b/package/sdl/sdl.mk @@ -18,8 +18,9 @@ define SDL_RUN_AUTOGEN endef SDL_POST_PATCH_HOOKS += SDL_RUN_AUTOGEN -SDL_DEPENDENCIES += host-automake host-autoconf host-libtool +HOST_SDL_POST_PATCH_HOOKS += SDL_RUN_AUTOGEN +SDL_DEPENDENCIES += host-automake host-autoconf host-libtool ifeq ($(BR2_PACKAGE_SDL_FBCON),y) SDL_CONF_OPT += --enable-video-fbcon=yes @@ -80,3 +81,4 @@ endef SDL_POST_INSTALL_STAGING_HOOKS += SDL_FIXUP_SDL_CONFIG $(eval $(autotools-package)) +$(eval $(host-autotools-package))