| Message ID | 1391727417-12293-1-git-send-email-rjbarnet@rockwellcollins.com |
|---|---|
| State | Accepted |
| Headers | show |
Dear Ryan Barnett, On Thu, 6 Feb 2014 23:56:56 +0100, Ryan Barnett wrote: > diff --git a/package/dmraid/Config.in b/package/dmraid/Config.in > index 028b46c..2f0c5b4 100644 > --- a/package/dmraid/Config.in > +++ b/package/dmraid/Config.in > @@ -2,6 +2,7 @@ config BR2_PACKAGE_DMRAID > bool "dmraid" > depends on BR2_LARGEFILE > depends on BR2_USE_MMU # lvm2 > + depends on !BR2_arc I believe it would be good to have a comment above this line that says why it's disabled. Maybe something like: # causes an internal compiler error on ARC Ditto for the gpsd issue on Microblaze. And maybe Cc the ARC and Microblaze "maintainers" : Anton Kolesov <Anton.Kolesov@synopsys.com> for ARC, and Spenser Gilliland <spenser@gillilanding.com> for Microblaze. Thanks! Thomas
>>>>> "Ryan" == Ryan Barnett <ryanbarnett3@gmail.com> writes: > The ARC compiler has an internal failure while compiling this package > so disable this package for this architecture. > Fixes: > http://autobuild.buildroot.net/results/ef6/ef6a0e2d382ae202bb8f0e9fc9f5e48c90119faf > Signed-off-by: Ryan Barnett <rjbarnet@rockwellcollins.com> Committed with a comment added explaining why, thanks.
diff --git a/package/dmraid/Config.in b/package/dmraid/Config.in index 028b46c..2f0c5b4 100644 --- a/package/dmraid/Config.in +++ b/package/dmraid/Config.in @@ -2,6 +2,7 @@ config BR2_PACKAGE_DMRAID bool "dmraid" depends on BR2_LARGEFILE depends on BR2_USE_MMU # lvm2 + depends on !BR2_arc select BR2_PACKAGE_LVM2 help dmraid discovers, activates, deactivates and displays properties @@ -13,3 +14,4 @@ config BR2_PACKAGE_DMRAID comment "dmraid needs a toolchain w/ largefile" depends on BR2_USE_MMU depends on !BR2_LARGEFILE + depends on !BR2_arc
The ARC compiler has an internal failure while compiling this package so disable this package for this architecture. Fixes: http://autobuild.buildroot.net/results/ef6/ef6a0e2d382ae202bb8f0e9fc9f5e48c90119faf Signed-off-by: Ryan Barnett <rjbarnet@rockwellcollins.com> --- package/dmraid/Config.in | 2 ++ 1 file changed, 2 insertions(+)