| Message ID | 1384595893-15468-1-git-send-email-spdawson@gmail.com |
|---|---|
| State | Accepted |
| Commit | 1b5bd7a29694881cf85c653e2307d7b8464a15c9 |
| Headers | show |
>>>>> "spdawson" == spdawson <spdawson@gmail.com> writes: > From: Simon Dawson <spdawson@gmail.com> > The epoll_create1, timerfd_create and timerfd_settime syscalls are not available > on avr32. Fixes build failures such as the following. > http://autobuild.buildroot.net/results/43b/43b3df5978782034279604abde8fe5d46c441344/ Committed, thanks.
Hi, On Sat, Nov 16, 2013 at 10:58 AM, <spdawson@gmail.com> wrote: > From: Simon Dawson <spdawson@gmail.com> > > The epoll_create1, timerfd_create and timerfd_settime syscalls are not available > on avr32. Fixes build failures such as the following. > > http://autobuild.buildroot.net/results/43b/43b3df5978782034279604abde8fe5d46c441344/ > > Signed-off-by: Simon Dawson <spdawson@gmail.com> > --- > package/gstreamer1/gst1-plugins-bad/Config.in | 1 + > package/wayland/Config.in | 2 ++ > package/weston/Config.in | 2 ++ > 3 files changed, 5 insertions(+) > > diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in b/package/gstreamer1/gst1-plugins-bad/Config.in > index d6f087d..d028245 100644 > --- a/package/gstreamer1/gst1-plugins-bad/Config.in > +++ b/package/gstreamer1/gst1-plugins-bad/Config.in > @@ -358,6 +358,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DIRECTFB > > config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLAND > bool "wayland" > + depends on !BR2_avr32 # wayland > depends on BR2_TOOLCHAIN_HAS_THREADS # wayland > select BR2_PACKAGE_WAYLAND > help It seems that several gstreamer plugins lack the necessary comments, e.g. for thread support. Normally, the avr32 dependency would also have been added to such comments... I'll add that to my todo list for comments cleanup, but someone else is free to take it of course... Best regards, Thomas
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes: Hi, >> config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLAND >> bool "wayland" >> + depends on !BR2_avr32 # wayland >> depends on BR2_TOOLCHAIN_HAS_THREADS # wayland >> select BR2_PACKAGE_WAYLAND >> help > It seems that several gstreamer plugins lack the necessary comments, > e.g. for thread support. Yes. Do notice that gstreamer itself needs threads, so it doesn't really matter much.
On Sun, Nov 17, 2013 at 9:03 AM, Peter Korsgaard <jacmet@uclibc.org> wrote: >>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes: > > Hi, > > >> config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLAND > >> bool "wayland" > >> + depends on !BR2_avr32 # wayland > >> depends on BR2_TOOLCHAIN_HAS_THREADS # wayland > >> select BR2_PACKAGE_WAYLAND > >> help > > > It seems that several gstreamer plugins lack the necessary comments, > > e.g. for thread support. > > Yes. Do notice that gstreamer itself needs threads, so it doesn't really > matter much. This then boils down to the question whether we replicate the dependencies/and comments in such case or not. There is another thread where this action was asked, I'll bump it in a second, then we can have the discussion there... Best regards, Thomas
diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in b/package/gstreamer1/gst1-plugins-bad/Config.in index d6f087d..d028245 100644 --- a/package/gstreamer1/gst1-plugins-bad/Config.in +++ b/package/gstreamer1/gst1-plugins-bad/Config.in @@ -358,6 +358,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DIRECTFB config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLAND bool "wayland" + depends on !BR2_avr32 # wayland depends on BR2_TOOLCHAIN_HAS_THREADS # wayland select BR2_PACKAGE_WAYLAND help diff --git a/package/wayland/Config.in b/package/wayland/Config.in index 260832f..c92f9ea 100644 --- a/package/wayland/Config.in +++ b/package/wayland/Config.in @@ -1,5 +1,6 @@ config BR2_PACKAGE_WAYLAND bool "wayland" + depends on !BR2_avr32 # no epoll_create1, timerfd_create or timerfd_settime depends on BR2_TOOLCHAIN_HAS_THREADS select BR2_PACKAGE_LIBFFI select BR2_PACKAGE_EXPAT @@ -11,4 +12,5 @@ config BR2_PACKAGE_WAYLAND http://wayland.freedesktop.org/ comment "wayland needs a toolchain w/ threads" + depends on !BR2_avr32 depends on !BR2_TOOLCHAIN_HAS_THREADS diff --git a/package/weston/Config.in b/package/weston/Config.in index b7f8468..247efc8 100644 --- a/package/weston/Config.in +++ b/package/weston/Config.in @@ -1,4 +1,5 @@ comment "weston needs udev and a toolchain w/ threads" + depends on !BR2_avr32 depends on !BR2_PACKAGE_UDEV || !BR2_TOOLCHAIN_HAS_THREADS config BR2_PACKAGE_WESTON @@ -11,6 +12,7 @@ config BR2_PACKAGE_WESTON select BR2_PACKAGE_JPEG select BR2_PACKAGE_MTDEV depends on BR2_PACKAGE_UDEV + depends on !BR2_avr32 # wayland depends on BR2_TOOLCHAIN_HAS_THREADS # wayland # Runtime dependency select BR2_PACKAGE_XKEYBOARD_CONFIG