diff mbox

[v2] log4cxx: needs threads

Message ID 1384177029-25518-1-git-send-email-spdawson@gmail.com
State Accepted
Commit 5f6dd5eb73f6e60916fea8b4a78787f270d95e65
Headers show

Commit Message

Simon Dawson Nov. 11, 2013, 1:37 p.m. UTC 
From: Simon Dawson <spdawson@gmail.com>

Fixes build failures such as the following.

  http://autobuild.buildroot.net/results/7b73901d9e8b5098cd96b54d292bb3ffffb3fe37/

Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
 v2: At the suggestion of Thomas De Schampheleire, update the comment to
 explain that dynamic library support is required

 package/log4cxx/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Peter Korsgaard Nov. 11, 2013, 2:05 p.m. UTC | #1 
>>>>> "spdawson" == spdawson  <spdawson@gmail.com> writes:

> From: Simon Dawson <spdawson@gmail.com>
> Fixes build failures such as the following.

>   http://autobuild.buildroot.net/results/7b73901d9e8b5098cd96b54d292bb3ffffb3fe37/

> Signed-off-by: Simon Dawson <spdawson@gmail.com>
> ---
>  v2: At the suggestion of Thomas De Schampheleire, update the comment to
>  explain that dynamic library support is required

Committed, thanks.
diff mbox

Patch

diff --git a/package/log4cxx/Config.in b/package/log4cxx/Config.in
index 86d6a1d..8791b8c 100644
--- a/package/log4cxx/Config.in
+++ b/package/log4cxx/Config.in
@@ -5,11 +5,13 @@  config BR2_PACKAGE_LOG4CXX
 	# apr really needs shared library support
 	depends on !BR2_PREFER_STATIC_LIB
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  Apache log4cxx is a logging framework for C++ patterned
 	  after Apache log4j.
 
 	  http://apache.linux-mirror.org/logging/log4cxx/0.10.0
 
-comment "log4cxx needs a toolchain w/ C++"
-	depends on !BR2_INSTALL_LIBSTDCPP
+comment "log4cxx needs a toolchain w/ C++, threads, dynamic library"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
+		BR2_PREFER_STATIC_LIB