From patchwork Tue Nov 5 07:55:14 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Dawson X-Patchwork-Id: 288406 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133]) by ozlabs.org (Postfix) with ESMTP id 6CD672C0246 for ; Tue, 5 Nov 2013 18:55:23 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 72B8194280; Tue, 5 Nov 2013 07:55:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kHw4OK-zS9aS; Tue, 5 Nov 2013 07:55:20 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id B2F9494270; Tue, 5 Nov 2013 07:55:20 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 36DA71BF9E7 for ; Tue, 5 Nov 2013 07:55:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 32CEF8F8D7 for ; Tue, 5 Nov 2013 07:55:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QeenVot3cS2h for ; Tue, 5 Nov 2013 07:55:18 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by whitealder.osuosl.org (Postfix) with ESMTPS id 87F848F8D6 for ; Tue, 5 Nov 2013 07:55:18 +0000 (UTC) Received: by mail-wi0-f170.google.com with SMTP id ex4so2957712wid.3 for ; Mon, 04 Nov 2013 23:55:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id; bh=go4i4cu/1tCwf3gLdTfFKg6M9U7N1oNfKvfwodjeLsY=; b=VbUc6tiDJvmB8AyQyMyAzVhor8T79FAU+tc+YbwsaWeYIuFu2Dwsf42YINhNqoSi5E CsG0KM/JboXJtRZbRNbm9jrwIUxuOsiMXKq2MDBKkyDnbRZ4PCxhvlWvS3Db/CR00XDO Xxadl/nBZVmbCwYYOW9i+rQrJj/oSuN9zeHwk9W+66is4QfoIznVeEetc1dOTiTALkVG pgeTZr4WY/XZXjLOyG+NhC9VwuULFyMVfZxcm0oXLuhdhm5FOhmkBNjy2CuB3GEXg8Ao 2uAqgrarRSXOhlESP1pXVUokXnY0sCKIPhH0PvAogBzHDRDLmVSrsO4Dqam06YbwQqIv /2XA== X-Received: by 10.180.188.49 with SMTP id fx17mr15585161wic.33.1383638117058; Mon, 04 Nov 2013 23:55:17 -0800 (PST) Received: from percy.lan (host-92-24-119-175.ppp.as43234.net. [92.24.119.175]) by mx.google.com with ESMTPSA id ft19sm11581003wic.5.2013.11.04.23.55.15 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 04 Nov 2013 23:55:16 -0800 (PST) From: spdawson@gmail.com To: buildroot@busybox.net Date: Tue, 5 Nov 2013 07:55:14 +0000 Message-Id: <1383638114-9207-1-git-send-email-spdawson@gmail.com> X-Mailer: git-send-email 1.8.3.2 Subject: [Buildroot] [PATCH v2] dropwatch: fix avr32 build failure X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net From: Simon Dawson On avr32, dropwatch needs libiberty to avoid build failures such as http://autobuild.buildroot.net/results/cd5/cd5e22fb5c9b0fc5d396bc85a5e253a1a65054da/ Also test built on ARM. Signed-off-by: Simon Dawson --- v2: Handle using LDFLAGS in package makefile, rather than by patching. This was suggested by Peter Korsgaard. package/dropwatch/dropwatch.mk | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/package/dropwatch/dropwatch.mk b/package/dropwatch/dropwatch.mk index 5d65d86..9d49d1e 100644 --- a/package/dropwatch/dropwatch.mk +++ b/package/dropwatch/dropwatch.mk @@ -13,8 +13,12 @@ DROPWATCH_LICENSE_FILES = COPYING # libbfd may be linked to libintl # Ugly... but LDFLAGS are hardcoded anyway +# +# Also: always need to add -liberty to hardcoded LDFLAGS for avr32 ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y) -DROPWATCH_LDFLAGS = LDFLAGS="-lintl -lbfd -lreadline -lnl-3 -lnl-genl-3" +DROPWATCH_LDFLAGS = LDFLAGS="-lintl -lbfd -liberty -lreadline -lnl-3 -lnl-genl-3" +else +DROPWATCH_LDFLAGS = LDFLAGS="-lbfd -liberty -lreadline -lnl-3 -lnl-genl-3" endif define DROPWATCH_BUILD_CMDS