diff mbox series

editorconfig: fix wildcard expansion

Message ID 01cce88291ac132ca8c881eaaaf3b02a4efa68a9.1702887543.git.yann.morin@orange.com
State Accepted
Headers show
Series editorconfig: fix wildcard expansion | expand

Commit Message

Yann E. MORIN Dec. 18, 2023, 8:19 a.m. UTC
From: "Yann E. MORIN" <yann.morin@orange.com>

It turns out that wildcard expansion, * and ?, is not performed in
matching lists {...}, at least in the vim plugin. The spec is not clear
about that, but refer to "pattern matching through Unix shell-style
wildcards" [0].

So, let's consider that this is not supported. Expand the patterns into
one section each, rather than use a list.

[0] https://spec.editorconfig.org/

Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
---
 .editorconfig | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

Comments

Thomas Petazzoni Dec. 20, 2023, 8:32 p.m. UTC | #1
On Mon, 18 Dec 2023 09:19:03 +0100
<yann.morin@orange.com> wrote:

> From: "Yann E. MORIN" <yann.morin@orange.com>
> 
> It turns out that wildcard expansion, * and ?, is not performed in
> matching lists {...}, at least in the vim plugin. The spec is not clear
> about that, but refer to "pattern matching through Unix shell-style
> wildcards" [0].
> 
> So, let's consider that this is not supported. Expand the patterns into
> one section each, rather than use a list.
> 
> [0] https://spec.editorconfig.org/
> 
> Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
> ---
>  .editorconfig | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
Peter Korsgaard Jan. 7, 2024, 11:21 a.m. UTC | #2
>>>>>   <yann.morin@orange.com> writes:

 > From: "Yann E. MORIN" <yann.morin@orange.com>
 > It turns out that wildcard expansion, * and ?, is not performed in
 > matching lists {...}, at least in the vim plugin. The spec is not clear
 > about that, but refer to "pattern matching through Unix shell-style
 > wildcards" [0].

 > So, let's consider that this is not supported. Expand the patterns into
 > one section each, rather than use a list.

 > [0] https://spec.editorconfig.org/

 > Signed-off-by: Yann E. MORIN <yann.morin@orange.com>

Committed to 2023.11.x, thanks.
diff mbox series

Patch

diff --git a/.editorconfig b/.editorconfig
index 4acaf3486b..af6cf4b449 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -13,11 +13,19 @@  insert_final_newline = true
 indent_style = tab
 indent_size = tab
 
-[{Config*.in*,linux/Config.ext.in}]
+[Config*.in*]
 indent_style = tab
 indent_size = tab
 
-[{Makefile*,*.mk}]
+[linux/Config.ext.in]
+indent_style = tab
+indent_size = tab
+
+[Makefile*]
+indent_style = tab
+indent_size = tab
+
+[*.mk]
 indent_style = tab
 indent_size = tab