| Message ID | 20240419213216.518041-1-angelo.compagnucci@gmail.com |
|---|---|
| Headers | show |
| Series | Fix fail2ban | expand |
On 19/04/2024 23:32, Angelo Compagnucci wrote: > This series fixes fail2ban not installing configuration files in /etc anymore. > While fixing the problem, I discovered a bug in the way we invoke the > pyinstaller.py in pep517 compatibility. > Basically, pyinstaller.py will install data_files defined in setup.py > and tarballed in the wheel inside the directory pointed by the --data parameter, > which is nowadays pointing to /usr of TARGET/STAGING directory. > > I consider this wrong, because the data folder shall point to the > TARGET_DIR/STAGING_DIR to be correct and we shall trust the destination path > expressed in the setup.py. > > In the case of fail2ban, configuration files end up being installed in > /usr/etc/fail2ban instead of /etc/fail2ban. > > v1 -> v2: > Fix signed off with correct email. > v2 -> v3: > Fix commit author too > > > Angelo Compagnucci (2): > package/fail2ban: fix data_files installation path > package/pkg-python: fix pep517 data files installation Applied both to master, thanks. I added the Upstream: tag as suggested by Fiona. Still, I think it would be good to report the issue upstream, so they can take it into account when they eventually get around to migrating to a pep517 build system. I also changed the order of the two commits, and removed the Fixes entry from the one in pkg-python. Do you know if this issue also occurs on 2024.02.x and 2024.05.x? Regards, Arnout > > ...001-setup.py-fix-data-relative-paths.patch | 73 +++++++++++++++++++ > package/pkg-python.mk | 4 +- > 2 files changed, 75 insertions(+), 2 deletions(-) > create mode 100644 package/fail2ban/0001-setup.py-fix-data-relative-paths.patch >
Il giorno ven 12 lug 2024 alle ore 15:42 Arnout Vandecappelle < arnout@mind.be> ha scritto: > > > On 19/04/2024 23:32, Angelo Compagnucci wrote: > > This series fixes fail2ban not installing configuration files in /etc > anymore. > > While fixing the problem, I discovered a bug in the way we invoke the > > pyinstaller.py in pep517 compatibility. > > Basically, pyinstaller.py will install data_files defined in setup.py > > and tarballed in the wheel inside the directory pointed by the --data > parameter, > > which is nowadays pointing to /usr of TARGET/STAGING directory. > > > > I consider this wrong, because the data folder shall point to the > > TARGET_DIR/STAGING_DIR to be correct and we shall trust the destination > path > > expressed in the setup.py. > > > > In the case of fail2ban, configuration files end up being installed in > > /usr/etc/fail2ban instead of /etc/fail2ban. > > > > v1 -> v2: > > Fix signed off with correct email. > > v2 -> v3: > > Fix commit author too > > > > > > Angelo Compagnucci (2): > > package/fail2ban: fix data_files installation path > > package/pkg-python: fix pep517 data files installation > > Applied both to master, thanks. > > I added the Upstream: tag as suggested by Fiona. Still, I think it would > be > good to report the issue upstream, so they can take it into account when > they > eventually get around to migrating to a pep517 build system. > > I also changed the order of the two commits, and removed the Fixes entry > from > the one in pkg-python. > > Do you know if this issue also occurs on 2024.02.x and 2024.05.x? > I sent the patch on April 19 to silence the numerous package failings I was already receiving. Not sure for the 2024.05, but surely the 2024.05 is affected. > > Regards, > Arnout > > > > > ...001-setup.py-fix-data-relative-paths.patch | 73 +++++++++++++++++++ > > package/pkg-python.mk | 4 +- > > 2 files changed, 75 insertions(+), 2 deletions(-) > > create mode 100644 > package/fail2ban/0001-setup.py-fix-data-relative-paths.patch > > >
>>>>> "Angelo" == Angelo Compagnucci <angelo.compagnucci@gmail.com> writes: Hi, >> Do you know if this issue also occurs on 2024.02.x and 2024.05.x? >> > I sent the patch on April 19 to silence the numerous package failings I was > already receiving. Not sure for the 2024.05, but surely the 2024.05 is > affected. I was unable to reproduce it on 2024.02.x, but it indeed also fails on 2024.05.x. I believe it was introduced by commit 8937db8dd595e (package/pkg-python.mk: migrate setuptools to pep517). So committed both to 2024.05.x, thanks.