[0/3] Add support for the WPE WebKit RDK backend

Hello all,

This patch series allows using the RDK backend for WPE WebKit. Currently the
main use case is to run WPEWebKit on RaspberryPi boards using on Dispmanx via
the rpi-userland EGL/GLES libraries.

In order to allow using the new wpebackend-rdk package I needed to un-hardcode
usage of wpebackend-fdo, in two places:

 - The cog package may be built without wpebackend-fdo, passing an empty
   list of platform plug-ins. It has built-in support to load "simple"
   WPE backends like wpebackend-rdk. This was done by adding a config
   option for the headless plug-in, instead of always building it, and
   adjusting dependencies.

 - The wpewebkit package does not need wpebackend-fdo at all during the
   build. It only needs a backend installed at run time. This means it is
   enough to make wpewebkit have a "depends on" on any of the backends,
   to make sure they will be in the build, but none needs to be listed in
   WPEWEBKIT_DEPENDENCIES.

I have tested this making builds based on raspberrypi3_defconfig, adding
rpi-userland and then picking wpebackend-rdk + wpewebkit + cog.

Hopefully the patch set is fine and nothing has slipped in the Kconfig
dependencies (typically my weakest part of Buildroot contributions).

Best regards,
-Adrian

Adrian Perez de Castro (3):
  package/wpebackend-rdk: new package
  package/cog: depend on wpebackend-fdo only if needed
  package/wpewebkit: do not depend on wpebackend-fdo

 package/Config.in                          |  1 +
 package/cog/Config.in                      | 28 ++++++++++-
 package/cog/cog.mk                         | 13 +++--
 package/wpebackend-rdk/Config.in           | 57 ++++++++++++++++++++++
 package/wpebackend-rdk/wpebackend-rdk.hash |  5 ++
 package/wpebackend-rdk/wpebackend-rdk.mk   | 43 ++++++++++++++++
 package/wpewebkit/Config.in                |  9 ++--
 package/wpewebkit/wpewebkit.mk             |  2 +-
 8 files changed, 147 insertions(+), 11 deletions(-)
 create mode 100644 package/wpebackend-rdk/Config.in
 create mode 100644 package/wpebackend-rdk/wpebackend-rdk.hash
 create mode 100644 package/wpebackend-rdk/wpebackend-rdk.mk

--
2.43.0

Hello Adrian,

On Thu,  8 Feb 2024 11:55:27 +0200
Adrian Perez de Castro <aperez@igalia.com> wrote:

> This patch series allows using the RDK backend for WPE WebKit. Currently the
> main use case is to run WPEWebKit on RaspberryPi boards using on Dispmanx via
> the rpi-userland EGL/GLES libraries.

Thanks for this patch series!

We have some other patches in patchwork related to webkit:

Some from you:

https://patchwork.ozlabs.org/project/buildroot/patch/20230423213001.2961215-1-aperez@igalia.com/
https://patchwork.ozlabs.org/project/buildroot/patch/20230423213233.2961770-1-aperez@igalia.com/

Are they still valid/application?

We also have twice the same (?) patch from Giulio:

https://patchwork.ozlabs.org/project/buildroot/patch/20230221161522.3749804-1-giulio.benetti@benettiengineering.com/
https://patchwork.ozlabs.org/project/buildroot/patch/20230221161522.3749804-2-giulio.benetti@benettiengineering.com/

is it relevant?

Could you have a look so we can hopefully clear up the backlog?

Thanks a lot!

Thomas

Hi Thomas, all,

On Thu, 08 Feb 2024 11:29:40 +0100 Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> Hello Adrian,
> 
> On Thu,  8 Feb 2024 11:55:27 +0200
> Adrian Perez de Castro <aperez@igalia.com> wrote:
> 
> > This patch series allows using the RDK backend for WPE WebKit. Currently the
> > main use case is to run WPEWebKit on RaspberryPi boards using on Dispmanx via
> > the rpi-userland EGL/GLES libraries.
> 
> Thanks for this patch series!

:-)
 
> We have some other patches in patchwork related to webkit:
> 
> Some from you:
> 
> https://patchwork.ozlabs.org/project/buildroot/patch/20230423213001.2961215-1-aperez@igalia.com/
> https://patchwork.ozlabs.org/project/buildroot/patch/20230423213233.2961770-1-aperez@igalia.com/
> 
> Are they still valid/application?

These two are no longer needed after the update to wpewebkit and
webkitgtk 2.44.x
 
> We also have twice the same (?) patch from Giulio:
> 
> https://patchwork.ozlabs.org/project/buildroot/patch/20230221161522.3749804-1-giulio.benetti@benettiengineering.com/
> https://patchwork.ozlabs.org/project/buildroot/patch/20230221161522.3749804-2-giulio.benetti@benettiengineering.com/
> 
> is it relevant?

I think these two shouldn't be needed anymore, Giulio sent a PR to
upstream WebKit which ended up being merged [1] and it was included
in the 2.44.x releases as well.

> Could you have a look so we can hopefully clear up the backlog?
> Thanks a lot!

My apologies for taking so long to reply, somehow I managed to let
this slip ^_^

Cheers,
—Adrián

---
[1] https://github.com/WebKit/WebKit/commit/360f2f938bba406c0e9bff52710a13c74eb8d1e9

Hello All,

On 15/06/24 01:45, Adrian Perez de Castro wrote:
[ SNIP ]

>> We also have twice the same (?) patch from Giulio:
>>
>> https://patchwork.ozlabs.org/project/buildroot/patch/20230221161522.3749804-1-giulio.benetti@benettiengineering.com/
>> https://patchwork.ozlabs.org/project/buildroot/patch/20230221161522.3749804-2-giulio.benetti@benettiengineering.com/
>>
>> is it relevant?
> 
> I think these two shouldn't be needed anymore, Giulio sent a PR to
> upstream WebKit which ended up being merged [1] and it was included
> in the 2.44.x releases as well.
> 

I have missed Github notification on merge 1 year ago. Anyway I've
marked both patches as rejected on Patchwork since they are upstreamed.

Best regards

Hello Adrian,

On Sat, 15 Jun 2024 02:45:13 +0300
Adrian Perez de Castro <aperez@igalia.com> wrote:

> > Some from you:
> > 
> > https://patchwork.ozlabs.org/project/buildroot/patch/20230423213001.2961215-1-aperez@igalia.com/
> > https://patchwork.ozlabs.org/project/buildroot/patch/20230423213233.2961770-1-aperez@igalia.com/
> > 
> > Are they still valid/application?  
> 
> These two are no longer needed after the update to wpewebkit and
> webkitgtk 2.44.x

Thanks, I marked those two patches as "Superseded".

> > We also have twice the same (?) patch from Giulio:
> > 
> > https://patchwork.ozlabs.org/project/buildroot/patch/20230221161522.3749804-1-giulio.benetti@benettiengineering.com/
> > https://patchwork.ozlabs.org/project/buildroot/patch/20230221161522.3749804-2-giulio.benetti@benettiengineering.com/
> > 
> > is it relevant?  
> 
> I think these two shouldn't be needed anymore, Giulio sent a PR to
> upstream WebKit which ended up being merged [1] and it was included
> in the 2.44.x releases as well.

ACK, Giulio took care of changing the state of those other two patches
in patchwork.

> > Could you have a look so we can hopefully clear up the backlog?
> > Thanks a lot!  
> 
> My apologies for taking so long to reply, somehow I managed to let
> this slip ^_^

No worries :-)

Thanks!

Thomas