| Message ID | 20221004110421.137795-1-angelo@amarulasolutions.com |
|---|---|
| Headers | show |
| Series | Configure default wifi through kconfig | expand |
On 04/10/2022 13:04, Angelo Compagnucci wrote: > This series was born while adding support for a board and feeling the > necessity to have the networking options available in .config. > I understand that something like that could be done by adding an > overlay, but it requires a lot of boilerplate only to be able to connect > to a wifi network. As you say, it's something that can easily be added in an overlay. In addition, it's something that is only useful in a very specific, very small use case: when you're demonstrating a board of which you use only in a single place and aren't planning to move anywhere else, and when you don't want ot spend time preparing a proper overlay for it. So, I'm going to mark this series as rejected. That said, there are some useful bits in it, which I'll comment on individually. Regards, Arnout > > Angelo Compagnucci (5): > system: adding options for configuring wifi > package/wpa_supplicant: configure wifi on systemv when enabled > package/wpa_supplicant: configure wifi on systemd when enabled > package/ifupdown-scripts: add wifi configuration when enabled > package/initscripts: add service to load kernel modules at boot > > package/ifupdown-scripts/ifupdown-scripts.mk | 2 + > package/initscripts/init.d/S11modules | 59 ++++++++++++++++++++ > package/wpa_supplicant/wpa_supplicant.mk | 24 ++++++++ > system/Config.in | 15 +++++ > 4 files changed, 100 insertions(+) > create mode 100644 package/initscripts/init.d/S11modules >
On 30/09/2023 18:06, Arnout Vandecappelle wrote: > > > On 04/10/2022 13:04, Angelo Compagnucci wrote: >> This series was born while adding support for a board and feeling the >> necessity to have the networking options available in .config. >> I understand that something like that could be done by adding an >> overlay, but it requires a lot of boilerplate only to be able to connect >> to a wifi network. > > As you say, it's something that can easily be added in an overlay. In > addition, it's something that is only useful in a very specific, very small > use case: when you're demonstrating a board of which you use only in a single > place and aren't planning to move anywhere else, and when you don't want ot > spend time preparing a proper overlay for it. > > So, I'm going to mark this series as rejected. > > That said, there are some useful bits in it, which I'll comment on individually. In a discussion thread on v3, you wrote that currently this is your documentation: # wpa_passphrase ACCESSPOINTNAME >> /etc/wpa_supplicant.conf (type password and enter) # wpa_supplicant -i wlan0 -c /etc/wpa_supplicant.conf -B # udhcpc -i wlan0 Basically, removing the need for the latter two steps is worthwhile, but the first step is only reasonable to do on the device itself. Regards, Arnout > > Regards, > Arnout > >> >> Angelo Compagnucci (5): >> system: adding options for configuring wifi >> package/wpa_supplicant: configure wifi on systemv when enabled >> package/wpa_supplicant: configure wifi on systemd when enabled >> package/ifupdown-scripts: add wifi configuration when enabled >> package/initscripts: add service to load kernel modules at boot >> >> package/ifupdown-scripts/ifupdown-scripts.mk | 2 + >> package/initscripts/init.d/S11modules | 59 ++++++++++++++++++++ >> package/wpa_supplicant/wpa_supplicant.mk | 24 ++++++++ >> system/Config.in | 15 +++++ >> 4 files changed, 100 insertions(+) >> create mode 100644 package/initscripts/init.d/S11modules >>