| Message ID | 20220722202151.76235-1-thomas.petazzoni@bootlin.com |
|---|---|
| Headers | show |
| Series | genimage.cfg file clean-up | expand |
Thomas, Giulio, All, On 2022-07-22 22:21 +0200, Thomas Petazzoni via buildroot spake thusly: > This small series is a revamp of Giulio's series cleaning up > genimage.cfg. This new version is the result of some discussion > between Arnout and me to find a middle-ground situation. Applied to master, Thanks! I'll further reply to patch 3 with a very minor comment. Regards, Yann E. MORIN. > So what we propose is to: > > - Use the U and F specifiers provided by genimage for the EFI System > Partition and FAT32 partitions respectively. > > - Use the L specifier (explicitly specified in genimage.cfg, even > though it is the default), for the root filesystem or other Linux > filesystems. This means we would not comply with the > systemd-specific Discoverable Partitions Specification > (https://systemd.io/DISCOVERABLE_PARTITIONS/), but we don't see the > point of this specification (which requires identifying root > filesystems for different architecture by different GUID) in the > context of Buildroot. However, while we recommend using L for all > new genimage.cfg, we do not change existing genimage.cfg, to not > break them. > > In this series, none of the patches except the last make any > functional change. The last patch does introduce some functional > change: some partitions were identified as EFI System Partition even > though they are not: the last commit converts them to use the "F" > type, used for FAT filesystems. > > Best regards, > > Thomas Petazzoni > > Thomas Petazzoni (8): > board/orangepi/common/genimage.cfg: use quotes around "gpt" > board/*/genimage.cfg: use partition-table-type = "gpt" > docs/manual: update documentation about partition-type-uuid convention > in genimage.cfg > board/orangepi/orangepi-r1/genimage.cfg: remove double quotes around > partition-type-uuid values > board/orangepi/orangepi-r1/genimage.cfg: use correct partition type > board/*/genimage.cfg: use partition-type-uuid U where relevant > board/sifive/hifive-unleashed/genimage*: convert partition-type-uuid > values to lower-case > board/*/genimage.cfg: use partition-type-uuid = F for some FAT > partitions > > board/aarch64-efi/genimage-efi.cfg | 2 +- > board/friendlyarm/nanopc-t4/genimage.cfg | 2 +- > board/friendlyarm/nanopi-m4/genimage.cfg | 2 +- > board/octavo/osd32mp1-brk/genimage.cfg | 2 +- > board/octavo/osd32mp1-red/genimage.cfg | 2 +- > board/olimex/stmp1_olinuxino/genimage.cfg | 2 +- > board/orangepi/common/genimage.cfg | 2 +- > board/orangepi/orangepi-r1/genimage.cfg | 4 ++-- > board/pc/genimage-efi.cfg | 2 +- > board/pine64/rockpro64/genimage.cfg | 2 +- > board/qemu/aarch64-sbsa/genimage.cfg | 2 +- > board/radxa/rockpi-4/genimage.cfg | 2 +- > board/radxa/rockpi-n10/genimage.cfg | 2 +- > board/radxa/rockpi-n8/genimage.cfg | 2 +- > board/seeed/stm32mp157c-odyssey/genimage.cfg | 2 +- > board/sifive/hifive-unleashed/genimage_sdcard.cfg | 6 +++--- > board/sifive/hifive-unleashed/genimage_spi-nor.cfg | 4 ++-- > .../common/stm32mp157/genimage.cfg.template | 2 +- > docs/manual/writing-rules.txt | 12 ++++++++++++ > 19 files changed, 34 insertions(+), 22 deletions(-) > > -- > 2.37.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
Hello, This small series is a revamp of Giulio's series cleaning up genimage.cfg. This new version is the result of some discussion between Arnout and me to find a middle-ground situation. So what we propose is to: - Use the U and F specifiers provided by genimage for the EFI System Partition and FAT32 partitions respectively. - Use the L specifier (explicitly specified in genimage.cfg, even though it is the default), for the root filesystem or other Linux filesystems. This means we would not comply with the systemd-specific Discoverable Partitions Specification (https://systemd.io/DISCOVERABLE_PARTITIONS/), but we don't see the point of this specification (which requires identifying root filesystems for different architecture by different GUID) in the context of Buildroot. However, while we recommend using L for all new genimage.cfg, we do not change existing genimage.cfg, to not break them. In this series, none of the patches except the last make any functional change. The last patch does introduce some functional change: some partitions were identified as EFI System Partition even though they are not: the last commit converts them to use the "F" type, used for FAT filesystems. Best regards, Thomas Petazzoni Thomas Petazzoni (8): board/orangepi/common/genimage.cfg: use quotes around "gpt" board/*/genimage.cfg: use partition-table-type = "gpt" docs/manual: update documentation about partition-type-uuid convention in genimage.cfg board/orangepi/orangepi-r1/genimage.cfg: remove double quotes around partition-type-uuid values board/orangepi/orangepi-r1/genimage.cfg: use correct partition type board/*/genimage.cfg: use partition-type-uuid U where relevant board/sifive/hifive-unleashed/genimage*: convert partition-type-uuid values to lower-case board/*/genimage.cfg: use partition-type-uuid = F for some FAT partitions board/aarch64-efi/genimage-efi.cfg | 2 +- board/friendlyarm/nanopc-t4/genimage.cfg | 2 +- board/friendlyarm/nanopi-m4/genimage.cfg | 2 +- board/octavo/osd32mp1-brk/genimage.cfg | 2 +- board/octavo/osd32mp1-red/genimage.cfg | 2 +- board/olimex/stmp1_olinuxino/genimage.cfg | 2 +- board/orangepi/common/genimage.cfg | 2 +- board/orangepi/orangepi-r1/genimage.cfg | 4 ++-- board/pc/genimage-efi.cfg | 2 +- board/pine64/rockpro64/genimage.cfg | 2 +- board/qemu/aarch64-sbsa/genimage.cfg | 2 +- board/radxa/rockpi-4/genimage.cfg | 2 +- board/radxa/rockpi-n10/genimage.cfg | 2 +- board/radxa/rockpi-n8/genimage.cfg | 2 +- board/seeed/stm32mp157c-odyssey/genimage.cfg | 2 +- board/sifive/hifive-unleashed/genimage_sdcard.cfg | 6 +++--- board/sifive/hifive-unleashed/genimage_spi-nor.cfg | 4 ++-- .../common/stm32mp157/genimage.cfg.template | 2 +- docs/manual/writing-rules.txt | 12 ++++++++++++ 19 files changed, 34 insertions(+), 22 deletions(-)