| Message ID | 20180820115519.24046-1-chrismcc@gmail.com |
|---|---|
| Headers | show |
| Series | perl modules again | expand |
Hello, Note: the title of your cover letter says PATCH 00/13, but your series has 18 patches. Seems like something went wrong. On Mon, 20 Aug 2018 04:55:01 -0700, Christopher McCrory wrote: > Christopher McCrory (18): > perl-dbi: add host package > perl-dbd-mysql: new package > perl-data-dump: new package > perl-time-parsedate: new package > perl-x10: new package > perl-sys-cpu: new package > perl-dist-checkconflicts: new package > perl-package-stash: new package > perl-class-load: new package > perl-template-toolkit: new package > perl-xml-parser: new package > perl-soap-wsdl: new package > perl-time-parsedate: add license > perl-termreadkey: new package > pkg-utils.mk: patch_sub_makefile > perl-template-toolkit: use new patch_sub_makefile > perl-xml-parser: use new patch_sub_makefile > perl-soap-wsdl: add dependancy on perl-termreadkey Note: you still had a number of patches pending. Some of them are in this new series some not, which is a bit unclear on which ones you still want to get merged, which one you do want. I've marked all those older patches as Superseded: http://patchwork.ozlabs.org/patch/956316/ http://patchwork.ozlabs.org/patch/956592/ http://patchwork.ozlabs.org/patch/956590/ http://patchwork.ozlabs.org/patch/956598/ Best regards, Thomas
On Mon, Aug 20, 2018 at 5:10 AM, Thomas Petazzoni < thomas.petazzoni@bootlin.com> wrote: > Hello, > > Note: the title of your cover letter says PATCH 00/13, but your series > has 18 patches. Seems like something went wrong. > > Copy and paste error, Oops. There are 18 patches > On Mon, 20 Aug 2018 04:55:01 -0700, Christopher McCrory wrote: > > <snip> > > > Note: you still had a number of patches pending. Some of them are in > this new series some not, which is a bit unclear on which ones you > still want to get merged, which one you do want. I've marked all those > older patches as Superseded: > > Yea, this supersedes all previous perl patch submitals. > http://patchwork.ozlabs.org/patch/956316/ > http://patchwork.ozlabs.org/patch/956592/ > http://patchwork.ozlabs.org/patch/956590/ > http://patchwork.ozlabs.org/patch/956598/ > > Best regards, > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering > https://bootlin.com >
Hello,
On Mon, 20 Aug 2018 05:15:58 -0700, Christopher McCrory wrote:
> Copy and paste error, Oops. There are 18 patches
It cannot be a copy/paste error if done right: the cover letter is
generated automatically by "git format-patch --cover".
Best regards,
Thomas
On Mon, Aug 20, 2018 at 5:28 AM, Thomas Petazzoni < thomas.petazzoni@bootlin.com> wrote: > Hello, > > On Mon, 20 Aug 2018 05:15:58 -0700, Christopher McCrory wrote: > > > Copy and paste error, Oops. There are 18 patches > > It cannot be a copy/paste error if done right: the cover letter is > generated automatically by "git format-patch --cover". > > Something like: commit 13 patches git format-patch --cover-letter -M -n -s -o perl origin/next edit perl/0000-cover-letter.patch commit more git format-patch --cover-letter -M -n -s -o perl2 origin/next edit perl2/0000-cover-letter.patch copy in text from previous edit including subject :( Best regards, > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering > https://bootlin.com >
Hello Christopher, On Mon, 20 Aug 2018 04:55:01 -0700, Christopher McCrory wrote: > Christopher McCrory (18): > perl-dbi: add host package > perl-dbd-mysql: new package > perl-data-dump: new package > perl-time-parsedate: new package > perl-x10: new package > perl-sys-cpu: new package > perl-dist-checkconflicts: new package > perl-package-stash: new package > perl-class-load: new package So up to this point, I have applied the patches. > perl-template-toolkit: new package > perl-xml-parser: new package Those two patches are pending a resolution on the discussion on whether we really need to patch the Makefile in sub-directories, or if we can have them properly generated. If we need to patch them, I have suggested how to integrate this in the pkg-perl infrastructure, and I would like this to be done and then used by the packages. > perl-soap-wsdl: new package On this one, there is the question of the dependency on perl-termreadkey. > perl-time-parsedate: add license This one is no longer needed, I marked as Superseded. > perl-termreadkey: new package This one you said yourself does not cross-compile. > pkg-utils.mk: patch_sub_makefile > perl-template-toolkit: use new patch_sub_makefile > perl-xml-parser: use new patch_sub_makefile > perl-soap-wsdl: add dependancy on perl-termreadkey So, I've marked all those remaining patches as Changes Requested. Could you work on fixing the above issues, and send an updated version of the patch series ? Or possibly separate patch series if there are separate sets of packages with no inter dependencies. Best regards, Thomas